diff options
author | Sam Thursfield <sam.thursfield@codethink.co.uk> | 2014-11-19 17:35:21 +0000 |
---|---|---|
committer | Sam Thursfield <sam.thursfield@codethink.co.uk> | 2014-11-20 12:49:33 +0000 |
commit | 4e98f06721d91ed30aa06a9641ed71ab39ec34ff (patch) | |
tree | e70fa3ce6d650f3f7b7a9a32f17b84115e854af9 /baserockimport | |
parent | 6ebb2acda528ebd324dd74cb0ab2521f2e4aca6f (diff) | |
download | import-4e98f06721d91ed30aa06a9641ed71ab39ec34ff.tar.gz |
rubygems.to_chunk: Clarify FIXME comment
Diffstat (limited to 'baserockimport')
-rwxr-xr-x | baserockimport/exts/rubygems.to_chunk | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/baserockimport/exts/rubygems.to_chunk b/baserockimport/exts/rubygems.to_chunk index c1a3e7c..1573d8b 100755 --- a/baserockimport/exts/rubygems.to_chunk +++ b/baserockimport/exts/rubygems.to_chunk @@ -154,9 +154,11 @@ class RubyGemChunkMorphologyGenerator < Importer::Base "source code in #{source_dir_name}") resolved_specs = Dir.chdir(source_dir_name) do - # FIXME: we don't need to do this here, it'd be enough just to load - # the given gemspec - definition = create_bundler_definition_for_gemspec(gem_name) + # FIXME: resolving the specs for all the dependencies of the target gem + # isn't necessary here. In fact, just reading/executing the .gemspec + # would be enough, and would speed this program up and remove a lot of + # pointless network access to rubygems.org. + definition = create_bundler_definition_for_gemspec(gem_name, source_dir_name) definition.resolve_remotely! end |