diff options
author | Lars Wirzenius <lars.wirzenius@codethink.co.uk> | 2014-04-22 14:14:23 +0000 |
---|---|---|
committer | Lars Wirzenius <lars.wirzenius@codethink.co.uk> | 2014-04-22 14:14:23 +0000 |
commit | 5d10e7584ce134998766223d371d3ee22ad9d017 (patch) | |
tree | fa75610fc2cc763046bff5d1845416cdd6dcbd6c | |
parent | 1d17b2bde2da902418681f9d0d7d5c0f2d19c825 (diff) | |
download | lorry-controller-5d10e7584ce134998766223d371d3ee22ad9d017.tar.gz |
Add a FIXME comment about losing output while killing
-rwxr-xr-x | lorry-controller-minion | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/lorry-controller-minion b/lorry-controller-minion index fe2089f..c269645 100755 --- a/lorry-controller-minion +++ b/lorry-controller-minion @@ -134,6 +134,12 @@ class MINION(cliapp.Application): if exit is not None: break if kill_job: + # FIXME: The job may have produced more output while + # we were talking to WEBAPP. We are not polling the + # process again, here. This should be fixed. However, + # since the process may be in an unkillable state (D + # state, for example), we also can't wait here until + # it actually dies. Thus, this needs thinking. exit = self.kill_job() self.update_webapp_about_job( job_spec, '', '', exit) |