From fa53202db029c6cef266c40e8be5fde17b60af91 Mon Sep 17 00:00:00 2001 From: Lars Wirzenius Date: Tue, 22 Apr 2014 14:36:24 +0000 Subject: Remove dead code, update FIXME comment --- lorrycontroller/givemejob.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lorrycontroller/givemejob.py b/lorrycontroller/givemejob.py index 067f3c3..44bf9f7 100644 --- a/lorrycontroller/givemejob.py +++ b/lorrycontroller/givemejob.py @@ -112,11 +112,10 @@ class GiveMeJob(lorrycontroller.LorryControllerRoute): desc) except lorrycontroller.GitanoCommandFailure as e: logging.error('ERROR: %s' % str(e)) - # FIXME: The following is commented out, for now. We need - # a good way to report such errors. However, we probably - # don't want to fail the request. - if False: - bottle.abort(500) + # FIXME: We need a good way to report these errors to the + # user. However, we probably don't want to fail the + # request, so that's not the way to do this. Needs + # thinking. def give_job_to_minion(self, statedb, lorry_info, now): path = lorry_info['path'] -- cgit v1.2.1