summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohnny Willemsen <jwillemsen@remedy.nl>2020-08-13 11:37:26 +0200
committerJohnny Willemsen <jwillemsen@remedy.nl>2020-08-13 11:37:26 +0200
commit438ad9963cd33341dd2933a836e57f6ea8d2704e (patch)
treeda95277782f7049759a9d6c9cd851b6cc285844f
parent881df13c63134b837bd8f488a1758e14bf8ebcde (diff)
downloadATCD-438ad9963cd33341dd2933a836e57f6ea8d2704e.tar.gz
Layout, docu changes and add some missing explicits
* ACE/ASNMP/README: * ACE/ASNMP/asnmp-overview.html: * ACE/ASNMP/asnmp/gauge.h: * ACE/ASNMP/asnmp/integer.h:
-rw-r--r--ACE/ASNMP/README2
-rw-r--r--ACE/ASNMP/asnmp-overview.html48
-rw-r--r--ACE/ASNMP/asnmp/gauge.h2
-rw-r--r--ACE/ASNMP/asnmp/integer.h2
4 files changed, 26 insertions, 28 deletions
diff --git a/ACE/ASNMP/README b/ACE/ASNMP/README
index a3f6926f87d..e9bd5ebd174 100644
--- a/ACE/ASNMP/README
+++ b/ACE/ASNMP/README
@@ -1,5 +1,3 @@
-
-
====================================================================
ASNMP = ACE+SNMP++ Version 2.1
By Michael R. MacFaden mrm@acm.org, mrm@yagosys.com
diff --git a/ACE/ASNMP/asnmp-overview.html b/ACE/ASNMP/asnmp-overview.html
index 2c9c8e9fd49..6100a4d0b5e 100644
--- a/ACE/ASNMP/asnmp-overview.html
+++ b/ACE/ASNMP/asnmp-overview.html
@@ -9,20 +9,20 @@
toolkit for using IETF standard network management protocols in the
Internet. The SNMP protocol is perhaps the most ubiquitous management
protocol running on most very device or application deployed in the
-modern network today.
+modern network today.
<p>ASNMP is targeted to programmers that want to write command and
-control (C&C) applications. C&C Applications communicate with
-a variety of objects:
+control (C&C) applications. C&C Applications communicate with
+a variety of objects:
<sl>
-<li>network devices such as ATM switches, Internet routers,
+<li>network devices such as ATM switches, Internet routers,
LAN bridges and LAN printers
<li>Routing protocols such as OSPF
<li>database servers such as ORACLE or Informix.
<p>ASNMP Version 1 implements a blocking SNMP Version 1 with some
Version 2c additions (Counter32, Counter64 SMI values). See
-SNMP Version 1 as defined in the IETF Request for Comments (RFC)
+SNMP Version 1 as defined in the IETF Request for Comments (RFC)
<sl>
<li>1155
<li>1157
@@ -31,39 +31,39 @@ SNMP Version 1 as defined in the IETF Request for Comments (RFC)
<sl>
<p>Also see the RFC 1902 spec for new SMI datatypes such as Counter64.
-<p>ASNMP is built using the CMU SNMP and HP SNMP++ as the base
-classes then modified for use in the ACE framework. About 10% of the API
-changed during code rework. See ASNMP/asnmp/ChangeLog for details.
+<p>ASNMP is built using the CMU SNMP and HP SNMP++ as the base
+classes then modified for use in the ACE framework. About 10% of the API
+changed during code rework. See ASNMP/asnmp/ChangeLog for details.
<p>ASNMP can be used for either manager applications or agent applications.
The <i>Snmp</i> class contains the interface for manager applications. The
<i>sagent</i> class contains the interface for agent applications. A
trivial agent that implements the mib II system group per rfc1213 is
-in the agents/ directory.
-
-<h2>Class Heirarchy</h2>
+in the agents/ directory.
+
+<h2>Class Hierarchy</h2>
<pre>
-UdpTarget - Defines a collection of attributes needed to define a
- communications session with an SNMP agent
+UdpTarget - Defines a collection of attributes needed to define a
+ communications session with an SNMP agent
This includes network address, response timeout, etc.
-
+
Snmp - A logical session between NM app and agent. Provides the
- commands get, get_next, trap. Manages transactions between app and
+ commands get, get_next, trap. Manages transactions between app and
server.
Pdu - A container object that represents an SNMP Protocol Data Unit.
- A Pdu contains a command (get,getnext,trap) Varbind List list,
+ A Pdu contains a command (get,getnext,trap) Varbind List list,
a community string.
-Vb - Aka Varbind or Variable Binding. A pdu can have zero,
- one or more of these. A Vb consists of an Oid to identify
- the variable and a value corresponding to one of the SMI values.
+Vb - Aka Varbind or Variable Binding. A pdu can have zero,
+ one or more of these. A Vb consists of an Oid to identify
+ the variable and a value corresponding to one of the SMI values.
The oid/value binding is defined in a MIB file (RFC 1155)
Agents hava a MIB file that defines what each variable means.
- Most agents implement MIB II as defined in RFC 1156.
+ Most agents implement MIB II as defined in RFC 1156.
-<p>The Structure of Managment Information (SMI) datatypes
+<p>The Structure of Management Information (SMI) datatypes
and related types are:
<ul>
<li>Address->IpAddress->UdpAddress as well as MAC, IPX, IPXSOCK, Netbios
@@ -91,7 +91,7 @@ class system_id {
Snmp snmp;
Pdu pdu;
Oid oid("1.3.6.1.2.1.1.1.0");
- Vb vb(oid);
+ Vb vb(oid);
tgt.set_address(addr);
tgt.set_read_community(read_community_string);
pdu += vb;
@@ -111,14 +111,14 @@ class system_id {
private:
OctetStr desc_;
-};
+};
<h1>Future Directions</h1>
<p>Here are some areas for further work
<sl>
<li>Add OO mib parser and mib code generator
<li>Collapse the CMU/HP code into one set of classes.
-<li>Add full V2c support.
+<li>Add full V2c support.
<li>Size/Speed improvements
</sl>
diff --git a/ACE/ASNMP/asnmp/gauge.h b/ACE/ASNMP/asnmp/gauge.h
index c29f24e6d36..3e5a87fc02e 100644
--- a/ACE/ASNMP/asnmp/gauge.h
+++ b/ACE/ASNMP/asnmp/gauge.h
@@ -47,7 +47,7 @@ class ASNMP_Export Gauge32: public SnmpUInt32
{
public:
/// constructor with a value
- Gauge32( const unsigned long i = 0);
+ explicit Gauge32( const unsigned long i = 0);
/// copy constructor
Gauge32 ( const Gauge32 &g);
diff --git a/ACE/ASNMP/asnmp/integer.h b/ACE/ASNMP/asnmp/integer.h
index 5bf053cf2a4..ecc83a0482e 100644
--- a/ACE/ASNMP/asnmp/integer.h
+++ b/ACE/ASNMP/asnmp/integer.h
@@ -47,7 +47,7 @@ class ASNMP_Export SnmpUInt32 : public SnmpSyntax
{
public:
/// default constructor
- SnmpUInt32 (const unsigned long i = 0);
+ explicit SnmpUInt32 (const unsigned long i = 0);
/// copy constructor
SnmpUInt32( const SnmpUInt32 &c);