ChangeLogTag: Mon Apr 14 07:05:06 2003 Chad Elliott <elliott_c@ociweb.com>

4 files changed, 66 insertions, 56 deletions

diff --git a/ChangeLog b/ChangeLog
index 6cb352d4b77..f886296c509 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,25 +1,36 @@
+Mon Apr 14 07:05:06 2003  Chad Elliott  <elliott_c@ociweb.com>
+
+        * bin/MakeProjectCreator/modules/ProjectCreator.pm:
+
+          Fixed a usage of undefined reference.
+
+        * bin/mpc.pl:
+        * bin/mwc.pl:
+
+          Added a -w to the command line to get the warnings.
+
 Mon Apr 14 10:55:48 2003  Simon McQueen  <sm@prismtechnologies.com>
 
-	* bin/msvc_auto_compile.pl: Amended the -TAO target so that
-	TAO/orbsvcs/test/Notify/lib is the first library built. Fixes
-	build error in TAO_RT_NotifyTests.dsp which depends on it.
+        * bin/msvc_auto_compile.pl: Amended the -TAO target so that
+        TAO/orbsvcs/test/Notify/lib is the first library built. Fixes
+        build error in TAO_RT_NotifyTests.dsp which depends on it.
 
 Mon Apr 14 10:14:54 2003  Simon McQueen  <sm@prismtechnologies.com>
 
-	* bin/MakeProjectCreator/config/namingexe.mpb:
-	* bin/MakeProjectCreator/config/server.mpb:
-	  Added missing libpath entries.
+        * bin/MakeProjectCreator/config/namingexe.mpb:
+        * bin/MakeProjectCreator/config/server.mpb:
+          Added missing libpath entries.
 
 Sun Apr 13 23:00:43 UTC 2003  Don Hinton  <dhinton@dresystems.com>
 
         * bin/generate_compile_stats.sh:
-        
+
           Modified script to pull date directly from build log,
           only harvest build time for individual objects, dynamically
           rollup objects into composite objects--libs or executables--
           based on link steps in build log, and dynamically generate
-          html pages for composite objects.        
-        
+          html pages for composite objects.
+
 Fri Apr 11 18:05:00 2003  Roy Pollock  <rpollock@ghs.com>
 
         * ace/config-integritySCA.h
@@ -38,7 +49,7 @@ Fri Apr 11 18:05:00 2003  Roy Pollock  <rpollock@ghs.com>
           Add defined(INTEGRITY) cases
 
         * ace/OS.i
-        
+
           Cast the ACE_NOTSUP_RETURN of umask to mode_t
           Add defined(INTEGRITY) cases
 
diff --git a/bin/MakeProjectCreator/modules/ProjectCreator.pm b/bin/MakeProjectCreator/modules/ProjectCreator.pm
index d766bf7f957..1d083c4f858 100644
--- a/bin/MakeProjectCreator/modules/ProjectCreator.pm
+++ b/bin/MakeProjectCreator/modules/ProjectCreator.pm
@@ -815,7 +815,8 @@ sub generate_default_pch_filenames {
 sub fix_pch_filenames {
   my($self) = shift;
   foreach my $type ('pch_header', 'pch_source') {
-    if ($self->get_assignment($type) eq '') {
+    my($pch) = $self->get_assignment($type);
+    if (defined $pch && $pch eq '') {
       $self->process_assignment($type, undef);
     }
   }
diff --git a/bin/mpc.pl b/bin/mpc.pl
index b4f4cd37241..15a6f0bf9b1 100755
--- a/bin/mpc.pl
+++ b/bin/mpc.pl
@@ -1,5 +1,5 @@
-eval '(exit $?0)' && eval 'exec perl -S $0 ${1+"$@"}'
-    & eval 'exec perl -S $0 $argv:q'
+eval '(exit $?0)' && eval 'exec perl -w -S $0 ${1+"$@"}'
+    & eval 'exec perl -w -S $0 $argv:q'
     if 0;
 
 # ******************************************************************
@@ -16,8 +16,8 @@ use strict;
 use Cwd;
 use File::Basename;
 
-my($basePath) = getExecutePath($0) . "/MakeProjectCreator";
-unshift(@INC, $basePath . "/modules");
+my($basePath) = getExecutePath($0) . '/MakeProjectCreator';
+unshift(@INC, $basePath . '/modules');
 
 require Driver;
 
@@ -42,28 +42,27 @@ my(@creators) = ('GNUACEProjectCreator',
 
 sub which {
   my($prog)   = shift;
-  my($exec)   = "$prog";
-  my($part)   = "";
-  my($isWin)  = ($^O eq "MSWin32");
-  my($envSep) = ($isWin ? ";" : ":");
+  my($exec)   = $prog;
+  my($part)   = '';
+  my($envSep) = ($^O eq 'MSWin32' ? ';' : ':');
 
   if (defined $ENV{'PATH'}) {
     foreach $part (split(/$envSep/, $ENV{'PATH'})) {
       $part .= "/$prog";
-      if ( -x $part ) { 
-        $exec = $part;  
+      if ( -x $part ) {
+        $exec = $part;
         last;
       }
-    }  
-  }    
-       
+    }
+  }
+
   return $exec;
 }
 
 
 sub getExecutePath {
   my($prog) = shift;
-  my($loc)  = "";   
+  my($loc)  = '';
 
   if ($prog ne basename($prog)) {
     if ($prog =~ /^[\/\\]/ ||
@@ -71,21 +70,21 @@ sub getExecutePath {
       $loc = dirname($prog);
     }
     else {
-      $loc = getcwd() . "/" . dirname($prog);
+      $loc = getcwd() . '/' . dirname($prog);
     }
-  }  
+  }
   else {
     $loc = dirname(which($prog));
   }
-   
-  if ($loc eq ".") {
+
+  if ($loc eq '.') {
     $loc = getcwd();
   }
-   
-  if ($loc ne "") {
-    $loc .= "/";   
+
+  if ($loc ne '') {
+    $loc .= '/';
   }
-   
+
   return $loc;
 }
 
diff --git a/bin/mwc.pl b/bin/mwc.pl
index 8560dfe1836..67b9cfc0c6b 100755
--- a/bin/mwc.pl
+++ b/bin/mwc.pl
@@ -1,6 +1,6 @@
-eval '(exit $?0)' && eval 'exec perl -S $0 ${1+"$@"}'
-    & eval 'exec perl -S $0 $argv:q'
-    if 0;  
+eval '(exit $?0)' && eval 'exec perl -w -S $0 ${1+"$@"}'
+    & eval 'exec perl -w -S $0 $argv:q'
+    if 0;
 
 # ******************************************************************
 #      Author: Chad Elliott
@@ -16,8 +16,8 @@ use strict;
 use Cwd;
 use File::Basename;
 
-my($basePath) = getExecutePath($0) . "/MakeProjectCreator";
-unshift(@INC, $basePath . "/modules");
+my($basePath) = getExecutePath($0) . '/MakeProjectCreator';
+unshift(@INC, $basePath . '/modules');
 
 require Driver;
 
@@ -42,28 +42,27 @@ my(@creators) = ('GNUACEWorkspaceCreator',
 
 sub which {
   my($prog)   = shift;
-  my($exec)   = "$prog";
-  my($part)   = "";
-  my($isWin)  = ($^O eq "MSWin32");
-  my($envSep) = ($isWin ? ";" : ":");
+  my($exec)   = $prog;
+  my($part)   = '';
+  my($envSep) = ($^O eq 'MSWin32' ? ';' : ':');
 
   if (defined $ENV{'PATH'}) {
     foreach $part (split(/$envSep/, $ENV{'PATH'})) {
       $part .= "/$prog";
-      if ( -x $part ) { 
-        $exec = $part;  
+      if ( -x $part ) {
+        $exec = $part;
         last;
       }
-    }  
-  }    
-       
+    }
+  }
+
   return $exec;
 }
 
 
 sub getExecutePath {
   my($prog) = shift;
-  my($loc)  = "";   
+  my($loc)  = '';
 
   if ($prog ne basename($prog)) {
     if ($prog =~ /^[\/\\]/ ||
@@ -71,21 +70,21 @@ sub getExecutePath {
       $loc = dirname($prog);
     }
     else {
-      $loc = getcwd() . "/" . dirname($prog);
+      $loc = getcwd() . '/' . dirname($prog);
     }
-  }  
+  }
   else {
     $loc = dirname(which($prog));
   }
-   
-  if ($loc eq ".") {
+
+  if ($loc eq '.') {
     $loc = getcwd();
   }
-   
-  if ($loc ne "") {
-    $loc .= "/";   
+
+  if ($loc ne '') {
+    $loc .= '/';
   }
-   
+
   return $loc;
 }