ChangeLogTag: Thu May 17 12:12:39 2001 Balachandran Natarajan <bala@cs.wustl.edu>

1 files changed, 26 insertions, 10 deletions

diff --git a/TAO/tao/Connection_Purging_Strategy.h b/TAO/tao/Connection_Purging_Strategy.h
index e3716c0ec6e..c5d67e0828e 100644
--- a/TAO/tao/Connection_Purging_Strategy.h
+++ b/TAO/tao/Connection_Purging_Strategy.h
@@ -12,6 +12,10 @@
 #define TAO_PURGING_STRATEGY_H
 #include "ace/pre.h"
 
+// @@ Chad : Please add the PRAGMA stuff..
+// @@ Chad : As a matter of consistency place the keyword void for
+// functions with no arguments..
+
 #include "tao/Transport_Cache_Manager.h"  // Data member
 #include "tao/debug.h"                    // Debug used in the .inl
 #include "ace/Array_Base.h"               // Template definition
@@ -33,16 +37,16 @@ public:
   virtual ~TAO_Connection_Purging_Strategy ();
 
   /// Get the purging percentage
-  int percent () const;
+  int percent (void) const;
 
   /// Set the purging percentage
   void percent (int pvalue);
 
   /// Maximum number of entries in the connection cache
-  int cache_maximum () const;
+  int cache_maximum (void) const;
 
   /// Remove connections based on the underlying strategy
-  int purge ();
+  int purge (void);
 
   /**
    * Pass-through methods to provide access to the cache manager.
@@ -56,7 +60,7 @@ public:
 
   /// Check the cache to see whether the item exists
   /// in the cache and return it.
-  int find_in_cache (TAO_DESCRIPTOR_INTERFACE* prop,     
+  int find_in_cache (TAO_DESCRIPTOR_INTERFACE* prop,
                      TAO_PURGING_CACHE_ITEM*& item);
 
   /// Purge the entry from the cache
@@ -78,14 +82,14 @@ public:
                    TAO_EventHandlerSet &unregistered);
 
   /// Return the total size of the TAO_PURGING_CACHE_MANAGER.
-  size_t total_size () const;
+  size_t total_size (void) const;
   //@}
 
 protected:
   typedef ACE_Array_Base<TAO_DESCRIPTOR_INTERFACE*> DESCRIPTOR_SET;
 
   /// Accessor for the cache manager
-  TAO_PURGING_CACHE_MANAGER& cache_manager ();
+  TAO_PURGING_CACHE_MANAGER& cache_manager (void);
 
   /// Look through the sorted set and close the connection on
   /// the required number of items in the set.
@@ -96,7 +100,7 @@ protected:
   virtual void update_item_i (TAO_DESCRIPTOR_INTERFACE* prop,
                               TAO_PURGING_CACHE_ITEM* item) = 0;
   virtual void remove_item_i (TAO_DESCRIPTOR_INTERFACE* prop) = 0;
-  virtual void remove_all_i () = 0;
+  virtual void remove_all_i (void) = 0;
 
 private:
 
@@ -114,9 +118,21 @@ private:
 };
 
 
+// @@ Chad: Such defintions dont help us in anyway. Do they??
 
 #include "ace/Hash_Map_Manager_T.h"  // Template definition
 
+// @@ Chad: Class description Please..
+//          BTW, I dont see a need for a step in the hierarchy.. Can
+//          you please let me know what is the need for this one step
+//          in the hierarchy? - Bala
+// @@ Chad: If you think this step is required, you may want to put it
+//          in a seperate file.
+// @@ Chad: Why cant all the _i () implementations go in the base
+//    class?
+// @@ Chad:  IMHO, we are having too many maps. Remember foot print?
+//    Can you think of a way to get the info into the Transport map
+
 class TAO_Export TAO_ULong_Connection_Purging_Strategy: public TAO_Connection_Purging_Strategy
 {
 public:
@@ -124,7 +140,7 @@ public:
   TAO_ULong_Connection_Purging_Strategy (TAO_Resource_Factory* rf);
 
   /// The destructor
-  virtual ~TAO_ULong_Connection_Purging_Strategy ();
+  virtual ~TAO_ULong_Connection_Purging_Strategy (void);
 
 protected:
 
@@ -143,9 +159,9 @@ protected:
   virtual void remove_item_i (TAO_DESCRIPTOR_INTERFACE* prop);
 
   /// Remove all entries from tracking_map_
-  virtual void remove_all_i ();
+  virtual void remove_all_i (void);
 
-  HASH_MAP& tracking_map ();
+  HASH_MAP& tracking_map (void);
 
 private: