diff options
Diffstat (limited to 'ACE/tests')
126 files changed, 0 insertions, 278 deletions
diff --git a/ACE/tests/ACE_Init_Test.cpp b/ACE/tests/ACE_Init_Test.cpp index 4884ae93053..62dad5f2ad6 100644 --- a/ACE/tests/ACE_Init_Test.cpp +++ b/ACE/tests/ACE_Init_Test.cpp @@ -122,7 +122,6 @@ wait_and_kill_dialog (void *pBox) ACE_OS::sleep(2); pDialog->EndModalLoop (IDOK); return 0; - } #endif /* ACE_HAS_MFC */ diff --git a/ACE/tests/ARGV_Test.cpp b/ACE/tests/ARGV_Test.cpp index 4f6f90e25cf..64f8e106264 100644 --- a/ACE/tests/ARGV_Test.cpp +++ b/ACE/tests/ARGV_Test.cpp @@ -20,7 +20,6 @@ #include "test_config.h" - static void consume_arg (int argc, ACE_TCHAR *argv[]) { diff --git a/ACE/tests/Arg_Shifter_Test.cpp b/ACE/tests/Arg_Shifter_Test.cpp index 08bb29c2900..407cbdf80b2 100644 --- a/ACE/tests/Arg_Shifter_Test.cpp +++ b/ACE/tests/Arg_Shifter_Test.cpp @@ -15,7 +15,6 @@ #include "test_config.h" - int run_main (int, ACE_TCHAR *[]) { diff --git a/ACE/tests/Array_Map_Test.cpp b/ACE/tests/Array_Map_Test.cpp index 2e48f16b4d4..9d8ad4448ce 100644 --- a/ACE/tests/Array_Map_Test.cpp +++ b/ACE/tests/Array_Map_Test.cpp @@ -336,7 +336,6 @@ index_operator_test () class RefCounted { public: - RefCounted () : refcount_ (0) { @@ -382,9 +381,7 @@ public: } private: - unsigned int * refcount_; - }; // -------- diff --git a/ACE/tests/Auto_IncDec_Test.cpp b/ACE/tests/Auto_IncDec_Test.cpp index e075af5f713..8022519994b 100644 --- a/ACE/tests/Auto_IncDec_Test.cpp +++ b/ACE/tests/Auto_IncDec_Test.cpp @@ -18,7 +18,6 @@ #include "ace/OS_NS_unistd.h" - #if defined (ACE_HAS_THREADS) // Default number of threads. diff --git a/ACE/tests/Barrier_Test.cpp b/ACE/tests/Barrier_Test.cpp index 9f332599731..a79a4d1daf3 100644 --- a/ACE/tests/Barrier_Test.cpp +++ b/ACE/tests/Barrier_Test.cpp @@ -16,7 +16,6 @@ #include "ace/Thread_Manager.h" - #if defined (ACE_HAS_THREADS) struct Tester_Args diff --git a/ACE/tests/Buffer_Stream_Test.cpp b/ACE/tests/Buffer_Stream_Test.cpp index 254a60aa11d..798f61f5e00 100644 --- a/ACE/tests/Buffer_Stream_Test.cpp +++ b/ACE/tests/Buffer_Stream_Test.cpp @@ -23,7 +23,6 @@ #include "ace/OS_NS_time.h" - #if defined (ACE_HAS_THREADS) static const char ACE_ALPHABET[] = "abcdefghijklmnopqrstuvwxyz"; @@ -80,7 +79,6 @@ public: /// Receive message from Supplier and print to stdout. int svc () override; private: - /// Amount of time to wait for a timeout. ACE_Time_Value timeout_; }; diff --git a/ACE/tests/Bug_2540_Regression_Test.cpp b/ACE/tests/Bug_2540_Regression_Test.cpp index 6d624def926..98129661703 100644 --- a/ACE/tests/Bug_2540_Regression_Test.cpp +++ b/ACE/tests/Bug_2540_Regression_Test.cpp @@ -178,7 +178,6 @@ ACE_HANDLE Handler::get_handle() const int Handler::handle_input(ACE_HANDLE /* h */) { - ++handle_input_count_; // ACE_DEBUG((LM_DEBUG, "Handler::handle_input called for %d\n", h)); diff --git a/ACE/tests/Bug_2653_Regression_Test.cpp b/ACE/tests/Bug_2653_Regression_Test.cpp index bd33cc00d3e..e6e971506b5 100644 --- a/ACE/tests/Bug_2653_Regression_Test.cpp +++ b/ACE/tests/Bug_2653_Regression_Test.cpp @@ -24,7 +24,6 @@ #include "ace/OS_NS_unistd.h" - static const char *message = "Hello there! Hope you get this message"; diff --git a/ACE/tests/Bug_2659_Regression_Test.cpp b/ACE/tests/Bug_2659_Regression_Test.cpp index f393e7626dd..f5ae94fa881 100644 --- a/ACE/tests/Bug_2659_Regression_Test.cpp +++ b/ACE/tests/Bug_2659_Regression_Test.cpp @@ -67,7 +67,6 @@ private: #endif // if defined RUN_DEBUG - static void handle_signal (int ) { @@ -79,7 +78,6 @@ handle_signal (int ) class ReactorTask : public ACE_Task_Base { public: - ~ReactorTask () override { EE_DEBUG ("ReactorTask", "~ReactorTask", this); diff --git a/ACE/tests/Bug_2980_Regression_Dll.cpp b/ACE/tests/Bug_2980_Regression_Dll.cpp index ecab20be41b..2e65a687374 100644 --- a/ACE/tests/Bug_2980_Regression_Dll.cpp +++ b/ACE/tests/Bug_2980_Regression_Dll.cpp @@ -4,7 +4,6 @@ extern "C" { - ACE_Proper_Export_Flag int capi_init(void) { int ret = ACE::init(); diff --git a/ACE/tests/Bug_3334_Regression_Test.cpp b/ACE/tests/Bug_3334_Regression_Test.cpp index 9f129fb08de..4631ead5bb7 100644 --- a/ACE/tests/Bug_3334_Regression_Test.cpp +++ b/ACE/tests/Bug_3334_Regression_Test.cpp @@ -18,7 +18,6 @@ #include "ace/Service_Config.h" - int run_main (int, ACE_TCHAR *argv[]) { diff --git a/ACE/tests/Bug_3432_Regression_Test.cpp b/ACE/tests/Bug_3432_Regression_Test.cpp index c56d92c5ae7..e0ff5a8c9cb 100644 --- a/ACE/tests/Bug_3432_Regression_Test.cpp +++ b/ACE/tests/Bug_3432_Regression_Test.cpp @@ -19,7 +19,6 @@ #include "ace/OS_NS_time.h" - int strptime_test () { diff --git a/ACE/tests/Bug_3505_Regression_Test.cpp b/ACE/tests/Bug_3505_Regression_Test.cpp index 1f3fc5d39e9..0609ec07ed7 100644 --- a/ACE/tests/Bug_3505_Regression_Test.cpp +++ b/ACE/tests/Bug_3505_Regression_Test.cpp @@ -15,7 +15,6 @@ #include "test_config.h" - int run_main (int, ACE_TCHAR *[]) { diff --git a/ACE/tests/Bug_3710_Regression_Test.cpp b/ACE/tests/Bug_3710_Regression_Test.cpp index 82451b7d526..d61b05770cd 100644 --- a/ACE/tests/Bug_3710_Regression_Test.cpp +++ b/ACE/tests/Bug_3710_Regression_Test.cpp @@ -12,7 +12,6 @@ #include "ace/OS_Memory.h" - // Main function. int diff --git a/ACE/tests/Bug_3911_Regression_Test.cpp b/ACE/tests/Bug_3911_Regression_Test.cpp index 39657681b56..7eb5463d201 100644 --- a/ACE/tests/Bug_3911_Regression_Test.cpp +++ b/ACE/tests/Bug_3911_Regression_Test.cpp @@ -135,7 +135,6 @@ public: return shared; }; - }; ShmemMan* ShmemMan::c_instance = 0; diff --git a/ACE/tests/Bug_3912_Regression_Test.cpp b/ACE/tests/Bug_3912_Regression_Test.cpp index c1c9fe0a321..ea997da539e 100644 --- a/ACE/tests/Bug_3912_Regression_Test.cpp +++ b/ACE/tests/Bug_3912_Regression_Test.cpp @@ -31,7 +31,6 @@ using MT_Module = ACE_Module<ACE_MT_SYNCH>; class Close_Handler : public virtual MT_Task { public: - Close_Handler(bool* close_called_arg) : close_called_ (close_called_arg) { diff --git a/ACE/tests/Bug_3943_Regression_Test.cpp b/ACE/tests/Bug_3943_Regression_Test.cpp index 8fdf4a0f98b..2763741b581 100644 --- a/ACE/tests/Bug_3943_Regression_Test.cpp +++ b/ACE/tests/Bug_3943_Regression_Test.cpp @@ -67,7 +67,6 @@ #define REFCOUNTED_HASH_RECYCLABLE_ADDR ACE_Refcounted_Hash_Recyclable<ACE_INET_Addr> namespace { - const char FINISHED_CHAR = '%'; const char RESTART_CHAR = '&'; const char START_CHAR = '0'; @@ -244,7 +243,6 @@ namespace { ssize_t send (char send_char, const ACE_TCHAR * const send_desc); const ACE_Time_Value DEFAULT_TIME_VALUE; - }; } // namespace "" @@ -974,7 +972,6 @@ client (void *arg) { // Send the data to the server. svc_handler->send_data (); - } return 0; } diff --git a/ACE/tests/CDR_Array_Test.cpp b/ACE/tests/CDR_Array_Test.cpp index a051dcfa379..9b68d8a0991 100644 --- a/ACE/tests/CDR_Array_Test.cpp +++ b/ACE/tests/CDR_Array_Test.cpp @@ -48,7 +48,6 @@ #endif - // Default number of elements for check buffer, for each tested CDR type. // Be aware that time will be affected by the buffer fitting/not fitting // in the cache (ie, if default_total*sizeof(T) bytes fit in the cache). @@ -233,7 +232,6 @@ CDR_Test<T, H>::CDR_Test (int total, int niter, int use_array) CDR_Test<T, H>::do_test(tdelta, niter, 1, srcbuf, dstbuf, sk, dk); - } } } diff --git a/ACE/tests/CDR_File_Test.cpp b/ACE/tests/CDR_File_Test.cpp index 62be7259803..aee71f3aa1f 100644 --- a/ACE/tests/CDR_File_Test.cpp +++ b/ACE/tests/CDR_File_Test.cpp @@ -33,7 +33,6 @@ */ class CDR_Test { - /// Output the state of a <CDR_Test> object to the <ostream>. friend ostream& operator << (ostream &os, const CDR_Test &t); diff --git a/ACE/tests/CDR_Test.cpp b/ACE/tests/CDR_Test.cpp index fa140dc5c65..c9fcf68dcf2 100644 --- a/ACE/tests/CDR_Test.cpp +++ b/ACE/tests/CDR_Test.cpp @@ -22,7 +22,6 @@ #include "ace/OS_NS_wchar.h" - static int n = 4096; static int nloops = 100; diff --git a/ACE/tests/Cached_Accept_Conn_Test.h b/ACE/tests/Cached_Accept_Conn_Test.h index 28f8d089211..9581f92c7bd 100644 --- a/ACE/tests/Cached_Accept_Conn_Test.h +++ b/ACE/tests/Cached_Accept_Conn_Test.h @@ -28,7 +28,6 @@ class Client_Svc_Handler : public ACE_Svc_Handler<ACE_SOCK_STREAM, ACE_NULL_SYNCH> { public: - Client_Svc_Handler (ACE_Thread_Manager *t = 0); int open (void *v = 0); int close (u_long flags = 0); @@ -37,7 +36,6 @@ public: class Server_Svc_Handler : public ACE_Svc_Handler<ACE_SOCK_STREAM, ACE_NULL_SYNCH> { public: - Server_Svc_Handler (ACE_Thread_Manager *t = 0); int open (void *v = 0); }; @@ -101,7 +99,6 @@ template <class SVC_HANDLER, ACE_PEER_ACCEPTOR_1> class Accept_Strategy : public ACE_Accept_Strategy<SVC_HANDLER, ACE_PEER_ACCEPTOR_2> { public: - /// Constructor. Accept_Strategy (CACHED_CONNECT_STRATEGY &caching_connect_strategy); @@ -122,7 +119,6 @@ public: int accept_svc_handler (SVC_HANDLER *svc_handler); protected: - typedef ACE_Accept_Strategy<SVC_HANDLER, ACE_PEER_ACCEPTOR_2> ACCEPT_STRATEGY_BASE; /// Handler for removing cached connections. diff --git a/ACE/tests/Cached_Allocator_Test.cpp b/ACE/tests/Cached_Allocator_Test.cpp index d954c2980cd..0012f88c57f 100644 --- a/ACE/tests/Cached_Allocator_Test.cpp +++ b/ACE/tests/Cached_Allocator_Test.cpp @@ -16,7 +16,6 @@ #include "ace/High_Res_Timer.h" - #include "ace/Synch_Traits.h" #include "ace/Null_Mutex.h" @@ -76,7 +75,6 @@ using STATIC_ALLOCATOR = ACE_Cached_Allocator<MEMBLOCK, ACE_MT_SYNCH::NULL_MUTEX static int stdspeed_test (ACE_UINT32 loops) { - double tt = 0.0, ut = 0.0, utus = 0.0, diff --git a/ACE/tests/Cached_Conn_Test.cpp b/ACE/tests/Cached_Conn_Test.cpp index 9f6bb780237..1b98d391959 100644 --- a/ACE/tests/Cached_Conn_Test.cpp +++ b/ACE/tests/Cached_Conn_Test.cpp @@ -39,7 +39,6 @@ #endif /* _MSC_VER */ - using ATTRIBUTES = size_t; using CACHED_HANDLER = std::pair<Svc_Handler *, ATTRIBUTES>; using ACE_ADDR = ARHR<ACE_INET_Addr>; diff --git a/ACE/tests/Cached_Conn_Test.h b/ACE/tests/Cached_Conn_Test.h index 09a9da0169c..c9e9d6e6fe5 100644 --- a/ACE/tests/Cached_Conn_Test.h +++ b/ACE/tests/Cached_Conn_Test.h @@ -20,7 +20,6 @@ class Svc_Handler : public ACE_Svc_Handler<ACE_SOCK_STREAM, ACE_NULL_SYNCH> { public: - Svc_Handler (ACE_Thread_Manager *t = 0); int open (void *v = 0); int close (u_long flags = 0); diff --git a/ACE/tests/Chrono_Test.cpp b/ACE/tests/Chrono_Test.cpp index 1c9e86c6857..7a09b1d9a99 100644 --- a/ACE/tests/Chrono_Test.cpp +++ b/ACE/tests/Chrono_Test.cpp @@ -289,7 +289,6 @@ test_streamers () } - ACE_Time_Value const test_sec {12, 132}; // Seconds s << test_sec; diff --git a/ACE/tests/Codecs_Test.cpp b/ACE/tests/Codecs_Test.cpp index c851b26c08e..24b65cb9c9f 100644 --- a/ACE/tests/Codecs_Test.cpp +++ b/ACE/tests/Codecs_Test.cpp @@ -16,7 +16,6 @@ #include "ace/ACE.h" - // Don't change the strings thinking that they are typos const ACE_Byte normal_stream[] = "This is a sample test stream, to test simple Base64 encoding"; diff --git a/ACE/tests/Compiler_Features_01_Test.cpp b/ACE/tests/Compiler_Features_01_Test.cpp index ecf26f1b251..75d5b7e5421 100644 --- a/ACE/tests/Compiler_Features_01_Test.cpp +++ b/ACE/tests/Compiler_Features_01_Test.cpp @@ -16,7 +16,6 @@ #include <list> - int run_main (int, ACE_TCHAR *[]) { diff --git a/ACE/tests/Compiler_Features_10_Test.cpp b/ACE/tests/Compiler_Features_10_Test.cpp index 5c5ed2a6b60..4621bc62f5e 100644 --- a/ACE/tests/Compiler_Features_10_Test.cpp +++ b/ACE/tests/Compiler_Features_10_Test.cpp @@ -125,7 +125,6 @@ namespace } - int run_main (int, ACE_TCHAR *[]) { @@ -201,7 +200,6 @@ run_main (int, ACE_TCHAR *[]) namespace { - void check_constructor_count(int expected, char const * filename, diff --git a/ACE/tests/Compiler_Features_22_DLL.h b/ACE/tests/Compiler_Features_22_DLL.h index a7dd73aff6b..a45101a2107 100644 --- a/ACE/tests/Compiler_Features_22_DLL.h +++ b/ACE/tests/Compiler_Features_22_DLL.h @@ -19,7 +19,6 @@ class A { public: - A () {}; }; diff --git a/ACE/tests/Config_Test.cpp b/ACE/tests/Config_Test.cpp index 31eda47e3e1..e16932db307 100644 --- a/ACE/tests/Config_Test.cpp +++ b/ACE/tests/Config_Test.cpp @@ -780,7 +780,6 @@ Config_Test::testEquality () ACE_ERROR_RETURN ((LM_ERROR, ACE_TEXT ("Cannot open heap1\n")), -1); - } else if ((heap2.open ()) != 0) { @@ -1077,7 +1076,6 @@ iniCompare (ACE_Configuration_Heap& fromFile, ACE_Configuration_Heap& original) else // if the type is invalid, then go ahead and fail it. rc = false; - }// end if the original type was not a string. else { @@ -1097,11 +1095,9 @@ iniCompare (ACE_Configuration_Heap& fromFile, ACE_Configuration_Heap& original) // before we move on remove this value from the original. original.remove_value (originalSection, valueName.c_str ()); - }// end else if values match. valueIndex++; - }// end value while loop // at this point the original should have no values. look @@ -1116,7 +1112,6 @@ iniCompare (ACE_Configuration_Heap& fromFile, ACE_Configuration_Heap& original) // having a value indicates a mismatch rc = valueIndex == 0; - }// end else if sections match. if (rc) @@ -1126,7 +1121,6 @@ iniCompare (ACE_Configuration_Heap& fromFile, ACE_Configuration_Heap& original) 0); // do not remove subsections. ++sectionIndex; - }// end section while loop // Finally, if the original has any sections, then we're not equal diff --git a/ACE/tests/Conn_Test.cpp b/ACE/tests/Conn_Test.cpp index 4986926a2a0..c44c607df25 100644 --- a/ACE/tests/Conn_Test.cpp +++ b/ACE/tests/Conn_Test.cpp @@ -36,7 +36,6 @@ #include "ace/os_include/os_netdb.h" - static const char ACE_ALPHABET[] = "abcdefghijklmnopqrstuvwxyz"; // This test doesn't work well using fork() on MacOS X. So we diff --git a/ACE/tests/Dev_Poll_Reactor_Echo_Test.cpp b/ACE/tests/Dev_Poll_Reactor_Echo_Test.cpp index f33a16646cd..b634d93a081 100644 --- a/ACE/tests/Dev_Poll_Reactor_Echo_Test.cpp +++ b/ACE/tests/Dev_Poll_Reactor_Echo_Test.cpp @@ -37,7 +37,6 @@ using SVC_HANDLER = ACE_Svc_Handler<ACE_SOCK_Stream, ACE_NULL_SYNCH>; class Client : public SVC_HANDLER { public: - Client (); //FUZZ: disable check_for_lack_ACE_OS @@ -65,7 +64,6 @@ private: class Server : public SVC_HANDLER { public: - Server (); int handle_input (ACE_HANDLE handle) override; @@ -369,7 +367,6 @@ using CONNECTOR = ACE_Connector<Client, ACE_SOCK_Connector>; class TestAcceptor : public ACCEPTOR { public: - int accept_svc_handler (Server * handler) override { int result = this->ACCEPTOR::accept_svc_handler (handler); @@ -391,7 +388,6 @@ public: return result; } - }; // ---------------------------------------------------- @@ -399,7 +395,6 @@ public: class TestConnector : public CONNECTOR { public: - int connect_svc_handler ( CONNECTOR::handler_type *& handler, const CONNECTOR::addr_type &remote_addr, diff --git a/ACE/tests/Dev_Poll_Reactor_Test.cpp b/ACE/tests/Dev_Poll_Reactor_Test.cpp index 14cfa9e27e8..8dffa050bf3 100644 --- a/ACE/tests/Dev_Poll_Reactor_Test.cpp +++ b/ACE/tests/Dev_Poll_Reactor_Test.cpp @@ -43,7 +43,6 @@ using SVC_HANDLER = ACE_Svc_Handler<ACE_SOCK_Stream, ACE_NULL_SYNCH>; class Client : public SVC_HANDLER { public: - Client (); //FUZZ: disable check_for_lack_ACE_OS @@ -59,16 +58,13 @@ public: ACE_Reactor_Mask mask) override; private: - unsigned int call_count_; - }; class Server : public SVC_HANDLER { public: - Server (); int handle_input (ACE_HANDLE handle) override; @@ -80,9 +76,7 @@ public: ACE_Reactor_Mask mask) override; private: - unsigned int call_count_; - }; // ---------------------------------------------------- @@ -230,7 +224,6 @@ Server::handle_input (ACE_HANDLE /* handle */) { if (errno == EWOULDBLOCK) { - // ACE_HEX_DUMP ((LM_DEBUG, // buf, // 80, @@ -318,7 +311,6 @@ using CONNECTOR = ACE_Connector<Client, ACE_SOCK_Connector>; class TestAcceptor : public ACCEPTOR { public: - int accept_svc_handler (Server * handler) override { int result = this->ACCEPTOR::accept_svc_handler (handler); @@ -360,7 +352,6 @@ public: return result; } - }; // ---------------------------------------------------- @@ -368,7 +359,6 @@ public: class TestConnector : public CONNECTOR { public: - int connect_svc_handler ( CONNECTOR::handler_type *& handler, const CONNECTOR::addr_type &remote_addr, diff --git a/ACE/tests/Dirent_Test.cpp b/ACE/tests/Dirent_Test.cpp index 118675e3730..f38fd33beae 100644 --- a/ACE/tests/Dirent_Test.cpp +++ b/ACE/tests/Dirent_Test.cpp @@ -39,7 +39,6 @@ static const int RECURSION_INDENT = 3; static int entrycount = 0; extern "C" { - static int selector (const ACE_DIRENT *d) { diff --git a/ACE/tests/Dynamic_Priority_Test.cpp b/ACE/tests/Dynamic_Priority_Test.cpp index 136e29f0e44..de5939b43ed 100644 --- a/ACE/tests/Dynamic_Priority_Test.cpp +++ b/ACE/tests/Dynamic_Priority_Test.cpp @@ -52,7 +52,6 @@ #endif /* VXWORKS */ - #if defined (ACE_HAS_TIMED_MESSAGE_BLOCKS) enum Test_Type {BEST, WORST, RANDOM}; @@ -64,7 +63,6 @@ enum Test_Type {BEST, WORST, RANDOM}; class ArgStruct { public: - /// message queue to test ACE_Message_Queue<ACE_SYNCH> *queue_; @@ -683,7 +681,6 @@ run_performance_test (u_int min_load, // Free the allocated pointer array. delete [] supplier_args.array_; - } // Free resources and leave. diff --git a/ACE/tests/Dynamic_Test.cpp b/ACE/tests/Dynamic_Test.cpp index 958ac6fa10e..77c000b2c46 100644 --- a/ACE/tests/Dynamic_Test.cpp +++ b/ACE/tests/Dynamic_Test.cpp @@ -16,7 +16,6 @@ #include "ace/OS_Memory.h" - class A { public: diff --git a/ACE/tests/FlReactor_Test.cpp b/ACE/tests/FlReactor_Test.cpp index 834345bb963..9a442d42a10 100644 --- a/ACE/tests/FlReactor_Test.cpp +++ b/ACE/tests/FlReactor_Test.cpp @@ -20,7 +20,6 @@ - #include "ace/FlReactor/FlReactor.h" #include "ace/Event_Handler.h" #include "ace/Acceptor.h" diff --git a/ACE/tests/Get_Opt_Test.cpp b/ACE/tests/Get_Opt_Test.cpp index 7ba700aa89c..6395c0a1f2e 100644 --- a/ACE/tests/Get_Opt_Test.cpp +++ b/ACE/tests/Get_Opt_Test.cpp @@ -20,7 +20,6 @@ #include "test_config.h" - /* * This is the heart of the test. It sets up the optstring, instantiates * ACE_Get_Opt, add long options, processes them in a loop, and prints out diff --git a/ACE/tests/Hash_Map_Manager_Test.cpp b/ACE/tests/Hash_Map_Manager_Test.cpp index 034c73e80ba..f03a5b3f7d5 100644 --- a/ACE/tests/Hash_Map_Manager_Test.cpp +++ b/ACE/tests/Hash_Map_Manager_Test.cpp @@ -20,7 +20,6 @@ #include "ace/Null_Mutex.h" - static const size_t STRING_TABLE_ENTRIES = 3 * 2; static const size_t MAX_HASH = 6; diff --git a/ACE/tests/Hash_Multi_Map_Manager_Test.cpp b/ACE/tests/Hash_Multi_Map_Manager_Test.cpp index 144befd426b..3c687bc65b0 100644 --- a/ACE/tests/Hash_Multi_Map_Manager_Test.cpp +++ b/ACE/tests/Hash_Multi_Map_Manager_Test.cpp @@ -16,7 +16,6 @@ #include "ace/Null_Mutex.h" - using HASH_STRING_MAP = ACE_Hash_Multi_Map_Manager<const ACE_TCHAR *, const ACE_TCHAR *, ACE_Hash<const ACE_TCHAR *>, ACE_Equal_To<const ACE_TCHAR *>, ACE_Null_Mutex>; using HASH_STRING_ENTRY = HASH_STRING_MAP::ENTRY; diff --git a/ACE/tests/Lazy_Map_Manager_Test.cpp b/ACE/tests/Lazy_Map_Manager_Test.cpp index 22bae652ccc..eb155786a1e 100644 --- a/ACE/tests/Lazy_Map_Manager_Test.cpp +++ b/ACE/tests/Lazy_Map_Manager_Test.cpp @@ -17,7 +17,6 @@ #include "ace/Active_Map_Manager.h" - // Simple map manager. using LAZY_MAP = ACE_Map_Manager<int, int, ACE_Null_Mutex>; diff --git a/ACE/tests/Log_Thread_Inheritance_Test.cpp b/ACE/tests/Log_Thread_Inheritance_Test.cpp index 7f35886b04c..e27fa012b65 100644 --- a/ACE/tests/Log_Thread_Inheritance_Test.cpp +++ b/ACE/tests/Log_Thread_Inheritance_Test.cpp @@ -60,7 +60,6 @@ bool test_inherited_attributes () struct MyThread : ACE_Task_Base { - enum { THREAD_DEFAULTS = THR_NEW_LWP|THR_JOINABLE|THR_INHERIT_SCHED }; explicit MyThread (bool openfile = false) diff --git a/ACE/tests/MT_Reactor_Timer_Test.cpp b/ACE/tests/MT_Reactor_Timer_Test.cpp index 85cedf6f5c4..6b952c9d5d0 100644 --- a/ACE/tests/MT_Reactor_Timer_Test.cpp +++ b/ACE/tests/MT_Reactor_Timer_Test.cpp @@ -19,7 +19,6 @@ #include "ace/OS_NS_unistd.h" - #if defined (ACE_HAS_THREADS) // This test exercises the setting and cancelling of timers from a @@ -147,7 +146,6 @@ Time_Handler::handle_timeout (const ACE_Time_Value &tv, Dispatch_Count_Handler::Dispatch_Count_Handler () { - ACE_Reactor *r = ACE_Reactor::instance (); this->input_seen_ = this->notify_seen_ = 0; diff --git a/ACE/tests/MT_Reactor_Timer_Test.h b/ACE/tests/MT_Reactor_Timer_Test.h index 966a48e1500..fe8ffeebce4 100644 --- a/ACE/tests/MT_Reactor_Timer_Test.h +++ b/ACE/tests/MT_Reactor_Timer_Test.h @@ -66,7 +66,6 @@ private: #if defined ACE_HAS_THREADS ACE_Thread_Mutex lock_; #endif /* ACE_HAS_THREADS */ - }; /** @@ -104,7 +103,6 @@ private: int input_seen_; int notify_seen_; size_t timers_fired_; - }; #endif /* ACE_TESTS_MT_REACTOR_TIMER_TEST_H */ diff --git a/ACE/tests/MT_Reactor_Upcall_Test.cpp b/ACE/tests/MT_Reactor_Upcall_Test.cpp index 207233b05aa..7b850bb1d2a 100644 --- a/ACE/tests/MT_Reactor_Upcall_Test.cpp +++ b/ACE/tests/MT_Reactor_Upcall_Test.cpp @@ -25,7 +25,6 @@ #include "ace/ACE.h" - int number_of_event_loop_threads = 3; int number_of_messages = 10; int sleep_time_in_msec = 100; diff --git a/ACE/tests/MT_Reference_Counted_Event_Handler_Test.cpp b/ACE/tests/MT_Reference_Counted_Event_Handler_Test.cpp index f9d2d2156c6..42b22901170 100644 --- a/ACE/tests/MT_Reference_Counted_Event_Handler_Test.cpp +++ b/ACE/tests/MT_Reference_Counted_Event_Handler_Test.cpp @@ -138,7 +138,6 @@ disable_signal (int sigmin, int sigmax) class Pipe { public: - Pipe (); //FUZZ: disable check_for_lack_ACE_OS @@ -226,7 +225,6 @@ static Event_Loop_Thread *global_event_loop_thread_variable = 0; class Sender : public ACE_Event_Handler { public: - Sender (ACE_HANDLE handle, Connection_Cache &connection_cache); @@ -243,13 +241,11 @@ public: ACE_HANDLE handle_; Connection_Cache &connection_cache_; - }; class Connection_Cache { public: - Connection_Cache (); ~Connection_Cache (); @@ -361,20 +357,17 @@ Sender::send_message () class Event_Loop_Thread : public ACE_Task_Base { public: - Event_Loop_Thread (ACE_Thread_Manager &thread_manager, ACE_Reactor &reactor); int svc () override; ACE_Reactor &reactor_; - }; class Receiver : public ACE_Task_Base { public: - Receiver (ACE_Thread_Manager &thread_manager, ACE_HANDLE handle, int nested_upcalls); @@ -398,7 +391,6 @@ public: int nested_upcalls_; int nested_upcalls_level_; - }; Receiver::Receiver (ACE_Thread_Manager &thread_manager, @@ -541,7 +533,6 @@ Receiver::close (u_long) class Connector { public: - Connector (ACE_Thread_Manager &thread_manager, ACE_Reactor &reactor, int nested_upcalls); @@ -557,7 +548,6 @@ public: ACE_Reactor &reactor_; int nested_upcalls_; - }; Connector::Connector (ACE_Thread_Manager &thread_manager, @@ -760,7 +750,6 @@ Connection_Cache::~Connection_Cache () class Invocation_Thread : public ACE_Task_Base { public: - Invocation_Thread (ACE_Thread_Manager &thread_manager, ACE_Reactor &reactor, Connection_Cache &connection_cache, @@ -786,7 +775,6 @@ public: int run_receiver_thread_; int nested_upcalls_; - }; Invocation_Thread::Invocation_Thread (ACE_Thread_Manager &thread_manager, @@ -970,7 +958,6 @@ Invocation_Thread::svc () class Close_Socket_Thread : public ACE_Task_Base { public: - Close_Socket_Thread (ACE_Thread_Manager &thread_manager, ACE_Reactor &reactor, ACE_Auto_Event &new_connection_event, @@ -986,7 +973,6 @@ public: int make_invocations_; int run_receiver_thread_; - }; Close_Socket_Thread::Close_Socket_Thread (ACE_Thread_Manager &thread_manager, @@ -1105,7 +1091,6 @@ Event_Loop_Thread::svc () class Purger_Thread : public ACE_Task_Base { public: - Purger_Thread (ACE_Thread_Manager &thread_manager, ACE_Reactor &reactor, Connection_Cache &connection_cache); @@ -1115,7 +1100,6 @@ public: ACE_Reactor &reactor_; Connection_Cache &connection_cache_; - }; Purger_Thread::Purger_Thread (ACE_Thread_Manager &thread_manager, @@ -1280,7 +1264,6 @@ test<REACTOR_IMPL>::test (int ignore_nested_upcalls, (nested_upcalls == -1 || nested_upcalls == test_configs[i][4])) { - #if 0 /* defined (ACE_LINUX) */ // @@ I am not sure why but when <make_invocations> is 0 and diff --git a/ACE/tests/MT_Reference_Counted_Notify_Test.cpp b/ACE/tests/MT_Reference_Counted_Notify_Test.cpp index a1ba7346316..ab03322f092 100644 --- a/ACE/tests/MT_Reference_Counted_Notify_Test.cpp +++ b/ACE/tests/MT_Reference_Counted_Notify_Test.cpp @@ -37,7 +37,6 @@ static int debug = 1; class Reference_Counted_Event_Handler : public ACE_Event_Handler { public: - Reference_Counted_Event_Handler (); ~Reference_Counted_Event_Handler () override; @@ -47,7 +46,6 @@ public: ACE_Event_Handler::Reference_Count add_reference () override; ACE_Event_Handler::Reference_Count remove_reference () override; - }; Reference_Counted_Event_Handler::Reference_Counted_Event_Handler () @@ -131,7 +129,6 @@ Reference_Counted_Event_Handler::remove_reference () class Simple_Event_Handler : public ACE_Event_Handler { public: - Simple_Event_Handler (int notifies); ~Simple_Event_Handler () override; @@ -172,7 +169,6 @@ Simple_Event_Handler::handle_input (ACE_HANDLE) class Event_Loop_Thread : public ACE_Task_Base { public: - Event_Loop_Thread (ACE_Thread_Manager &thread_manager, ACE_Reactor &reactor, int extra_iterations_needed); diff --git a/ACE/tests/Malloc_Test.cpp b/ACE/tests/Malloc_Test.cpp index 037e5744ddb..d2bc5852106 100644 --- a/ACE/tests/Malloc_Test.cpp +++ b/ACE/tests/Malloc_Test.cpp @@ -91,7 +91,6 @@ myallocator (const void *base_addr = 0) if (static_allocator.get () == 0) { - #if defined (ACE_HAS_WINCE) || defined (ACE_OPENVMS) // WinCE cannot do fixed base, ever. ACE_UNUSED_ARG (base_addr); diff --git a/ACE/tests/Map_Test.cpp b/ACE/tests/Map_Test.cpp index 91c55896b43..706ca1bb788 100644 --- a/ACE/tests/Map_Test.cpp +++ b/ACE/tests/Map_Test.cpp @@ -17,7 +17,6 @@ #include "ace/Profile_Timer.h" - #undef THIS_IS_NOT_AN_ASSERT_IT_IS_A_NON_DEBUG_TEST_AS_WELL #define THIS_IS_NOT_AN_ASSERT_IT_IS_A_NON_DEBUG_TEST_AS_WELL(X) \ ((X) \ diff --git a/ACE/tests/Map_Test.h b/ACE/tests/Map_Test.h index c896c52e71a..b330b8f8f47 100644 --- a/ACE/tests/Map_Test.h +++ b/ACE/tests/Map_Test.h @@ -38,7 +38,6 @@ typedef ACE_Array<char> KEY; class Key_Generator { public: - Key_Generator (void) : counter_ (0) { @@ -90,7 +89,6 @@ public: class Key_Adapter { public: - int encode (const KEY &original_key, const ACE_Active_Map_Manager_Key &active_key, KEY &modified_key) diff --git a/ACE/tests/Max_Default_Port_Test.cpp b/ACE/tests/Max_Default_Port_Test.cpp index 2e555005b3a..90641fcb154 100644 --- a/ACE/tests/Max_Default_Port_Test.cpp +++ b/ACE/tests/Max_Default_Port_Test.cpp @@ -51,7 +51,6 @@ My_Accept_Handler::~My_Accept_Handler () int My_Accept_Handler::open (ACE_INET_Addr &addr) { - if (this->peer_acceptor_.open (addr, 1) == -1) { ACE_ERROR ((LM_ERROR, ACE_TEXT ("%p\n"), @@ -60,7 +59,6 @@ My_Accept_Handler::open (ACE_INET_Addr &addr) } return 0; - } ACE_HANDLE @@ -72,7 +70,6 @@ My_Accept_Handler::get_handle () const int My_Accept_Handler::handle_input (ACE_HANDLE) { - if (this->peer_acceptor_.accept(this->stream_, 0) == -1) { ACE_ERROR((LM_ERROR, ACE_TEXT ("%p\n"), ACE_TEXT ("peer_acceptor.accept"))); @@ -164,7 +161,6 @@ client (void *arg) int run_main (int argc, ACE_TCHAR *argv[]) { - ACE_START_TEST (ACE_TEXT ("Max_Default_Port_Test")); ACE_UNUSED_ARG (argc); @@ -287,7 +283,6 @@ run_main (int argc, ACE_TCHAR *argv[]) ACE_TEXT ("Invalid ACE_MAX_DEFAULT_PORT ") ACE_TEXT ("or %d port may be busy; got to %d\n"), ACE_MAX_DEFAULT_PORT, max_listened_port)); - } #endif // ACE_LACKS_ACCEPT diff --git a/ACE/tests/Max_Default_Port_Test.h b/ACE/tests/Max_Default_Port_Test.h index 70d68dea586..10439aaeedc 100644 --- a/ACE/tests/Max_Default_Port_Test.h +++ b/ACE/tests/Max_Default_Port_Test.h @@ -9,7 +9,6 @@ //============================================================================= - #ifndef ACE_TESTS_MAX_DEFAULT_PORT_TEST #define ACE_TESTS_MAX_DEFAULT_PORT_TEST @@ -25,7 +24,6 @@ */ class My_Accept_Handler : public ACE_Event_Handler { - public: My_Accept_Handler (ACE_INET_Addr &addr); ~My_Accept_Handler (); diff --git a/ACE/tests/Max_Default_Port_Test_IPV6.cpp b/ACE/tests/Max_Default_Port_Test_IPV6.cpp index 22ae15ea6ee..fe0df33bcf7 100644 --- a/ACE/tests/Max_Default_Port_Test_IPV6.cpp +++ b/ACE/tests/Max_Default_Port_Test_IPV6.cpp @@ -43,7 +43,6 @@ My_Accept_Handler::~My_Accept_Handler () int My_Accept_Handler::open (ACE_INET_Addr &addr) { - if (this->peer_acceptor_.open (addr, 1) == -1) { ACE_ERROR ((LM_ERROR, ACE_TEXT ("%p\n"), @@ -52,7 +51,6 @@ My_Accept_Handler::open (ACE_INET_Addr &addr) } return 0; - } ACE_HANDLE @@ -64,7 +62,6 @@ My_Accept_Handler::get_handle () const int My_Accept_Handler::handle_input (ACE_HANDLE) { - if (this->peer_acceptor_.accept(this->stream_, 0) == -1) { ACE_ERROR((LM_ERROR, ACE_TEXT ("%p\n"), ACE_TEXT ("peer_acceptor.accept"))); @@ -242,7 +239,6 @@ run_main (int argc, ACE_TCHAR *argv[]) ACE_TEXT ("Invalid ACE_MAX_DEFAULT_PORT ") ACE_TEXT ("or %d port may be busy; got to %d\n"), ACE_MAX_DEFAULT_PORT, max_listened_port)); - } #endif /* ACE_HAS_IPV6 */ diff --git a/ACE/tests/Mem_Map_Test.cpp b/ACE/tests/Mem_Map_Test.cpp index 73bb98590cf..7549be0c73a 100644 --- a/ACE/tests/Mem_Map_Test.cpp +++ b/ACE/tests/Mem_Map_Test.cpp @@ -22,7 +22,6 @@ #include "ace/OS_Memory.h" - #if !defined (ACE_LACKS_MMAP) static const char ACE_ALPHABET[] = "abcdefghijklmnopqrstuvwxyz"; diff --git a/ACE/tests/Message_Block_Large_Copy_Test.cpp b/ACE/tests/Message_Block_Large_Copy_Test.cpp index 44fb9bf15f6..3107b3ea079 100644 --- a/ACE/tests/Message_Block_Large_Copy_Test.cpp +++ b/ACE/tests/Message_Block_Large_Copy_Test.cpp @@ -99,12 +99,10 @@ run_clone_test (const size_t msg_block_count, int run_main (int , ACE_TCHAR *[]) { - int rc = 0; ACE_START_TEST (ACE_TEXT ("Message_Block_Large_Copy_Test")); { - // Message_Block size() and Length() of 24,000,000 const size_t MSG_BLOCK_COUNT = 8000; const size_t MSG_BLOCK_SIZE = 3000; diff --git a/ACE/tests/Message_Queue_Notifications_Test.cpp b/ACE/tests/Message_Queue_Notifications_Test.cpp index 91cb7138a5d..7ea1d2971eb 100644 --- a/ACE/tests/Message_Queue_Notifications_Test.cpp +++ b/ACE/tests/Message_Queue_Notifications_Test.cpp @@ -41,7 +41,6 @@ #include "ace/OS_NS_unistd.h" - static int iterations = 10; static const size_t worker_threads = 2; @@ -219,7 +218,6 @@ Watermark_Test::producer () i--; if (this->msg_queue ()->is_full ()) break; - } ACE_DEBUG ((LM_DEBUG, ACE_TEXT ("(%P|%t) Producer: High water mark hit ----\n"))); diff --git a/ACE/tests/Message_Queue_Test.cpp b/ACE/tests/Message_Queue_Test.cpp index 0e3768ab837..ce5163e5be4 100644 --- a/ACE/tests/Message_Queue_Test.cpp +++ b/ACE/tests/Message_Queue_Test.cpp @@ -38,7 +38,6 @@ #include "ace/OS_NS_unistd.h" - const ACE_TCHAR usage[] = ACE_TEXT ("usage: Message_Queue_Test <number of messages>\n"); using QUEUE = ACE_Message_Queue<ACE_NULL_SYNCH>; @@ -409,7 +408,6 @@ iterator_test () static int chained_block_test () { - QUEUE q; const char * s = "123456789"; // Will be length 10 when copied to block const size_t slen = 10; @@ -959,7 +957,6 @@ run_main (int argc, ACE_TCHAR *argv[]) timer = 0; - ACE_END_TEST; return status; } diff --git a/ACE/tests/Message_Queue_Test_Ex.cpp b/ACE/tests/Message_Queue_Test_Ex.cpp index 3182d2c6d0b..853eebb8504 100644 --- a/ACE/tests/Message_Queue_Test_Ex.cpp +++ b/ACE/tests/Message_Queue_Test_Ex.cpp @@ -373,7 +373,6 @@ MQ_Ex_N_Tester::test_enqueue_head () timer->reset (); return 0; - } #if defined (ACE_HAS_THREADS) diff --git a/ACE/tests/Multicast_Test.cpp b/ACE/tests/Multicast_Test.cpp index f07d65e65c8..c00aaa347b0 100644 --- a/ACE/tests/Multicast_Test.cpp +++ b/ACE/tests/Multicast_Test.cpp @@ -80,7 +80,6 @@ static sig_atomic_t error = 0; class MCT_Config { public: - enum { PRODUCER = 1, @@ -759,7 +758,6 @@ MCT_Task::svc () int send_dgram (ACE_SOCK_Dgram &socket, ACE_INET_Addr addr, int done = 0) { - // Send each message twice, once to the right port, and once to the "wrong" // port. This helps generate noise and lets us see if port filtering is // working properly. diff --git a/ACE/tests/Multicast_Test_IPV6.cpp b/ACE/tests/Multicast_Test_IPV6.cpp index 0eda873a68c..65347b3bf7d 100644 --- a/ACE/tests/Multicast_Test_IPV6.cpp +++ b/ACE/tests/Multicast_Test_IPV6.cpp @@ -86,7 +86,6 @@ static sig_atomic_t error = 0; class MCT_Config { public: - enum { PRODUCER = 1, @@ -755,7 +754,6 @@ MCT_Task::svc () int send_dgram (ACE_SOCK_Dgram &socket, ACE_INET_Addr addr, int done = 0) { - // Send each message twice, once to the right port, and once to the "wrong" // port. This helps generate noise and lets us see if port filtering is // working properly. @@ -930,7 +928,6 @@ int advance_addr (ACE_INET_Addr &addr) ACE_TEXT ("multicast group address past %s\n"), addr.get_host_addr ()), -1); - } } #endif /* ACE_HAS_IPV6 */ diff --git a/ACE/tests/Multihomed_INET_Addr_Test.cpp b/ACE/tests/Multihomed_INET_Addr_Test.cpp index bf8d53308c2..922c2fc38d3 100644 --- a/ACE/tests/Multihomed_INET_Addr_Test.cpp +++ b/ACE/tests/Multihomed_INET_Addr_Test.cpp @@ -92,8 +92,6 @@ int run_main (int, ACE_TCHAR *[]) // Run the test with a varying number of secondary addresses for (i = 0; i <= num_secondaries; ++i) { - - /****** Clear the in_out array and test subject ******/ @@ -135,7 +133,6 @@ int run_main (int, ACE_TCHAR *[]) // secondary addresses. size_t returned_num_secondaries = addr.get_num_secondary_addresses(); if (returned_num_secondaries == num_secondaries) { - // Set a stay_out element to the state that we expect to see // from every in_out element after the in_out array is passed to // the accessor of the test subject. @@ -146,9 +143,7 @@ int run_main (int, ACE_TCHAR *[]) // Check that the in_out array matches stay_out element for (j = 0; j < num_secondaries; ++j) { - if (in_out[j] != stay_out[0]) { - ACE_TCHAR in_out_string[100]; ACE_TCHAR stay_out_string[100]; @@ -172,9 +167,7 @@ int run_main (int, ACE_TCHAR *[]) for (j = 0, pointer = in_out_sockaddr; j < num_secondaries + 1; ++j, ++pointer) { - if (ACE_OS::memcmp(pointer, stay_out[0].get_addr(), sizeof(sockaddr))) { - ACE_ERROR ((LM_ERROR, ACE_TEXT ("Failed get_addresses check\n"))); @@ -183,14 +176,12 @@ int run_main (int, ACE_TCHAR *[]) } } else { - ACE_ERROR ((LM_ERROR, ACE_TEXT ("Failed get_num_secondary_addresses check\n") ACE_TEXT ("%d != %d\n"), returned_num_secondaries, num_secondaries)); status = 1; - } @@ -230,7 +221,6 @@ int run_main (int, ACE_TCHAR *[]) // secondary addresses. returned_num_secondaries = addr.get_num_secondary_addresses(); if (returned_num_secondaries == i) { - // Initialize the stay_out array with the secondary addresses for (j = 0; j < i; ++j) { stay_out[j].set(port, secondary_dotted_decimals[j]); @@ -241,9 +231,7 @@ int run_main (int, ACE_TCHAR *[]) // Check that the in_out array matches stay_out array for (j = 0; j < i; ++j) { - if (in_out[j] != stay_out[j]) { - ACE_TCHAR in_out_string[100]; ACE_TCHAR stay_out_string[100]; @@ -266,13 +254,11 @@ int run_main (int, ACE_TCHAR *[]) // Check that the primary address in the in_out_sockaddr array // matches the primary address reported by the superclass if (ACE_OS::memcmp(in_out_sockaddr, addr.get_addr(), sizeof(sockaddr))) { - ACE_ERROR ((LM_ERROR, ACE_TEXT ("Failed second get_addresses check ") ACE_TEXT ("(for primary address)\n"))); status = 1; - } // Check that the secondary addresses in the in_out_sockaddr @@ -280,9 +266,7 @@ int run_main (int, ACE_TCHAR *[]) for (j = 1, pointer = &in_out_sockaddr[1]; j < i + 1; ++j, ++pointer) { - if (ACE_OS::memcmp(pointer, stay_out[j-1].get_addr(), sizeof(sockaddr))) { - ACE_ERROR ((LM_ERROR, ACE_TEXT ("Failed second get_addresses check ") ACE_TEXT ("(for secondary addresses)\n"))); @@ -292,7 +276,6 @@ int run_main (int, ACE_TCHAR *[]) } } else { - ACE_ERROR ((LM_ERROR, ACE_TEXT ("Failed second get_num_secondary_addresses check\n") ACE_TEXT ("%d != %d\n"), @@ -339,7 +322,6 @@ int run_main (int, ACE_TCHAR *[]) // secondary addresses. returned_num_secondaries = addr.get_num_secondary_addresses(); if (returned_num_secondaries == num_secondaries) { - // Set a stay_out element to the state that we expect to see // from every in_out element after the in_out array is passed to // the accessor of the test subject. @@ -350,9 +332,7 @@ int run_main (int, ACE_TCHAR *[]) // Check that the in_out array matches stay_out array for (j = 0; j < num_secondaries; ++j) { - if (in_out[j] != stay_out[0]) { - ACE_TCHAR in_out_string[100]; ACE_TCHAR stay_out_string[100]; @@ -370,14 +350,12 @@ int run_main (int, ACE_TCHAR *[]) } } else { - ACE_ERROR ((LM_ERROR, ACE_TEXT ("Failed third get_num_secondary_addresses check\n") ACE_TEXT ("%d != %d\n"), returned_num_secondaries, num_secondaries)); status = 1; - } @@ -415,7 +393,6 @@ int run_main (int, ACE_TCHAR *[]) // secondary addresses. returned_num_secondaries = addr.get_num_secondary_addresses(); if (returned_num_secondaries == i) { - // Initialize the stay_out array with the secondary addresses for (j = 0; j < i; ++j) { stay_out[j].set(port, secondary_addr32[j]); @@ -426,9 +403,7 @@ int run_main (int, ACE_TCHAR *[]) // Check that the in_out array matches stay_out array for (j = 0; j < i; ++j) { - if (in_out[j] != stay_out[j]) { - ACE_TCHAR in_out_string[100]; ACE_TCHAR stay_out_string[100]; @@ -446,7 +421,6 @@ int run_main (int, ACE_TCHAR *[]) } } else { - ACE_ERROR ((LM_ERROR, ACE_TEXT ("Failed forth get_num_secondary_addresses check\n") ACE_TEXT ("%d != %d\n"), diff --git a/ACE/tests/Multihomed_INET_Addr_Test_IPV6.cpp b/ACE/tests/Multihomed_INET_Addr_Test_IPV6.cpp index bab97e3c032..ef9fc882510 100644 --- a/ACE/tests/Multihomed_INET_Addr_Test_IPV6.cpp +++ b/ACE/tests/Multihomed_INET_Addr_Test_IPV6.cpp @@ -63,8 +63,6 @@ int run_main (int argc, ACE_TCHAR *argv[]) sockaddr_in6 in_out_sockaddr6[num_sockaddrs]; for (i = 0; i <= num_secondaries; ++i) { - - /**** Test set (u_short, const char[], int, int, const char *([]), size_t) ****/ @@ -101,7 +99,6 @@ int run_main (int argc, ACE_TCHAR *argv[]) // secondary addresses. size_t returned_num_secondaries = addr.get_num_secondary_addresses(); if (returned_num_secondaries == i) { - // Initialize the stay_out array with the secondary addresses for (j = 0; j < i; ++j) { stay_out[j].set(port, secondary_ipv6[j]); @@ -112,9 +109,7 @@ int run_main (int argc, ACE_TCHAR *argv[]) // Check that the in_out array matches stay_out array for (j = 0; j < i; ++j) { - if (in_out[j] != stay_out[j]) { - ACE_TCHAR in_out_string[100]; ACE_TCHAR stay_out_string[100]; @@ -138,13 +133,11 @@ int run_main (int argc, ACE_TCHAR *argv[]) // matches the primary address reported by the superclass if (ACE_OS::memcmp(in_out_sockaddr6, addr.get_addr(), sizeof(sockaddr_in6))) { - ACE_ERROR ((LM_ERROR, ACE_TEXT ("Failed second get_addresses check ") ACE_TEXT ("(for primary address)\n"))); status = 1; - } // Check that the secondary addresses in the in_out_sockaddr @@ -152,10 +145,8 @@ int run_main (int argc, ACE_TCHAR *argv[]) for (j = 1, pointer6 = &in_out_sockaddr6[1]; j < i + 1; ++j, ++pointer6) { - if (ACE_OS::memcmp(pointer6, stay_out[j-1].get_addr(), sizeof(sockaddr_in6))) { - ACE_ERROR ((LM_ERROR, ACE_TEXT ("Failed get_addresses check ") ACE_TEXT ("(for secondary addresses)\n"))); @@ -164,7 +155,6 @@ int run_main (int argc, ACE_TCHAR *argv[]) } } } else { - ACE_ERROR ((LM_ERROR, ACE_TEXT ("Failed get_num_secondary_addresses check\n") ACE_TEXT ("%d != %d\n"), @@ -177,5 +167,4 @@ int run_main (int argc, ACE_TCHAR *argv[]) ACE_END_TEST; return status; - } diff --git a/ACE/tests/Network_Adapters_Test.cpp b/ACE/tests/Network_Adapters_Test.cpp index e42fc226182..7ef95d8116d 100644 --- a/ACE/tests/Network_Adapters_Test.cpp +++ b/ACE/tests/Network_Adapters_Test.cpp @@ -615,7 +615,6 @@ Stop_Handler::handle_input (ACE_HANDLE handle) // protect from deleted pointer try { - this->reactor ()->cancel_timer (this->handlers_to_stop_[i]); this->reactor ()->remove_handler (this->handlers_to_stop_[i], @@ -992,7 +991,6 @@ parse_args (int argc, ACE_TCHAR *argv[]) default: // return print_usage (argc,argv); break; - } } diff --git a/ACE/tests/Network_Adapters_Test.h b/ACE/tests/Network_Adapters_Test.h index ead6e6a120a..c49a81410c8 100644 --- a/ACE/tests/Network_Adapters_Test.h +++ b/ACE/tests/Network_Adapters_Test.h @@ -124,7 +124,6 @@ public: int does_echo_test_successful (void); private: - /// Wrapper for sending/receiving ICMPs. ACE_Ping_Socket ping_socket_; @@ -197,7 +196,6 @@ public: virtual int unregister_handler (ACE_Event_Handler * handler); private: - enum { HANDLERS_TO_STOP_TABLE_SIZE = 10 diff --git a/ACE/tests/OS_Test.cpp b/ACE/tests/OS_Test.cpp index abe20bdc17a..03666ca0ae2 100644 --- a/ACE/tests/OS_Test.cpp +++ b/ACE/tests/OS_Test.cpp @@ -861,7 +861,6 @@ string_strsncpy_test () 9) == 0); // size should be 9 (+ '\0' char) THIS_IS_NOT_AN_ASSERT_IT_IS_A_NON_DEBUG_TEST_AS_WELL(ACE_OS::strlen(strsncpy2) == 9); - } #if defined (ACE_HAS_WCHAR) diff --git a/ACE/tests/Object_Manager_Flipping_Test.cpp b/ACE/tests/Object_Manager_Flipping_Test.cpp index 572df1a262c..0531220c232 100644 --- a/ACE/tests/Object_Manager_Flipping_Test.cpp +++ b/ACE/tests/Object_Manager_Flipping_Test.cpp @@ -105,5 +105,4 @@ int run_main (int, ACE_TCHAR *[]) } return errors == 0 ? 0 : 1; - } diff --git a/ACE/tests/Object_Manager_Test.cpp b/ACE/tests/Object_Manager_Test.cpp index 27870763f34..b34eee97e24 100644 --- a/ACE/tests/Object_Manager_Test.cpp +++ b/ACE/tests/Object_Manager_Test.cpp @@ -16,7 +16,6 @@ #include "ace/Init_ACE.h" - static u_int *ip; extern "C" diff --git a/ACE/tests/OrdMultiSet_Test.cpp b/ACE/tests/OrdMultiSet_Test.cpp index f62bf4ada6f..efd30bb1d51 100644 --- a/ACE/tests/OrdMultiSet_Test.cpp +++ b/ACE/tests/OrdMultiSet_Test.cpp @@ -20,7 +20,6 @@ #include "ace/Containers.h" - int run_main (int, ACE_TCHAR *[]) { diff --git a/ACE/tests/Priority_Buffer_Test.cpp b/ACE/tests/Priority_Buffer_Test.cpp index 57d257d8b37..4877f5e1cdb 100644 --- a/ACE/tests/Priority_Buffer_Test.cpp +++ b/ACE/tests/Priority_Buffer_Test.cpp @@ -18,7 +18,6 @@ #include "ace/Thread_Manager.h" - #if defined (ACE_HAS_THREADS) static const char ACE_ALPHABET[] = "abcdefghijklmnopqrstuvwxyz"; diff --git a/ACE/tests/Priority_Reactor_Test.cpp b/ACE/tests/Priority_Reactor_Test.cpp index b2a99ea8e0a..c37451a6189 100644 --- a/ACE/tests/Priority_Reactor_Test.cpp +++ b/ACE/tests/Priority_Reactor_Test.cpp @@ -32,7 +32,6 @@ #include <utility> - static const char ACE_ALPHABET[] = "abcdefghijklmnopqrstuvwxyz"; // The number of children to run, it can be changed using the -c diff --git a/ACE/tests/Proactor_Scatter_Gather_Test.cpp b/ACE/tests/Proactor_Scatter_Gather_Test.cpp index d0e75e84e25..785576e9c6d 100644 --- a/ACE/tests/Proactor_Scatter_Gather_Test.cpp +++ b/ACE/tests/Proactor_Scatter_Gather_Test.cpp @@ -916,7 +916,6 @@ class Sender : public ACE_Service_Handler { friend class Connector; public: - Sender (Connector *connector = 0, int index = -1); virtual ~Sender (void); diff --git a/ACE/tests/Proactor_Test.cpp b/ACE/tests/Proactor_Test.cpp index 04bea2e7779..e82b054b90c 100644 --- a/ACE/tests/Proactor_Test.cpp +++ b/ACE/tests/Proactor_Test.cpp @@ -103,13 +103,11 @@ static char complete_message[] = class LogLocker { public: - LogLocker () { ACE_LOG_MSG->acquire (); } virtual ~LogLocker () { ACE_LOG_MSG->release (); } }; - // Function to remove signals from the signal mask. static int disable_signal (int sigmin, int sigmax) @@ -190,7 +188,6 @@ private: ACE_SYNCH_RECURSIVE_MUTEX lock_; ACE_Thread_Semaphore sem_; ACE_Proactor * proactor_; - }; int diff --git a/ACE/tests/Proactor_Test.h b/ACE/tests/Proactor_Test.h index 02bd4a40796..94b51d30584 100644 --- a/ACE/tests/Proactor_Test.h +++ b/ACE/tests/Proactor_Test.h @@ -83,7 +83,6 @@ private: class Client : public ACE_Service_Handler { public: - /// This is called after the new connection has been established. virtual void open (ACE_HANDLE handle, ACE_Message_Block &message_block); diff --git a/ACE/tests/Proactor_UDP_Test.cpp b/ACE/tests/Proactor_UDP_Test.cpp index 9f4cbd438fb..5d32acc263d 100644 --- a/ACE/tests/Proactor_UDP_Test.cpp +++ b/ACE/tests/Proactor_UDP_Test.cpp @@ -100,7 +100,6 @@ static char close_ack_msg[] = "CLOSE-ACK"; class LogLocker { public: - LogLocker () { ACE_LOG_MSG->acquire (); } virtual ~LogLocker () { ACE_LOG_MSG->release (); } }; @@ -184,7 +183,6 @@ private: ACE_SYNCH_RECURSIVE_MUTEX lock_; ACE_Thread_Semaphore sem_; ACE_Proactor * proactor_; - }; int diff --git a/ACE/tests/Process_Manager_Test.cpp b/ACE/tests/Process_Manager_Test.cpp index 02d89c320c4..d5bd07b5536 100644 --- a/ACE/tests/Process_Manager_Test.cpp +++ b/ACE/tests/Process_Manager_Test.cpp @@ -75,7 +75,6 @@ spawn_child (const ACE_TCHAR *argv0, int sleep_time, int my_process_id) { - #if defined (ACE_HAS_WINCE) const ACE_TCHAR *cmdline_format = ACE_TEXT("%s %d"); #elif defined (ACE_WIN32) diff --git a/ACE/tests/Process_Strategy_Test.h b/ACE/tests/Process_Strategy_Test.h index 190b1d392ea..dafc57487ae 100644 --- a/ACE/tests/Process_Strategy_Test.h +++ b/ACE/tests/Process_Strategy_Test.h @@ -72,7 +72,6 @@ protected: class Process_Strategy : public ACE_Process_Strategy<Counting_Service> { public: - // Constructor Process_Strategy (size_t n_processes = 1, ACE_Event_Handler *acceptor = 0, diff --git a/ACE/tests/QtReactor_Test.cpp b/ACE/tests/QtReactor_Test.cpp index cbc994d4300..dbb33561dee 100644 --- a/ACE/tests/QtReactor_Test.cpp +++ b/ACE/tests/QtReactor_Test.cpp @@ -611,7 +611,6 @@ int HandlersRegister::scheduleTimers (const ACE_Time_Value &p_TestTime) -1); DgramHandlers_[ i ] ->expectedTriggers (DgramsToSend); - } return 0; @@ -900,7 +899,6 @@ void testQtReactor (int argc, ACE_TCHAR *argv[]) 0 <= handlersRegister.registerDgramHandlers () && 0 <= handlersRegister.registerTCPHandlers ()) { - app.exec (TotalTestTime); if (0 != handlersRegister.analyze ()) diff --git a/ACE/tests/RB_Tree_Test.h b/ACE/tests/RB_Tree_Test.h index 1b9d52fa91c..911ca6c37c0 100644 --- a/ACE/tests/RB_Tree_Test.h +++ b/ACE/tests/RB_Tree_Test.h @@ -23,7 +23,6 @@ template <class EXT_ID, class INT_ID, class COMPARE_KEYS, class ACE_LOCK> class ACE_RB_Tree_Test { - // To run the test class on a particular type instantiation of the // RB_Tree, simply instantiate the test class template with the // same type parameters, and invoke the run_test method. @@ -50,7 +49,6 @@ public: void run_test (void); private: - /// Tests stable and deprecated insertion interfaces. void test_tree_insertion (void); @@ -101,5 +99,4 @@ private: /// Order of indices in the key and item arrays. int *order_index_; - }; diff --git a/ACE/tests/RW_Process_Mutex_Test.cpp b/ACE/tests/RW_Process_Mutex_Test.cpp index 36ba22dd187..0b057803db9 100644 --- a/ACE/tests/RW_Process_Mutex_Test.cpp +++ b/ACE/tests/RW_Process_Mutex_Test.cpp @@ -22,7 +22,6 @@ #include "ace/OS_NS_unistd.h" - // The parent process is number -1. Writer is 0; Readers are 1-3. static int child_nr = -1; static u_short reporting_port = 0; diff --git a/ACE/tests/Reactor_Fairness_Test.cpp b/ACE/tests/Reactor_Fairness_Test.cpp index 426adc3e269..3a01da60f23 100644 --- a/ACE/tests/Reactor_Fairness_Test.cpp +++ b/ACE/tests/Reactor_Fairness_Test.cpp @@ -31,7 +31,6 @@ #if defined (ACE_HAS_THREADS) namespace { - const char ACE_ALPHABET[] = "abcdefghijklmnopqrstuvwxyz"; // Number of connections to run diff --git a/ACE/tests/Reactor_Notification_Queue_Test.cpp b/ACE/tests/Reactor_Notification_Queue_Test.cpp index 47bdfe3c429..8b643af240f 100644 --- a/ACE/tests/Reactor_Notification_Queue_Test.cpp +++ b/ACE/tests/Reactor_Notification_Queue_Test.cpp @@ -180,7 +180,6 @@ Event_Handler::handle_exception (ACE_HANDLE) { if(notifications_curr_ >= max_notifications_) { - return 0; } send_notifications(); diff --git a/ACE/tests/Reactor_Notify_Test.cpp b/ACE/tests/Reactor_Notify_Test.cpp index 08874f291c3..89afd26e4fc 100644 --- a/ACE/tests/Reactor_Notify_Test.cpp +++ b/ACE/tests/Reactor_Notify_Test.cpp @@ -446,7 +446,6 @@ run_test (int disable_notify_pipe, */ class Purged_Notify : public ACE_Event_Handler { - int handle_exception (ACE_HANDLE = ACE_INVALID_HANDLE) override { ACE_ERROR_RETURN ((LM_ERROR, diff --git a/ACE/tests/Reactor_Registration_Test.cpp b/ACE/tests/Reactor_Registration_Test.cpp index f4d98da89e5..ffee3485de3 100644 --- a/ACE/tests/Reactor_Registration_Test.cpp +++ b/ACE/tests/Reactor_Registration_Test.cpp @@ -24,7 +24,6 @@ static int iteration = 1; class Event_Handler : public ACE_Event_Handler { public: - Event_Handler (ACE_Reactor &reactor, ACE_HANDLE read, ACE_HANDLE write); diff --git a/ACE/tests/Reactor_Remove_Resume_Test.cpp b/ACE/tests/Reactor_Remove_Resume_Test.cpp index e70af6e1f09..6fa52a697ec 100644 --- a/ACE/tests/Reactor_Remove_Resume_Test.cpp +++ b/ACE/tests/Reactor_Remove_Resume_Test.cpp @@ -29,13 +29,11 @@ int overall_result = 0; class Bogus_Handler : public ACE_Event_Handler { public: - Bogus_Handler (ACE_Reactor * reactor, ACE_HANDLE read_handle, bool & okay_to_close); protected: - ~Bogus_Handler () override; ACE_HANDLE get_handle () const override; @@ -45,13 +43,11 @@ protected: int resume_handler () override; private: - ACE_HANDLE const read_handle_; // If the reactor closes the event handler before it gets the okay, // we will issue an error. bool & okay_to_close_; - }; Bogus_Handler::Bogus_Handler (ACE_Reactor * reactor, @@ -113,7 +109,6 @@ Bogus_Handler::resume_handler () class Bad_Handler : public ACE_Event_Handler { public: - Bad_Handler (ACE_Reactor * reactor, ACE_HANDLE read_handle, bool & okay_to_close, @@ -122,11 +117,9 @@ public: ACE_HANDLE write_handle () const; protected: - ~Bad_Handler () override; private: - ACE_HANDLE get_handle () const override; int handle_input (ACE_HANDLE handle) override; int handle_close (ACE_HANDLE handle, @@ -135,7 +128,6 @@ private: int handle_input_result () const; private: - ACE_HANDLE const read_handle_; bool handle_close_called_; @@ -146,7 +138,6 @@ private: // Are we running the event handler suspension or removal test? bool suspension_test_; - }; Bad_Handler::Bad_Handler (ACE_Reactor * reactor, @@ -161,7 +152,6 @@ Bad_Handler::Bad_Handler (ACE_Reactor * reactor, { this->reference_counting_policy ().value ( ACE_Event_Handler::Reference_Counting_Policy::ENABLED); - } Bad_Handler::~Bad_Handler () diff --git a/ACE/tests/Reactor_Remove_Resume_Test_Dev_Poll.cpp b/ACE/tests/Reactor_Remove_Resume_Test_Dev_Poll.cpp index 943304eaf49..e591a9b0159 100644 --- a/ACE/tests/Reactor_Remove_Resume_Test_Dev_Poll.cpp +++ b/ACE/tests/Reactor_Remove_Resume_Test_Dev_Poll.cpp @@ -33,13 +33,11 @@ int overall_result = 0; class Bogus_Handler : public ACE_Event_Handler { public: - Bogus_Handler (ACE_Reactor * reactor, ACE_HANDLE read_handle, bool & okay_to_close); protected: - ~Bogus_Handler () override; ACE_HANDLE get_handle () const override; @@ -49,13 +47,11 @@ protected: int resume_handler () override; private: - ACE_HANDLE const read_handle_; // If the reactor closes the event handler before it gets the okay, // we will issue an error. bool & okay_to_close_; - }; Bogus_Handler::Bogus_Handler (ACE_Reactor * reactor, @@ -117,7 +113,6 @@ Bogus_Handler::resume_handler () class Bad_Handler : public ACE_Event_Handler { public: - Bad_Handler (ACE_Reactor * reactor, ACE_HANDLE read_handle, bool & okay_to_close, @@ -126,11 +121,9 @@ public: ACE_HANDLE write_handle () const; protected: - ~Bad_Handler () override; private: - ACE_HANDLE get_handle () const override; int handle_input (ACE_HANDLE handle) override; int handle_close (ACE_HANDLE handle, @@ -139,7 +132,6 @@ private: int handle_input_result () const; private: - ACE_HANDLE const read_handle_; bool handle_close_called_; @@ -150,7 +142,6 @@ private: // Are we running the event handler suspension or removal test? bool suspension_test_; - }; Bad_Handler::Bad_Handler (ACE_Reactor * reactor, @@ -165,7 +156,6 @@ Bad_Handler::Bad_Handler (ACE_Reactor * reactor, { this->reference_counting_policy ().value ( ACE_Event_Handler::Reference_Counting_Policy::ENABLED); - } Bad_Handler::~Bad_Handler () diff --git a/ACE/tests/Reader_Writer_Test.cpp b/ACE/tests/Reader_Writer_Test.cpp index a9c747f5f2f..95ff35d4457 100644 --- a/ACE/tests/Reader_Writer_Test.cpp +++ b/ACE/tests/Reader_Writer_Test.cpp @@ -157,7 +157,6 @@ reader (void *) ACE_DEBUG ((LM_DEBUG, ACE_TEXT ("(%t) could not upgrade to write lock!\n"))); - } else // result == -1 { diff --git a/ACE/tests/Recursive_Mutex_Test.cpp b/ACE/tests/Recursive_Mutex_Test.cpp index 891cf42b6df..4ecd657ffa2 100644 --- a/ACE/tests/Recursive_Mutex_Test.cpp +++ b/ACE/tests/Recursive_Mutex_Test.cpp @@ -21,7 +21,6 @@ #include "ace/Recursive_Thread_Mutex.h" - #if defined (ACE_HAS_THREADS) #include "ace/Guard_T.h" diff --git a/ACE/tests/Refcounted_Event_Handler_Test_DevPoll.cpp b/ACE/tests/Refcounted_Event_Handler_Test_DevPoll.cpp index 92bad5dd0dd..591581b8951 100644 --- a/ACE/tests/Refcounted_Event_Handler_Test_DevPoll.cpp +++ b/ACE/tests/Refcounted_Event_Handler_Test_DevPoll.cpp @@ -21,7 +21,6 @@ #include "ace/ACE.h" - #if defined (ACE_HAS_DEV_POLL) || defined (ACE_HAS_EVENT_POLL) static const char *message = diff --git a/ACE/tests/Reference_Counted_Event_Handler_Test.cpp b/ACE/tests/Reference_Counted_Event_Handler_Test.cpp index 7e2081b837d..02a2272cbd5 100644 --- a/ACE/tests/Reference_Counted_Event_Handler_Test.cpp +++ b/ACE/tests/Reference_Counted_Event_Handler_Test.cpp @@ -764,7 +764,6 @@ simple (ACE_Reactor_Impl *impl) class Closed_In_Upcall_Event_Handler : public ACE_Event_Handler { public: - Closed_In_Upcall_Event_Handler (int &events); ~Closed_In_Upcall_Event_Handler () override; @@ -781,7 +780,6 @@ public: ACE_Pipe pipe_; int &events_; - }; Closed_In_Upcall_Event_Handler::Closed_In_Upcall_Event_Handler (int &events) diff --git a/ACE/tests/SOCK_Connector_Test.cpp b/ACE/tests/SOCK_Connector_Test.cpp index 78cabecb0d0..20292064aa8 100644 --- a/ACE/tests/SOCK_Connector_Test.cpp +++ b/ACE/tests/SOCK_Connector_Test.cpp @@ -72,7 +72,6 @@ find_another_host (ACE_TCHAR other_host[]) if (cached_other_host[0] == '\0') { - ACE_OS::strcpy (other_host, ACE_DEFAULT_SERVER_HOST); // If all else fails @@ -316,4 +315,3 @@ run_main (int, ACE_TCHAR *[]) } - diff --git a/ACE/tests/SOCK_Netlink_Test.cpp b/ACE/tests/SOCK_Netlink_Test.cpp index d4c8e08bd2a..49122342009 100644 --- a/ACE/tests/SOCK_Netlink_Test.cpp +++ b/ACE/tests/SOCK_Netlink_Test.cpp @@ -190,7 +190,6 @@ struct Netlink_Request }; - /** * The handler first is trying to delete an ip-address, further * to add the ip and, if successful to cleanup the address. @@ -198,7 +197,6 @@ struct Netlink_Request class Secondary_Ipaddr_Handler : public ACE_Event_Handler { public: - // Default constructor Secondary_Ipaddr_Handler (); @@ -260,7 +258,6 @@ public: int get_state () const { return this->state_;} protected: - //FUZZ: disable check_for_lack_ACE_OS // De-registers the handler from the reactor, // other cleanup jobs @@ -270,7 +267,6 @@ protected: ACE_SOCK_Netlink& socket (); private: - // Schedule two sec timer. int schedule_one_sec_timer (); diff --git a/ACE/tests/SOCK_Send_Recv_Test.cpp b/ACE/tests/SOCK_Send_Recv_Test.cpp index 045ee1077ad..544bf8a6641 100644 --- a/ACE/tests/SOCK_Send_Recv_Test.cpp +++ b/ACE/tests/SOCK_Send_Recv_Test.cpp @@ -29,7 +29,6 @@ #include "ace/SOCK_Stream.h" - // Change to non-zero if test fails static int Test_Result = 0; diff --git a/ACE/tests/SOCK_Test.cpp b/ACE/tests/SOCK_Test.cpp index 0235a6b9123..63e74c76a63 100644 --- a/ACE/tests/SOCK_Test.cpp +++ b/ACE/tests/SOCK_Test.cpp @@ -25,7 +25,6 @@ #include "ace/Handle_Set.h" - static const char ACE_ALPHABET[] = "abcdefghijklmnopqrstuvwxyz"; void * diff --git a/ACE/tests/SPIPE_Test.cpp b/ACE/tests/SPIPE_Test.cpp index 7d782abd66a..0871fbdb147 100644 --- a/ACE/tests/SPIPE_Test.cpp +++ b/ACE/tests/SPIPE_Test.cpp @@ -25,7 +25,6 @@ #include "ace/OS_NS_unistd.h" - #if defined (ACE_HAS_STREAM_PIPES) || defined (ACE_HAS_WIN32_NAMED_PIPES) # define TEST_HAS_STREAM_PIPES #endif diff --git a/ACE/tests/SSL/SSL_Asynch_Stream_Test.cpp b/ACE/tests/SSL/SSL_Asynch_Stream_Test.cpp index 3bfe9271e7f..8a52126f1b0 100644 --- a/ACE/tests/SSL/SSL_Asynch_Stream_Test.cpp +++ b/ACE/tests/SSL/SSL_Asynch_Stream_Test.cpp @@ -39,7 +39,6 @@ #include "ace/SSL/SSL_SOCK_Stream.h" - #if defined (ACE_HAS_THREADS) && ((defined (ACE_WIN32) && !defined (ACE_HAS_WINCE)) || (defined (ACE_HAS_AIO_CALLS))) // This only works on Win32 platforms and on Unix platforms // supporting POSIX aio calls. diff --git a/ACE/tests/SString_Test.cpp b/ACE/tests/SString_Test.cpp index b79c5979105..75d47ad8b84 100644 --- a/ACE/tests/SString_Test.cpp +++ b/ACE/tests/SString_Test.cpp @@ -18,7 +18,6 @@ #include "ace/SString.h" - static int testConcatenation() { #ifdef ACE_HAS_WCHAR ACE_WString s1; @@ -161,7 +160,6 @@ run_main (int, ACE_TCHAR *[]) ACE_START_TEST (ACE_TEXT ("SString_Test")); { - /* Set #1 */ ACE_CString s0 ("hello"); ACE_CString s1 ("hello"); diff --git a/ACE/tests/STL_algorithm_Test_T.cpp b/ACE/tests/STL_algorithm_Test_T.cpp index 5c9b99cfe68..12cd2766165 100644 --- a/ACE/tests/STL_algorithm_Test_T.cpp +++ b/ACE/tests/STL_algorithm_Test_T.cpp @@ -12,7 +12,6 @@ public: Element_Counter (void) : count_ (0) { - } void operator () (typename T::value_type & item) diff --git a/ACE/tests/SV_Shared_Memory_Test.cpp b/ACE/tests/SV_Shared_Memory_Test.cpp index ab3a6aba346..b8776216917 100644 --- a/ACE/tests/SV_Shared_Memory_Test.cpp +++ b/ACE/tests/SV_Shared_Memory_Test.cpp @@ -24,7 +24,6 @@ - #if defined (ACE_HAS_SYSV_IPC) && !defined(ACE_LACKS_SYSV_SHMEM) // The shared memory allocator, which uses up the ACE_DEFAULT_SEM_KEY. diff --git a/ACE/tests/Service_Config_DLL.h b/ACE/tests/Service_Config_DLL.h index ca66ec748db..e2bdf906c9d 100644 --- a/ACE/tests/Service_Config_DLL.h +++ b/ACE/tests/Service_Config_DLL.h @@ -34,7 +34,6 @@ class Service_Config_DLL_Export Service_Config_DLL : public ACE_Task_Base { public: - /// Constructor. Service_Config_DLL (void); @@ -52,11 +51,9 @@ public: virtual int svc (); private: - /// Directives to be passed to be processed by the Service /// Configurator in separate threads. ACE_TCHAR directive_[2][BUFSIZ]; - }; /** diff --git a/ACE/tests/Service_Config_Stream_DLL.cpp b/ACE/tests/Service_Config_Stream_DLL.cpp index c33e875e931..377c4d71ecc 100644 --- a/ACE/tests/Service_Config_Stream_DLL.cpp +++ b/ACE/tests/Service_Config_Stream_DLL.cpp @@ -3,7 +3,6 @@ #include "ace/Service_Types.h" - int Test_Task::open (void *) { diff --git a/ACE/tests/Sig_Handlers_Test.cpp b/ACE/tests/Sig_Handlers_Test.cpp index 495fc85aadc..9378667c33c 100644 --- a/ACE/tests/Sig_Handlers_Test.cpp +++ b/ACE/tests/Sig_Handlers_Test.cpp @@ -23,7 +23,6 @@ #include "ace/SString.h" - class Test_SIGINT_Handler : public ACE_Event_Handler { public: diff --git a/ACE/tests/Sigset_Ops_Test.cpp b/ACE/tests/Sigset_Ops_Test.cpp index e29272100e1..9402ab7f0cc 100644 --- a/ACE/tests/Sigset_Ops_Test.cpp +++ b/ACE/tests/Sigset_Ops_Test.cpp @@ -17,7 +17,6 @@ #include "ace/OS_NS_errno.h" - void siglistset (sigset_t x, int *sigset, int can_miss = 0) { diff --git a/ACE/tests/Simple_Message_Block_Test.cpp b/ACE/tests/Simple_Message_Block_Test.cpp index 0023f88a4a3..2c331dd9696 100644 --- a/ACE/tests/Simple_Message_Block_Test.cpp +++ b/ACE/tests/Simple_Message_Block_Test.cpp @@ -21,7 +21,6 @@ #include "ace/Thread_Mutex.h" - int run_main (int, ACE_TCHAR *[]) { diff --git a/ACE/tests/Singleton_Test.cpp b/ACE/tests/Singleton_Test.cpp index 33d9ab857c7..936295f4277 100644 --- a/ACE/tests/Singleton_Test.cpp +++ b/ACE/tests/Singleton_Test.cpp @@ -14,7 +14,6 @@ #include "ace/Singleton.h" - int run_main (int, ACE_TCHAR *[]) { diff --git a/ACE/tests/Stack_Trace_Test.cpp b/ACE/tests/Stack_Trace_Test.cpp index ec14d0dc9e4..57cda976c31 100644 --- a/ACE/tests/Stack_Trace_Test.cpp +++ b/ACE/tests/Stack_Trace_Test.cpp @@ -16,7 +16,6 @@ #include "test_config.h" - /* * Ultra-basic test of stack trace. * diff --git a/ACE/tests/TP_Reactor_Test.cpp b/ACE/tests/TP_Reactor_Test.cpp index 48691c478c4..d81410851ba 100644 --- a/ACE/tests/TP_Reactor_Test.cpp +++ b/ACE/tests/TP_Reactor_Test.cpp @@ -106,7 +106,6 @@ static char data[] = class LogLocker { public: - LogLocker () { ACE_LOG_MSG->acquire (); } virtual ~LogLocker () { ACE_LOG_MSG->release (); } }; @@ -693,13 +692,11 @@ Connector::on_delete_sender (Sender & sndr) bufs, bufr, this->sessions_)); - } int Connector::start (const ACE_INET_Addr & addr, int num) { - if (ACE_Connector<Sender,ACE_SOCK_CONNECTOR>::open (ACE_Reactor::instance (), ACE_NONBLOCK) < 0) ACE_ERROR_RETURN @@ -1176,7 +1173,6 @@ run_main (int argc, ACE_TCHAR *argv[]) if (addr.set (port, host, 1, addr.get_type ()) == -1) ACE_ERROR ((LM_ERROR, ACE_TEXT ("%p\n"), host)); rc += connector.start (addr, senders); - } if (rc > 0) diff --git a/ACE/tests/TP_Reactor_Test.h b/ACE/tests/TP_Reactor_Test.h index 92fe33b0747..d9c8f608dec 100644 --- a/ACE/tests/TP_Reactor_Test.h +++ b/ACE/tests/TP_Reactor_Test.h @@ -38,7 +38,6 @@ class Receiver : public ACE_Svc_Handler<ACE_SOCK_STREAM, ACE_MT_SYNCH> { friend class Acceptor; public: - Receiver (Acceptor * acceptor=0, size_t index=MAX_RECEIVERS+1); ~Receiver (void); @@ -94,7 +93,6 @@ public: virtual int make_svc_handler (Receiver * & sh); private: - ACE_Recursive_Thread_Mutex mutex_; size_t sessions_; Receiver *list_receivers_[MAX_RECEIVERS]; @@ -178,7 +176,6 @@ public: virtual int make_svc_handler (Sender * & sh); private: - ACE_Recursive_Thread_Mutex mutex_; size_t sessions_; Sender * list_senders_ [MAX_SENDERS]; diff --git a/ACE/tests/TSS_Static_Test.cpp b/ACE/tests/TSS_Static_Test.cpp index 8a3aef6f659..b08f33ebee2 100644 --- a/ACE/tests/TSS_Static_Test.cpp +++ b/ACE/tests/TSS_Static_Test.cpp @@ -20,7 +20,6 @@ #include "ace/Thread.h" - #if defined (ACE_HAS_TSS_EMULATION) class Some_Object diff --git a/ACE/tests/TSS_Test.cpp b/ACE/tests/TSS_Test.cpp index 79c7ca3d113..62feb204519 100644 --- a/ACE/tests/TSS_Test.cpp +++ b/ACE/tests/TSS_Test.cpp @@ -23,7 +23,6 @@ #include "TSS_Test_Errno.h" - static u_int errors = 0; #if defined (ACE_HAS_THREADS) diff --git a/ACE/tests/Task_Ex_Test.cpp b/ACE/tests/Task_Ex_Test.cpp index 4acc9159ea6..c362de4c6fb 100644 --- a/ACE/tests/Task_Ex_Test.cpp +++ b/ACE/tests/Task_Ex_Test.cpp @@ -41,7 +41,6 @@ public: /// svc thread entry point int svc () override; private: - }; int Consumer::open (void*) diff --git a/ACE/tests/Thread_Attrs_Test.cpp b/ACE/tests/Thread_Attrs_Test.cpp index 3f70624918c..a8edb0327b8 100644 --- a/ACE/tests/Thread_Attrs_Test.cpp +++ b/ACE/tests/Thread_Attrs_Test.cpp @@ -125,7 +125,6 @@ Cancel_Check::open (void *) */ class Stack_Size_Check : public ACE_Task<ACE_MT_SYNCH> { - public: /// Create the thread with specified stack size Stack_Size_Check (size_t stack_size); diff --git a/ACE/tests/Thread_Creation_Threshold_Test.cpp b/ACE/tests/Thread_Creation_Threshold_Test.cpp index 04d501e1eb6..a84bd553651 100644 --- a/ACE/tests/Thread_Creation_Threshold_Test.cpp +++ b/ACE/tests/Thread_Creation_Threshold_Test.cpp @@ -21,7 +21,6 @@ #include "ace/Task.h" - #if defined (ACE_HAS_THREADS) #include "ace/Lock_Adapter_T.h" #include "ace/OS_NS_stdio.h" diff --git a/ACE/tests/Thread_Manager_Test.cpp b/ACE/tests/Thread_Manager_Test.cpp index 5a991655193..878f83d23e9 100644 --- a/ACE/tests/Thread_Manager_Test.cpp +++ b/ACE/tests/Thread_Manager_Test.cpp @@ -192,7 +192,6 @@ ThrMgr_Task::svc () static int test_task_record_keeping (ACE_Thread_Manager *mgr) { - int status = 0; ThrMgr_Task t1 (mgr), t2 (mgr); diff --git a/ACE/tests/Thread_Mutex_Test.cpp b/ACE/tests/Thread_Mutex_Test.cpp index b8b0485b56b..3f72afe6db6 100644 --- a/ACE/tests/Thread_Mutex_Test.cpp +++ b/ACE/tests/Thread_Mutex_Test.cpp @@ -19,7 +19,6 @@ #include "ace/OS_NS_unistd.h" - #if defined (ACE_HAS_THREADS) #include "ace/Guard_T.h" diff --git a/ACE/tests/Thread_Pool_Reactor_Resume_Test.cpp b/ACE/tests/Thread_Pool_Reactor_Resume_Test.cpp index 16835222354..edfbcf035a7 100644 --- a/ACE/tests/Thread_Pool_Reactor_Resume_Test.cpp +++ b/ACE/tests/Thread_Pool_Reactor_Resume_Test.cpp @@ -39,7 +39,6 @@ #include "ace/TP_Reactor.h" - #if defined (ACE_HAS_THREADS) && !defined ACE_LACKS_ACCEPT #include "Thread_Pool_Reactor_Resume_Test.h" diff --git a/ACE/tests/Thread_Pool_Reactor_Resume_Test.h b/ACE/tests/Thread_Pool_Reactor_Resume_Test.h index 677dd333e1c..41d00f74901 100644 --- a/ACE/tests/Thread_Pool_Reactor_Resume_Test.h +++ b/ACE/tests/Thread_Pool_Reactor_Resume_Test.h @@ -31,7 +31,6 @@ class Request_Handler : public ACE_Svc_Handler<ACE_SOCK_STREAM, ACE_MT_SYNCH> { public: - /// The default constructor makes sure the right reactor is used. Request_Handler (ACE_Thread_Manager *tm = 0); diff --git a/ACE/tests/Thread_Pool_Reactor_Test.cpp b/ACE/tests/Thread_Pool_Reactor_Test.cpp index 07c134f96fd..aa654361fba 100644 --- a/ACE/tests/Thread_Pool_Reactor_Test.cpp +++ b/ACE/tests/Thread_Pool_Reactor_Test.cpp @@ -42,7 +42,6 @@ #include "ace/TP_Reactor.h" - #if defined (ACE_HAS_THREADS) && !defined ACE_LACKS_ACCEPT #include "Thread_Pool_Reactor_Test.h" diff --git a/ACE/tests/Thread_Timer_Queue_Adapter_Test.cpp b/ACE/tests/Thread_Timer_Queue_Adapter_Test.cpp index f932dbd2ad5..b5d62df79a6 100644 --- a/ACE/tests/Thread_Timer_Queue_Adapter_Test.cpp +++ b/ACE/tests/Thread_Timer_Queue_Adapter_Test.cpp @@ -22,7 +22,6 @@ class ICustomEventHandler { public: - /// Default constructor. /// /// @return @@ -51,7 +50,6 @@ class ICustomEventHandler class CCustomEventHandlerUpcall { public: - using TTimerQueue = ACE_Timer_Queue_T<ICustomEventHandler *, CCustomEventHandlerUpcall, ACE_Null_Mutex>; /// Default constructor @@ -115,7 +113,6 @@ class CCustomEventHandlerUpcall class CTestEventHandler : public ICustomEventHandler { public: - /// Default constructor. /// /// @return @@ -154,7 +151,6 @@ class CTestEventHandler : public ICustomEventHandler } private: - long* m_p_iCallCount; ACE_Thread_Mutex m_Mutex; }; diff --git a/ACE/tests/Timeprobe_Test.cpp b/ACE/tests/Timeprobe_Test.cpp index 9c518837edb..d4fa1f1d350 100644 --- a/ACE/tests/Timeprobe_Test.cpp +++ b/ACE/tests/Timeprobe_Test.cpp @@ -23,7 +23,6 @@ #include "ace/Timeprobe.h" - #if defined (ACE_ENABLE_TIMEPROBES) static const char *events_descriptions_0[] = diff --git a/ACE/tests/Timer_Cancellation_Test.cpp b/ACE/tests/Timer_Cancellation_Test.cpp index b4f3aa96d46..af2a3fae4cb 100644 --- a/ACE/tests/Timer_Cancellation_Test.cpp +++ b/ACE/tests/Timer_Cancellation_Test.cpp @@ -19,7 +19,6 @@ class Deadlock : public ACE_Task_Base { public: - int svc () override; int handle_timeout (const ACE_Time_Value ¤t_time, @@ -55,7 +54,6 @@ Deadlock::handle_timeout (const ACE_Time_Value &, class Event_Handler : public ACE_Event_Handler { public: - Event_Handler (Deadlock &deadlock); int handle_timeout (const ACE_Time_Value ¤t_time, diff --git a/ACE/tests/Timer_Queue_Reference_Counting_Test.cpp b/ACE/tests/Timer_Queue_Reference_Counting_Test.cpp index 94f7f395e85..2ada4183a34 100644 --- a/ACE/tests/Timer_Queue_Reference_Counting_Test.cpp +++ b/ACE/tests/Timer_Queue_Reference_Counting_Test.cpp @@ -24,7 +24,6 @@ #include "ace/OS_NS_unistd.h" - static int debug = 0; static const char *one_second_timeout = "one second timeout"; static const char *two_second_timeout = "two second timeout"; @@ -45,7 +44,6 @@ namespace class Reference_Counted_Event_Handler : public ACE_Event_Handler { public: - Reference_Counted_Event_Handler (int expected_number_of_handle_close_calls); ~Reference_Counted_Event_Handler () override; @@ -349,7 +347,6 @@ upcall_test<TIMER_QUEUE>::upcall_test (const char *timer_queue_type) class Simple_Event_Handler : public ACE_Event_Handler { public: - Simple_Event_Handler (); ~Simple_Event_Handler () override; diff --git a/ACE/tests/Token_Strategy_Test.cpp b/ACE/tests/Token_Strategy_Test.cpp index cc1401aa540..5c1e990164d 100644 --- a/ACE/tests/Token_Strategy_Test.cpp +++ b/ACE/tests/Token_Strategy_Test.cpp @@ -24,13 +24,11 @@ #include "ace/Barrier.h" - #if defined (ACE_HAS_THREADS) class Token_Strategy_Test : public ACE_Task<ACE_MT_SYNCH> { public: - Token_Strategy_Test (ACE_Token::QUEUEING_STRATEGY strategy = ACE_Token::FIFO, int threads = 5, int invocations = 10); ~Token_Strategy_Test () override; diff --git a/ACE/tests/UPIPE_SAP_Test.cpp b/ACE/tests/UPIPE_SAP_Test.cpp index c0b5a243b73..b8c420529eb 100644 --- a/ACE/tests/UPIPE_SAP_Test.cpp +++ b/ACE/tests/UPIPE_SAP_Test.cpp @@ -20,7 +20,6 @@ #include "ace/OS_NS_unistd.h" - #if defined (ACE_HAS_THREADS) && \ (defined (ACE_HAS_STREAM_PIPES) || defined (ACE_HAS_WIN32_NAMED_PIPES)) diff --git a/ACE/tests/Upgradable_RW_Test.cpp b/ACE/tests/Upgradable_RW_Test.cpp index e0f02830709..d6ef8d0b607 100644 --- a/ACE/tests/Upgradable_RW_Test.cpp +++ b/ACE/tests/Upgradable_RW_Test.cpp @@ -19,7 +19,6 @@ #include "ace/Atomic_Op.h" - #if defined (ACE_HAS_THREADS) // Default number of iterations. @@ -92,7 +91,6 @@ find_last () } return 0; - } // Explain usage and exit. diff --git a/ACE/tests/randomize.h b/ACE/tests/randomize.h index 5389814548f..25d47a543b6 100644 --- a/ACE/tests/randomize.h +++ b/ACE/tests/randomize.h @@ -73,7 +73,6 @@ namespace } private: - // The array. T * const array_; @@ -82,7 +81,6 @@ namespace // Random number generator seed value. unsigned int seed_; - }; /** |