summaryrefslogtreecommitdiff
path: root/TAO/tao/Policy_Factory.h
diff options
context:
space:
mode:
Diffstat (limited to 'TAO/tao/Policy_Factory.h')
-rw-r--r--TAO/tao/Policy_Factory.h23
1 files changed, 9 insertions, 14 deletions
diff --git a/TAO/tao/Policy_Factory.h b/TAO/tao/Policy_Factory.h
index bd90c8f1ce8..7eb286077d0 100644
--- a/TAO/tao/Policy_Factory.h
+++ b/TAO/tao/Policy_Factory.h
@@ -31,22 +31,14 @@ class TAO_Export TAO_Policy_Factory
// TAO_Policy_Factory
//
// = DESCRIPTION
- // This class creates a Policy based on the type of the type provided.
- // This class is needed to support the policies serialization.
+ // This class creates a Policy based on the
+ // type of the type provided.
+ // @@ Angelo, you could also mention why this class is needed, e.g.,
+ // why can't we just use ORB::create_policy for this purpose or why
+ // can't we creatte whatever policy we need directly...
public:
- // @@ Angelo: I don't think this is a good design, in the future we
- // may want to have the ORB create the policies, and maybe pluggin
- // new policies on the fly (such as protocol specific policies,
- // security policies, etc. etc.).
- // IMnsHO the right way to do this is to have it implemented in
- // the ORB, right now I guess we will have to hard code it, but
- // eventually we want to dynamically load the policies, much like
- // we can dynamically load protocols. The ORB would use the
- // <ptype> to find the right protocol factory from a dynamically
- // constructed list.
- //
static CORBA::Policy * create_policy (CORBA::PolicyType ptype);
// Creates a Policy of the type specified by <ptype>. NULL is
// returned if the policy type is unknown.
@@ -62,4 +54,7 @@ protected:
#include "ace/post.h"
-#endif // RTPOLICY_FACTORY_H_
+#endif // defined (RTPOLICY_FACTORY_H_)
+
+// @@ Angelo, I already left you a similar comment last time in another file,
+// to use /* RTPOLICY_FACTORY_H_ */ instead of what you have above