diff options
Diffstat (limited to 'TAO/tests/Exposed_Policies/client.cpp')
| -rw-r--r-- | TAO/tests/Exposed_Policies/client.cpp | 116 |
1 files changed, 76 insertions, 40 deletions
diff --git a/TAO/tests/Exposed_Policies/client.cpp b/TAO/tests/Exposed_Policies/client.cpp index 5f9d0f3d1c2..5c347530378 100644 --- a/TAO/tests/Exposed_Policies/client.cpp +++ b/TAO/tests/Exposed_Policies/client.cpp @@ -8,17 +8,13 @@ char object_ref[256]; ACE_RCSID(tao, client, "$Id$") - CORBA::Boolean check_reference (CORBA::Object_ptr object, - const char *msg = 0) +CORBA::Boolean +check_reference (CORBA::Object_ptr object, + const char *msg) { if (CORBA::is_nil (object)) { - if (msg == 0) - ACE_DEBUG ((LM_DEBUG, - ACE_TEXT ("The Object reference is nil.\n"))); - else - ACE_DEBUG ((LM_DEBUG, - ACE_TEXT (msg))); + ACE_DEBUG ((LM_DEBUG, ACE_TEXT (msg))); return 0; } return 1; @@ -33,9 +29,16 @@ main (int argc, char *argv[]) ACE_TRY { // ORB Initialization - CORBA::ORB_var orb = CORBA::ORB_init (argc, argv, "TAO", ACE_TRY_ENV); + CORBA::ORB_var orb = + CORBA::ORB_init (argc, argv, "TAO", ACE_TRY_ENV); + // @@ Angelo: there is no need to name the ORB, don't do it + // unless you have a good reason to, because it confuses the + // users that see this stuff. ACE_TRY_CHECK; - + + // @@ Angelo: we have been using -k IOR for this same kind of + // option forever, please try to make your examples consistent, + // it is easier to understand them that way. ACE_Arg_Shifter arg_shifter (argc, argv); int file_set = 0; @@ -53,78 +56,99 @@ main (int argc, char *argv[]) else arg_shifter.consume_arg (); } - + if (file_set == 0) ACE_OS_String::strcpy (object_ref, "file://poa_default.ior"); + // @@ Angelo: it is better style just to initialize the + // variables as soon as you declare them, in this case: + // + // CORBA::Object_var object = orb->string_to_object_.... + // CORBA::Object_var object; + // @@ Angelo: you may want to repeat the test multiple times in + // a loop, this is useful when running with Purify or similar + // tools because the leaks are more visible when you do that. + + // @@ Angelo: I'm not sure if you really need a client and a + // server, it may be enough to have a single program that does + // object_to_string() and then string_to_object() to verify that + // all the policies are preserved and parsed correctly. Those + // programs are usually much easier to debug and purify. + // Get the IOR from a file. object = orb->string_to_object (object_ref, ACE_TRY_ENV); ACE_TRY_CHECK; + // @@ Angelo: cool use of a helper routine, but you may want to + // declare the helper at the top of the file and put its + // definition at the bottom, to avoid distractions when looking + // for the core of the test. if (!check_reference (object, "Invalid IOR file!\n")) return 1; - + Counter_var counter = Counter::_narrow (object.in (), ACE_TRY_ENV); ACE_TRY_CHECK; - - if (!check_reference (object, + + if (!check_reference (object, "Unable to convert the IOR to the proper object reference.\n")) return 1; - + + // @@ Angelo: more initialization stuff. CORBA::Policy_var policy_ptr; policy_ptr = counter->_get_policy (RTCORBA::PRIORITY_MODEL_POLICY_TYPE, ACE_TRY_ENV); ACE_TRY_CHECK; - + if (check_reference (policy_ptr, "Unable to get Priority Policy.\n")) { RTCORBA::PriorityModelPolicy_var priority_policy = RTCORBA::PriorityModelPolicy::_narrow (policy_ptr); - - RTCORBA::PriorityModel priority_model = + + RTCORBA::PriorityModel priority_model = priority_policy->priority_model (ACE_TRY_ENV); ACE_TRY_CHECK; - - RTCORBA::Priority priority = + + RTCORBA::Priority priority = priority_policy->server_priority (ACE_TRY_ENV); ACE_TRY_CHECK; - + if (priority_model == RTCORBA::SERVER_DECLARED) - ACE_DEBUG ((LM_DEBUG, + ACE_DEBUG ((LM_DEBUG, ACE_TEXT ("\n\nPriority Model: RTCORBA::SERVER_DECLARED\n") )); - - ACE_DEBUG ((LM_DEBUG, + + ACE_DEBUG ((LM_DEBUG, ACE_TEXT ("Priority Model: %d\nCORBA Priority: %d\n\n"), priority_model, priority )); } - + policy_ptr = object->_get_policy (RTCORBA::PRIORITY_BANDED_CONNECTION_POLICY_TYPE, ACE_TRY_ENV); if (check_reference (policy_ptr, "Unable to get Priority Banded Policy\n")) { - - RTCORBA::PriorityBandedConnectionPolicy_var priority_banded_policy = + + RTCORBA::PriorityBandedConnectionPolicy_var priority_banded_policy = RTCORBA::PriorityBandedConnectionPolicy::_narrow (policy_ptr, ACE_TRY_ENV); ACE_TRY_CHECK; - - + + if (check_reference (priority_banded_policy, "Unable to get Priority Banded Policy\n")) { - + // Here we have a priority banded connection policy. - - RTCORBA::PriorityBands_var pb = priority_banded_policy->priority_bands (); + + RTCORBA::PriorityBands_var pb = + priority_banded_policy->priority_bands (); unsigned int band_num = pb->length (); for (unsigned int i = 0; i < band_num; ++i) { ACE_DEBUG ((LM_DEBUG, - ACE_TEXT ("Priority Band <%d>: (%d, %d)\n"), + ACE_TEXT ("Priority Band <%d>: (%d, %d)\n"), i, pb[i].low, pb[i].high @@ -136,20 +160,32 @@ main (int argc, char *argv[]) ACE_TRY_ENV); if (check_reference (policy_ptr, "Unable Client Protocol Policy\n")) { - RTCORBA::ClientProtocolPolicy_var client_protocol_policy = + RTCORBA::ClientProtocolPolicy_var client_protocol_policy = RTCORBA::ClientProtocolPolicy::_narrow (policy_ptr, ACE_TRY_ENV); ACE_TRY_CHECK; - - RTCORBA::ProtocolList_var protocol_list = + + RTCORBA::ProtocolList_var protocol_list = client_protocol_policy->protocols (ACE_TRY_ENV); ACE_TRY_CHECK; - + for (unsigned int i = 0; i < protocol_list->length (); i++) ACE_DEBUG ((LM_DEBUG, - ACE_TEXT ("\nThe Client Protocol Type: %d\n"), - protocol_list[ i].protocol_type)); - + ACE_TEXT ("\nThe Client Protocol Type: %d\n"), + protocol_list[i].protocol_type)); + } + + // @@ Angelo: cleanup the ORB at the end! + + // @@ Angelo: in general this is a good test, but it does not + // check if: + // + The values obtained are the expected values, could you + // compare against well known values somehow? + // + Can you check that things that should fail indeed do? For + // example: what if the user queries or tries to set a policy + // that makes no sense, like Timeouts? Certain values should + // be returned and maybe exceptions raised (I don't know), we + // need to check for that too! } ACE_CATCHANY { |