From b16df8d98e3fa28aa0ea9396405ab113ae749759 Mon Sep 17 00:00:00 2001 From: levine Date: Thu, 22 Jul 1999 15:02:17 +0000 Subject: ChangeLogTag: Thu Jul 22 09:55:10 1999 David L. Levine --- ChangeLog-99b | 5 +++++ docs/ACE-guidelines.html | 45 ++++++++++++++++++++++++++++++--------------- 2 files changed, 35 insertions(+), 15 deletions(-) diff --git a/ChangeLog-99b b/ChangeLog-99b index 3bc7c4232d9..6506697dfef 100644 --- a/ChangeLog-99b +++ b/ChangeLog-99b @@ -1,3 +1,8 @@ +Thu Jul 22 09:55:10 1999 David L. Levine + + * docs/ACE-guidelines.html: updated commit message guideline + to show ChangeLogTag example. + Thu Jul 22 02:15:46 1999 Irfan Pyarali * ace/Handle_Gobbler (class ACE_Handle_Gobbler): New class that diff --git a/docs/ACE-guidelines.html b/docs/ACE-guidelines.html index 892062fbe04..10ef969d160 100644 --- a/docs/ACE-guidelines.html +++ b/docs/ACE-guidelines.html @@ -646,14 +646,15 @@ bgcolor="#ffffff"> in most of their APIs. On these platforms, ACE also uses UNICODE as its system string type.

-

Notice that when spaning a string literal across several lines, - you must apply ASYS_TEXT to every line. - For example, it is illegal to do this: + Notice that when spaning a string literal across several lines, + you must apply ASYS_TEXT to every + line. For example, it is illegal to do this: 

         ACE_ERROR ((LM_ERROR,
                     ASYS_TEXT ("%p\n"),
                     ASYS_TEXT ("\nerror: x is a null pointer in "
-                               "ACE_RB_Tree::RB_rotate_left\n")));
+                               "ACE_RB_Tree<EXT_ID, INT_ID>::"
+                               "RB_rotate_left\n")));

Instead, this should be written like this: @@ -661,7 +662,8 @@ bgcolor="#ffffff"> ACE_ERROR ((LM_ERROR, ASYS_TEXT ("%p\n"), ASYS_TEXT ("\nerror: x is a null pointer in ") - ASYS_TEXT ("ACE_RB_Tree::RB_rotate_left\n"))); + ASYS_TEXT ("ACE_RB_Tree<EXT_ID, INT_ID>::") + ASYS_TEXT ("RB_rotate_left\n")));

  • ACE_TRACE handles conversion @@ -760,7 +762,8 @@ bgcolor="#ffffff"> ~exe_foo () { cerr << "destructor of exception called" << endl; } exe_foo (const exe_foo& foo) : data_ (foo.data_) - { cerr << "copy constructor of exception called" << endl; } + { cerr << "copy constructor of exception called" + << endl; } int data_; }; @@ -780,44 +783,52 @@ bgcolor="#ffffff"> int main () { - cout << endl << "First exception" << endl << endl; + cout << endl << "First exception" << endl + << endl; try { good (0); } catch (exe_foo &foo) { - cerr << "exception caught: " << foo.data_ << endl; + cerr << "exception caught: " << foo.data_ + << endl; } - cout << endl << "Second exception" << endl << endl; + cout << endl << "Second exception" << endl + << endl; try { good (0); } catch (exe_foo foo) { - cerr << "exception caught: " << foo.data_ << endl; + cerr << "exception caught: " << foo.data_ + << endl; } - cout << endl << "Third exception" << endl << endl; + cout << endl << "Third exception" << endl + << endl; try { bad (1); } catch (exe_foo &foo) { - cerr << "exception caught: " << foo.data_ << endl; + cerr << "exception caught: " << foo.data_ + << endl; } - cout << endl << "Fourth exception" << endl << endl; + cout << endl << "Fourth exception" << endl + << endl; try { bad (1); } catch (exe_foo foo) { - cerr << "exception caught: " << foo.data_ << endl; + cerr << "exception caught: " << foo.data_ + << endl; } return 0; @@ -996,7 +1007,6 @@ bgcolor="#ffffff">
  • Test your change on at least one platform. All changes must be tested with egcs before commiting. That means you may need to test on at least two platforms.

    -

  • Commit your change with a meaningful message.

  • An an entry to the appropriate ChangeLog. TAO and some ACE subdirectories, such as ASNMP, JAWS, and @@ -1004,6 +1014,11 @@ bgcolor="#ffffff"> own ChangeLogs. If you don't use one of those, use the ChangeLog in the top-level ACE_wrappers directory.

    +

  • Commit your change using a message of this form:

    + +ChangeLogTag: Thu Jul 22 09:55:10 1999 David L. Levine + <levine@cs.wustl.edu> +

  • If the change is in response to a request by someone else:
    1. Make sure that person is acknowledged in -- cgit v1.2.1