From cc279a022675fb707e5527286f6a7a150193cee6 Mon Sep 17 00:00:00 2001 From: Steve Huston Date: Tue, 17 Jun 2008 22:46:23 +0000 Subject: ChangeLogTag:Tue Jun 17 22:43:20 2008 Steve Huston --- ACE/ChangeLog | 9 +++++++++ ACE/THANKS | 1 + ACE/ace/Reactor.h | 12 +++++++++--- 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/ACE/ChangeLog b/ACE/ChangeLog index 7e331209ac1..0d14b1f18a7 100644 --- a/ACE/ChangeLog +++ b/ACE/ChangeLog @@ -1,3 +1,12 @@ +Tue Jun 17 22:43:20 2008 Steve Huston + + * ace/Reactor.h: Clarify that calling remove_handler() for a signal + handler does not invoke the handler's handle_close() callback. Also + note that this behavior is under debate in Bugzilla #2368. Thanks to + Bill Kendall for calling this to attention. + + * THANKS: Added Bill Kendall. + Tue Jun 17 15:36:49 UTC 2008 Yan Dai * ace/Stack_Trace.cpp: diff --git a/ACE/THANKS b/ACE/THANKS index afaa19dc74d..b3cc4b20192 100644 --- a/ACE/THANKS +++ b/ACE/THANKS @@ -2246,6 +2246,7 @@ Stephen Mouring Tim Thomas Brownridge June Fang +Bill Kendall I would particularly like to thank Paul Stephenson, who worked with me at Ericsson in the early 1990's. Paul devised the recursive Makefile diff --git a/ACE/ace/Reactor.h b/ACE/ace/Reactor.h index 405d2718a25..0941f4a3b7e 100644 --- a/ACE/ace/Reactor.h +++ b/ACE/ace/Reactor.h @@ -458,9 +458,15 @@ public: * Install the new disposition (if given) and return the previous * disposition (if desired by the caller). * - * ACE_Event_Handler::handle_close() will be called with - * @c ACE_Event_Handler::SIGNAL_MASK. - * ACE_Event_Handler::remove_reference() will also be called. + * Note that, unlike removing handler for I/O events, + * ACE_Event_Handler::handle_close() will not be called when the + * handler is removed. Neither will any reference-counting activity be + * involved. + * + * @note There's an existing enhancement request in Bugzilla, + * #2368, to change this behavior so that ACE_Event_Handler::handle_close() + * is called when the signal handler is removed. Thus, there's some chance + * this behavior will change in a future version of ACE. */ int remove_handler (int signum, ACE_Sig_Action *new_disp, -- cgit v1.2.1