blob: 4b995d286e856f4daa1938276bae0050cca8b48f (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
|
// -*- C++ -*-
// $Id$
#include "Round_Robin_Strategy.h"
#include "ReplicaProxy.h"
ACE_RCSID(orbsvcs, Round_Robin_Strategy, "$Id$")
Round_Robin_Strategy::Round_Robin_Strategy (void)
: proxies_ (),
next_replica_ (this->proxies_.begin ())
{
}
Round_Robin_Strategy::~Round_Robin_Strategy (void)
{
// @@ Are the objects deactivated from the POA? And shouldn't this
// be done by the LoadBalancing strategy *before* the destructor is
// invoked?
ReplicaProxySetIterator begin = this->proxies_.begin ();
ReplicaProxySetIterator end = this->proxies_.end ();
for (ReplicaProxySetIterator i = begin;
i != end;
++i)
{
// Decrease reference count on each proxy servant in the set.
(*i)->_remove_ref ();
}
}
CORBA::Object_ptr
Round_Robin_Strategy::replica (CORBA::Environment &ACE_TRY_ENV)
{
// @@ Ossama: more code that is not thread safe
if (this->proxies_.is_empty ())
{
// @@ What do we do if the set is empty?
// @@ Ossama: i'm throwing the OBJECT_NOT_EXIST exception, but
// maybe TRANSIENT is a better choice.... please read the
// relevant section of the CORBA spec and let me know what you
// think.
ACE_THROW_RETURN (CORBA::OBJECT_NOT_EXIST (),
CORBA::Object::_nil ());
}
// If we're at the end of the Replica set, then rewind to the
// beginning of the set.
if (this->next_replica_ == this->proxies_.end ())
this->next_replica_ = this->proxies_.begin ();
ReplicaProxy_Impl * proxy_servant = *(this->next_replica_);
// Advance to the next Replica in the set in preparation for the
// next call to this method.
this->next_replica_++;
// @@ Ossama: once we select a replica, shouldn't we temporarily
// change its load so it does not get swamped with all the new
// clients. Think about the current scenario:
// - Replica A has the lowest load, by far.
// - 5 clients connect at the same time.
// - If the load on A does not grow fast enough all 5 clients will
// end up on replica A, and then they will be kicked out and
// shuffled around.
// While if we bump the load for a few seconds then the next client
// will go to other place. Or set a flag that says 'load
// invalidated, waiting for an update' (i like the latter better).
return proxy_servant->replica ();
}
int
Round_Robin_Strategy::insert (ReplicaProxy_Impl *proxy)
{
// @@ Ossama: more code that is not thread safe
int r = this->proxies_.insert (proxy);
this->next_replica_ = this->proxies_.begin ();
return r;
}
int
Round_Robin_Strategy::remove (ReplicaProxy_Impl *proxy)
{
// @@ Ossama: more code that is not thread safe
int r = this->proxies_.remove (proxy);
this->next_replica_ = this->proxies_.begin ();
return r;
}
|
