Correct sa findings

dlt_offline_logstorage.c
- Parameter to isdigit is not correct
- Handle the size of memset() and strncpy() properly

dlt-test-stress-user.c
- Parameter d is duplicated

dlt_env_ll.c
- Parameter env is used before NULL check
- Remove redundant line

dlt-control-common.c
dlt_daemon_event_handler.c
- Do not use NULL variable to print log

dlt_config_file_parser.c
- Remove unnecessary loop

dlt_daemon_client.c
- Return error in NULL check

dlt_user.c
- Free allocated memory in error case

Related commit: 5c8f88d logstorage: fix compile error

Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/src/console/dlt-control-common.c b/src/console/dlt-control-common.c
index 150bd9a..dbb52b1 100644
--- a/src/console/dlt-control-common.c
+++ b/src/console/dlt-control-common.c
@@ -424,7 +424,7 @@ static int dlt_control_init_connection(DltClient *client, void *cb)
     int (*callback)(DltMessage *message, void *data) = cb;
 
     if (!cb || !client) {
-        pr_error("%s Invalid parameters (%p, %p)\n", __func__, client, cb);
+        pr_error("%s: Invalid parameters\n", __func__);
         return -1;
     }
 
@@ -541,7 +541,7 @@ int dlt_control_send_message(DltControlMsgBody *body, int timeout)
     DltMessage *msg = NULL;
 
     if (!body) {
-        pr_error("Invalid input (%p).\n", body);
+        pr_error("%s: Invalid input.\n", __func__);
         return -1;
     }
 
@@ -601,7 +601,7 @@ int dlt_control_init(int (*response_analyzer)(char *, void *, int),
                      int verbosity)
 {
     if (!response_analyzer || !ecuid) {
-        pr_error("Invalid input (%p %p).\n", response_analyzer, ecuid);
+        pr_error("%s: Invalid input.\n", __func__);
         return -1;
     }