Add support for logging with VSOCK (#255)

For more information about VSOCK, see "man vsock"
( https://man7.org/linux/man-pages/man7/vsock.7.html ).

Makes it possible for processes in a virtual machine to log directly in
DLT running on host without setting up a network connection between
guest and host. It is also probably more efficient. Have not done any
performance measurements (not main reason for patch), but no forwarding
is required as when running DLT in a multi-node setup.

When building dlt-daemon for host, WITH_DLT_DAEMON_VSOCK_IPC should be
enabled for daemon to listen on incoming VSOCK requests. Local
communication method between applications and daemon is still determined
with DLT_IPC. When building for guest, WITH_DLT_LIB_VSOCK_IPC should be
enabled and DLT_IPC will be ignored, which will make libdlt open a VSOCK
socket to the deamon for logging messages.

VSOCK can be tested without a virtual machine. Since VMADDR_CID_HOST is
used by libdlt when connecting, see vsock man page, clients can be run
on host to test VSOCK communication.

Some modifications has been done to be able to handle logging through
FIFO pipe and socket in the same build of dlt-daemon:

- dlt_receiver_init/free_unix_socket() is renamed to
  dlt_receiver_init/free_global_buffer() and used for FIFO as well.
  Also fixes memory leak since dlt_receiver_free_unix_socket() was used
  regardless of whether DLT_USE_UNIX_SOCKET was defined or not.

- Pass type to dlt_receiver_init() instead of dlt_receiver_receive().
  And remove preprocessor conditionals for handling
  DLT_CONNECTION_APP_MSG in dlt_daemon_process_user_messages(). Also
  fixes wrong enum type being passed to dlt_receiver_receive() in
  dlt_client.c (DltClient::mode was used as a DltReceiverType enum but
  it is a DltClientMode enum).

- Add a flag to DltDaemonApplication to indicate whether file descriptor
  is "owned" by the DltDaemonApplication or not. When
  dlt_daemon_application_add() is called due to message received on a
  socket, fd is passed as an argument (app does not own fd). For FIFO,
  a per application FIFO is opened (app owns the fd). Also fixes so that
  user handle is reset for both application and all its contexts when
  resetting any. Prevents fd from being used by accident after it has
  been closed.

dlt_mkdir_recursive() is moved to src/daemon since it is only used in
the daemon. Minimizes use of DLT_USE_UNIX_SOCKET_IPC.

Other bugfixes:

- Call DLT_SEM_FREE() if setting socket to O_NONBLOCK fails in
  src/lib/dlt_user.c:dlt_initialize_socket_connection().

- Close socket if dlt_receiver_init() fails in
  src/lib/dlt_user.c:dlt_initialize_socket_connection().

Signed-off-by: Martin Ejdestig <martin.ejdestig@volvocars.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/src/daemon/dlt-daemon.h b/src/daemon/dlt-daemon.h
index 31598bb..4095cf3 100644
--- a/src/daemon/dlt-daemon.h
+++ b/src/daemon/dlt-daemon.h
@@ -117,9 +117,9 @@ typedef struct
     unsigned int offlineLogstorageMaxCounter; /**< (int) Maximum offline logstorage file counter index until wraparound  */
     unsigned int offlineLogstorageMaxCounterIdx; /**< (int) String len of  offlineLogstorageMaxCounter*/
     unsigned int offlineLogstorageCacheSize; /**< Max cache size offline logstorage cache */
-#ifdef DLT_USE_UNIX_SOCKET_IPC
+#ifdef DLT_DAEMON_USE_UNIX_SOCKET_IPC
     char appSockPath[DLT_DAEMON_FLAG_MAX]; /**< Path to User socket */
-#else
+#else /* DLT_DAEMON_USE_FIFO_IPC */
     char userPipesDir[DLT_PATH_MAX]; /**< (String: Directory) directory where dltpipes reside (Default: /tmp/dltpipes) */
     char daemonFifoName[DLT_PATH_MAX]; /**< (String: Filename) name of local fifo (Default: /tmp/dlt) */
     char daemonFifoGroup[DLT_PATH_MAX]; /**< (String: Group name) Owner group of local fifo (Default: Primary Group) */
@@ -209,7 +209,7 @@ int dlt_daemon_process_sixty_s_timer(DltDaemon *daemon, DltDaemonLocal *daemon_l
 int dlt_daemon_process_systemd_timer(DltDaemon *daemon, DltDaemonLocal *daemon_local, DltReceiver *recv, int verbose);
 
 int dlt_daemon_process_control_connect(DltDaemon *daemon, DltDaemonLocal *daemon_local, DltReceiver *recv, int verbose);
-#ifdef DLT_USE_UNIX_SOCKET_IPC
+#if defined DLT_DAEMON_USE_UNIX_SOCKET_IPC || defined DLT_DAEMON_VSOCK_IPC_ENABLE
 int dlt_daemon_process_app_connect(DltDaemon *daemon, DltDaemonLocal *daemon_local, DltReceiver *recv, int verbose);
 #endif
 int dlt_daemon_process_control_messages(DltDaemon *daemon, DltDaemonLocal *daemon_local, DltReceiver *recv,