daemon: Remove bytes_sent

When it fails to send a log message to connected client, daemon
tries to store the remaining partial message to internal ring
buffer and send again later. When calculating the number of bytes
which were sent to client, it had a bug which it keeps on
incrementing instead of initializing the variable on every message,
which never reached to the condition mentioned above and had a
possibility to overflow and access invalid memory. On the other hand,
daemon doesn't need to store the unsent partial message, as the socket
to the client will be closed on failure and the sent partial message
will be dropped anyways.

This commit removes the lines where the daemon tries to store the
partial message to ring buffer. With this, variable bytes_sent is
now removed.

Related commit: 2262f8b Made socket send reliable

Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>

1 files changed, 1 insertions, 4 deletions

diff --git a/src/daemon/dlt_daemon_connection.c b/src/daemon/dlt_daemon_connection.c
index 2fe17c1..456a075 100644
--- a/src/daemon/dlt_daemon_connection.c
+++ b/src/daemon/dlt_daemon_connection.c
@@ -71,7 +71,6 @@ DLT_STATIC int dlt_connection_send(DltConnection *conn,
                                    size_t msg_size)
 {
     DltConnectionType type = DLT_CONNECTION_TYPE_MAX;
-    int bytes_sent = 0;
     int ret = 0;
 
     if ((conn != NULL) && (conn->receiver != NULL))
@@ -88,9 +87,7 @@ DLT_STATIC int dlt_connection_send(DltConnection *conn,
     case DLT_CONNECTION_CLIENT_MSG_TCP:
         ret = dlt_daemon_socket_sendreliable(conn->receiver->fd,
                                              msg,
-                                             msg_size,
-                                             &bytes_sent);
-        conn->receiver->bytes_sent += bytes_sent;
+                                             msg_size);
         return ret;
     default:
         return DLT_DAEMON_ERROR_UNKNOWN;