Correct sa findings

dlt_offline_logstorage.c
- Parameter to isdigit is not correct
- Handle the size of memset() and strncpy() properly

dlt-test-stress-user.c
- Parameter d is duplicated

dlt_env_ll.c
- Parameter env is used before NULL check
- Remove redundant line

dlt-control-common.c
dlt_daemon_event_handler.c
- Do not use NULL variable to print log

dlt_config_file_parser.c
- Remove unnecessary loop

dlt_daemon_client.c
- Return error in NULL check

dlt_user.c
- Free allocated memory in error case

Related commit: 5c8f88d logstorage: fix compile error

Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>

2 files changed, 4 insertions, 3 deletions

diff --git a/src/lib/dlt_env_ll.c b/src/lib/dlt_env_ll.c
index e2a9587..8770a02 100644
--- a/src/lib/dlt_env_ll.c
+++ b/src/lib/dlt_env_ll.c
@@ -86,7 +86,7 @@ int dlt_env_extract_id(char **const env, char *id)
 int dlt_env_helper_to_lower(char **const env, char *result, int const res_len)
 {
     int count = 0;
-    char ch = *(*env);
+    char ch;
 
     if (!env || !result)
         return -1;
@@ -94,7 +94,6 @@ int dlt_env_helper_to_lower(char **const env, char *result, int const res_len)
     if (!(*env))
         return -1;
 
-    count = 0;
     ch = *(*env);
 
     while (ch && (count < res_len - 1) && (ch != ';')) {
diff --git a/src/lib/dlt_user.c b/src/lib/dlt_user.c
index d603783..d040d38 100644
--- a/src/lib/dlt_user.c
+++ b/src/lib/dlt_user.c
@@ -3205,8 +3205,10 @@ DltReturnValue dlt_log_raw(DltContext *handle, DltLogLevelType loglevel, void *d
         return DLT_RETURN_WRONG_PARAMETER;
 
     if (dlt_user_log_write_start(handle, &log, loglevel) > 0) {
-        if ((ret = dlt_user_log_write_raw(&log, data, length)) < DLT_RETURN_OK)
+        if ((ret = dlt_user_log_write_raw(&log, data, length)) < DLT_RETURN_OK) {
+            dlt_user_free_buffer(&(log.buffer));
             return ret;
+        }
 
         if (dlt_user_log_write_finish(&log) < DLT_RETURN_OK)
             return DLT_RETURN_ERROR;