appended null termination to version string

adding closure of socket in syslog_thread and read_socket

fixed missing free of filepath in compressed file transfer

fixed missing closedir in added in send_one error case

fixed missing fclose of src_file in ferror case

dlt-daemon.c fixed missing fclose in ferror case

dlt_common.c using snprintf for filename instead sprintf in dlt_file_open

modified some magix numbers - replaced by limits.h values. added strncpy instead strcpy to make cp more safe. split up a function to avoid coverity complaint when computing size of a write buffer length

dlt_daemon_common: added strncpy instead strcpy to make cp more safe.

Fixes some more Coverity issues in dlt-daemon.c dlt_user.c dlt_common.c and dlt_offline_trace.c.

Conflicts:

	src/daemon/dlt-daemon.c
	src/lib/dlt_user.c

Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>

1 files changed, 5 insertions, 0 deletions

diff --git a/src/system/dlt-system-syslog.c b/src/system/dlt-system-syslog.c
index b07e6d6..c788d94 100644
--- a/src/system/dlt-system-syslog.c
+++ b/src/system/dlt-system-syslog.c
@@ -84,6 +84,7 @@ int init_socket(SyslogOptions opts)
 	{
 		DLT_LOG(syslogContext, DLT_LOG_FATAL,
 				DLT_STRING("Unable to bind socket for SYSLOG."));
+                close(sock);
 		return -1;
 	}
 
@@ -138,8 +139,12 @@ void syslog_thread(void *v_conf)
 	while(!threads.shutdown)
 	{
 		if(read_socket(sock) < 0)
+                {
+                        close(sock);
 			return;
+                }
 	}
+        close (sock);
 }
 
 void start_syslog(DltSystemConfiguration *conf)