summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Update status badges on README.mdstatus_badges_readme_mdmichael-methner2023-04-171-5/+2
| | | Removed deprecated LGTM, added CodeQL
* dlt-user: fix crash with certain strings (#463)v2.18.9Alexander Mohr2023-04-171-9/+9
| | | | | | make sure that a string with exactly UINT16_MAX bytes does not overflow the dlt buffer Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
* dlt_multiple_files: remove superfluous mode bits and add header file to ↵Minh Quang Luu2023-04-122-4/+3
| | | | | header list (#462) Signed-off-by: LUU QUANG MINH <Minh.LuuQuang@vn.bosch.com>
* Android: Add new feature in Android bp (#461)Minh Quang Luu2023-03-291-0/+2
| | | | | | Add required sources files to Android.bp Signed-off-by: LUU QUANG MINH <Minh.LuuQuang@vn.bosch.com> Co-authored-by: LUU QUANG MINH <Minh.LuuQuang@vn.bosch.com>
* cmake: remove duplicated option message (#454)Minh Quang Luu2023-03-221-1/+0
| | | Signed-off-by: LUU QUANG MINH <Minh.LuuQuang@vn.bosch.com>
* house-keeper: remove infinite wait (#438)Alexander Mohr2023-03-221-18/+44
| | | | | | | in case the house keeper thread does not start we should not wait indefinitely but abort the wait after a 10s Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
* dlt-logd-converter: Fix getting log level from log msg (#456)RobinChenJP2023-03-201-1/+1
| | | | | In AOSP, system/logging/liblog/logprint.cpp --> android_log_processLogBuffer: entry->priority = static_cast<android_LogPriority>(msg[0]) msg[0] is used to obtain the log level
* dlt-logd-converter: fixes android 12 compilation (#445)v2.18.9-alphasebastienr2023-03-142-5/+1
| | | | | | | | | | | | | | | | | | | * Since android 12 release (and the introduction of this commit https://chromium.googlesource.com/aosp/platform/system/ logging/+/b674866203f05957b2ac5db94c3c0fe3d1d36793), the define ANDROID_LOG_RDONLY and friends have been removed (see the commit for the explanation). Therefore, dlt-logd-converter can't compile anymore since this version. * ANDROID_LOG_RDONLY was a define on O_RDONLY. O_RDONLY is now used to allow the compilation on android 12 as well as previous versions * <log/logprint.h> include is removed because we aren't using any API from this file and moreover, this file shouldn't be included from vendor application (not part of public API) * Direct include on "system/core/include" inside Android.bp is removed because it was previously used to find <log/logprint.h>. This should be avoided. We should keep android build system providing right headers path for us :) Signed-off-by: Sébastien RAILLET <sebastien.raillet@gmail.com>
* logfile: exhance internal dlt logging by introducing size limits (#369)Daniel Weber2023-03-1016-508/+1247
| | | | | | | | | | | Enhance dlt logging such that multiple files are used as it is done for the offline traces. Add limit-specific config values for logging. For this purpose the pattern of index-based file names is used only. This approach of logging to multiple files and rotating in order to keep the limits ensures that dlt logs take care of available space on the underlying file system and do not grow infinitely. Signed-off-by: Daniel Weber <daniel.w.weber@daimler.com> Co-authored-by: Oleg Tropmann <oleg.tropmann@daimler.com>
* This changes a mispatch from fcb676a7 to install the udp binary correctly. ↵Stephen Smoogen2023-03-081-1/+1
| | | | | | (#449) Signed-off-by: Stephen Smoogen <ssmoogen@redhat.com> Co-authored-by: Stephen Smoogen <ssmoogen@redhat.com>
* Installs dlt.conf on android (#446)sebastienr2023-03-081-0/+9
| | | | | * Currently on android, there is no dlt-daemon configuration installed by default. This change allows to install the dlt.conf along with the dlt-daemon during compilation phase.
* Merge pull request #439 from alexmohr/add-socket-timeoutlvklevankhanh2023-02-281-0/+15
|\ | | | | dlt-connection: add socket timeout
| * dlt-connection: add socket timeoutAlexander Mohr2023-02-221-0/+15
| | | | | | | | | | | | | | | | in some scenarios a socket might block forever. This means dlt-daemon won't respond properly anymore. To fix this a timeout is added to the dlt-daemon socket connection. Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
* | Merge pull request #441 from lvklevankhanh/fix_memory_leaklvklevankhanh2023-02-091-0/+2
|\ \ | | | | | | Fix memory leak
| * | Fix memory leakLe Van Khanh2023-02-091-0/+2
|/ / | | | | | | | | | | Free the ecuid_conf in case of memory alllocated Signed-off-by: Le Van Khanh <Khanh.LeVan@vn.bosch.com>
* | Merge pull request #437 from michael-methner/masterlvklevankhanh2023-02-021-1/+1
|\ \ | |/ |/| Check for negative index in dlt_file_message
| * Check for negative index in dlt_file_messageMichael Methner2023-01-271-1/+1
| | | | | | | | | | | | Fixes #436 Signed-off-by: Michael Methner <mmethner@de.adit-jv.com>
* | dlt-user: fix potential non closed socket in init/free (#435)Alexander Mohr2023-01-201-4/+39
| | | | | | | | | | | | | | | | | | wait until the house keeper is up and running this makes sure dlt_init / dlt_free in close succession closes this thread properly. Otherwise we might keep the dlt socket open Check if the thread is running every 10ms Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
* | dlt-convert: Fix memory leak by calling dlt_file_free (#434)lvklevankhanh2023-01-201-0/+2
| | | | | | | | | | Free the index which already allocated memory in dlt_file_read phase Signed-off-by: Le Van Khanh <Khanh.LeVan@vn.bosch.com>
* | dlt-user: Fix crashes in dlt_free during dlt_init (#362)Alexander Mohr2023-01-112-83/+187
| | | | | | | | | | | | | | | | | | If dlt_free is called while dlt_init is running, the dlt-user library crashes because the init and free where not thread safe. This commit introduces a new field dlt_user_initialising which will prevent entering dlt_free while dlt_init is running. Correctness is ensured by a unit test Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
* | Update contacts and removed mailing lists (#431)michael-methner2023-01-101-5/+2
| |
* | Merge pull request #429 from andreirusu96/gateway_handling_improvementslvklevankhanh2023-01-071-7/+16
|\ \ | |/ |/| gateway: Fix Node handling and ECUid checks
| * gateway: Fix Node handling and ECUid checksAndrei-Mircea Rusu2022-12-131-7/+16
| | | | | | | | | | | | | | | | Reset Receiver at connection close to prevent corruption Prevent out of bounds reads Fix connection select when processing passive node messages Signed-off-by: Andrei-Mircea Rusu <andrei-mircea.rusu@continental-corporation.com>
* | Updates for Coding Styles (#425)Bui Nguyen Quoc Thanh2022-12-144-2739/+133
|/ | | | | | | - Remove uncrustify - Use clang-format and pre-commit hooks script - Update README accordingly Signed-off-by: Bui Nguyen Quoc Thanh <thanh.buinguyenquoc@vn.bosch.com>
* filetransfer: fix filesize divisible by blocksize case (#383)Daniel Weber2022-12-011-0/+7
| | | | | | | If the file size is divisible by the package size don't send one empty FLDA. Also we send the correct number of FLDAs too. Signed-off-by: Daniel Weber <daniel.w.weber@mercedes-benz.com>
* client: Fix Get Log Info response conversion method (#422)Andrei Rusu2022-11-302-3/+4
| | | | Signed-off-by: Andrei-Mircea Rusu <andrei-mircea.rusu@continental-corporation.com>
* cmake: network trace enable toggle (#424)Daniel Weber2022-11-301-6/+12
| | | | | Add cmake toggle to disable network trace. Signed-off-by: Daniel Weber <daniel.w.weber@mercedes-benz.com>
* dlt-system: Fix buffer overflow detection on 32bit targets (#398)Sandy2022-10-261-3/+4
| | | | | | | | | | | | | * dlt-system: Fix buffer overflow detection on 32bit targets On 32bit target, dlt-system will termiated with error: dlt-system: *** buffer overflow detected ***: terminated Signed-off-by: Changqing Li <changqing.li@windriver.com> * Fixed newline at EOF Signed-off-by: Changqing Li <changqing.li@windriver.com> Co-authored-by: michael-methner <mmethner@de.adit-jv.com>
* dlt-receive: set host interface and allow multiple udp multicast addresses ↵Bui Nguyen Quoc Thanh2022-10-262-36/+60
| | | | | | | | | | | | | | | | (#420) * dlt-receive: Allow listening to multiple udp multicast addresses Multiple udp multicast addresses can now be specified, e.g: dlt-receive -u 224.255.1.1 225.255.1.1 Signed-off-by: Alexander Irion <alexander_irion@mentor.com> * dlt-receive: Add option to set host interface address Signed-off-by: Alexander Irion <alexander_irion@mentor.com> Signed-off-by: Alexander Irion <alexander.irion@partner.bmw.de> Co-authored-by: Alexander Irion <alexander_irion@mentor.com>
* Fix for Resource and Memory Leak (#418)lti9hc2022-10-266-21/+39
| | | | | | | | | | | dlt_daemon_client.c Adding NULL check for tok dlt_daemon_offline_logstorage.c : Adding NULL check for application dlt_user.c : Fix for Memory Leak dlt-daemon.c : Fix for Resource Leak dlt_config_file_parser.c : Add termination character at the end of string dlt_offline_trace.c : Fix for Resource Leak Signed-off-by: Mvaradaraj2 manoj.varadaraj2@harman.com Co-authored-by: Le Tin <tin.le@vn.bosch.com>
* dlt_daemon_client: Fix Control Msg ECUId comparison with active Gateway (#414)Andrei Rusu2022-10-131-1/+1
| | | | | | Signed-off-by: Andrei-Mircea Rusu <andrei-mircea.rusu@continental-corporation.com> Signed-off-by: Andrei-Mircea Rusu <andrei-mircea.rusu@continental-corporation.com> Co-authored-by: Andrei-Mircea Rusu <andrei-mircea.rusu@continental-corporation.com>
* Avoid memory corruption behind buffer wp in function ↵michael-methner2022-10-115-13/+131
| | | | | | | | | | | | dlt_getloginfo_conv_ascii_to_id (#411) * Avoid memory corruption behind buffer wp in function dlt_getloginfo_conv_ascii_to_id - Introduced new function dlt_getloginfo_conv_ascii_to_string for '\0' terminated strings - Avoid printing garbage characters in dlt-control after APID and CTID (which are not null terminated anymore) - Added unit test for dlt_client_parse_get_log_info_resp_text and dlt_getloginfo_conv_ascii_to_string - Use dlt_getloginfo_conv_ascii_to_string to get '\0' terminated for app_description and context_description Signed-off-by: Michael Methner <mmethner@de.adit-jv.com>
* dlt_common: change output of message for log initialization (#412)lti9hc2022-10-061-1/+1
| | | | | | | Switch dlt_vlog() to dlt_user_printf(), the message could be observed in case the log can not be written in file Signed-off-by: Le Tin <tin.le@vn.bosch.com>
* internal-logging: Fix issues with file logging (#378)Alexander Mohr2022-10-055-7/+35
| | | | | | | | | | | | | This commit fixes the following issues if access to the internal log file is not possible (logging_mode = DLT_LOG_TO_FILE) * dlt_log_free tried to call fclose on a nullptr Added a nullcheck for this * Access to log file might be denied but access to logs is still wanted Add a new CMake option WITH_DLT_FILE_LOGGING_SYSLOG_FALLBACK If this is set to ON and the logging moe is set to file, the dlt-daemon will fall back to syslog if opening the internal log file failed Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
* systemd: add support for socket activation via systemd (#401)Alexander Mohr2022-10-055-1/+77
| | | | | | | | | | | dlt-daemon now support activation via systemd socket. This allows dlt-daemon to be started as soon as an application is requesting access to the dlt socket. This commits implements opening the socket only when UNIX_SOCKET is used for IPC Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com> Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
* Update maintainer (#410)Bui Nguyen Quoc Thanh2022-10-051-1/+1
| | | | | | | Michael Methner is taking over the role from Saya Sugiura Signed-off-by: Bui Nguyen Quoc Thanh <thanh.buinguyenquoc@vn.bosch.com> Signed-off-by: Bui Nguyen Quoc Thanh <thanh.buinguyenquoc@vn.bosch.com>
* dlt_daemon_client: Fix change loglevel of application (#408)lti9hc2022-09-281-4/+4
| | | | | | | | | - Type of return value of strncmp() is int - Should replace int8_t by int to avoid error when casting Signed-off-by: Le Tin <tin.le@vn.bosch.com> Signed-off-by: Le Tin <tin.le@vn.bosch.com> Co-authored-by: Le Tin <tin.le@vn.bosch.com>
* dlt_client:Block in connect() (#409)Bui Nguyen Quoc Thanh2022-09-281-6/+66
| | | | | | | | | Connect TCP socket with non-blocking socket Check errno and getsockopt to guarantee that the socket connection is established successfully Signed-off-by: Le Tin <tin.le@vn.bosch.com> Signed-off-by: Le Tin <tin.le@vn.bosch.com>
* dlt-gateway: Fix crash on invalid ip (#381)Alexander Mohr2022-09-282-1/+5
| | | | | | | | * dlt-gateway crashed when an invalid ip address was configured as a null pointer was used for strdup Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
* Update dlt_for_developers.md (#405)Bruno Marques2022-09-281-1/+2
| | | Fix error in suggested best-practice code snippet
* logstorage: Truncate ECUid in Logstorage filter to prevent crash (#402)Andrei Rusu2022-09-211-4/+4
| | | | | | Signed-off-by: Andrei-Mircea Rusu <andrei-mircea.rusu@continental-corporation.com> Signed-off-by: Andrei-Mircea Rusu <andrei-mircea.rusu@continental-corporation.com> Co-authored-by: Andrei-Mircea Rusu <andrei-mircea.rusu@continental-corporation.com>
* dlt_common.c: Change default logging_mode (#406)wusto2022-09-211-1/+1
| | | | | | | | | | | | | | | | | Up to now the default for logging is stdout (DLT_LOG_TO_CONSOLE). Scenario: program_a arg1 | dd of=/my-beauty-case If program_a wants to log to dlt, but it fails to connect to the socket: socket /run/dlt-files/dlt cannot be opened, error:Resource temporarily unavailable. Retrying later... The error will be logged by default to stdout leading in the best case to an error and in the worst to damaged partitions. To solve this log to STDERR (DLT_LOG_TO_STDERR) by default. Co-authored-by: Tobias Kaufmann <Tobias.KA.Kaufmann@bmw.de>
* dlt-daemon-connection: Start up even if not all bindings are valid (#380)Alexander Mohr2022-08-101-4/+10
| | | | | | | | dlt-daemon allows configuration of multiple addresses. Before this commit the daemon exits when the first binding fails. This commit changes the behavior so that the daemon only exits if none of the configured addresses can be opened. Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
* enforce-trace-limit: ContextLogLevel is now enforced in the daemon (#382)Alexander Mohr2022-08-102-4/+23
| | | | | | if an application sends a message with a level below context level and the level enforcement is on, the message will be dropped Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
* automotive-dlt.pc: add the path to find the static library (#387)Charles Chan2022-07-181-1/+1
| | | Make the user find the static library by pkg-config, when BUILD_SHARED_LIBS=OFF.
* systemd: install adaptor-udp service for adaptor=on (#393)Daniel Weber2022-07-131-1/+1
| | | | | | | Re-add install adaptor-udp service for WITH_DLT_ADAPTOR=ON. Signed-off-by: Daniel Weber <daniel.w.weber@mercedes-benz.com> Co-authored-by: Daniel Weber <daniel.w.weber@mercedes-benz.com>
* Fix handle returned value (#384)Bui Nguyen Quoc Thanh2022-07-073-25/+59
| | | | | | | | | | | | | | | | * common: Handle returned value - The returned value of supporting APIs should be checked correctly. - In case of extended header, the buffer of header must be checked before proceeding further. Signed-off-by: Bui Nguyen Quoc Thanh <thanh.buinguyenquoc@vn.bosch.com> * console: Handle returned value In case of parsing dlt file, the failed messages should be skipped by evaluating returned value Signed-off-by: Bui Nguyen Quoc Thanh <thanh.buinguyenquoc@vn.bosch.com>
* README: Update link to github actions (#392)Saya Sugiura2022-06-291-1/+1
| | | | | Set link to github actions in COVESA/dlt-daemon. Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* Update for CI (#389)Bui Nguyen Quoc Thanh2022-06-293-67/+40
| | | | | | | - Add ctest in Actions - Remove travis ci - Update Build Status in README.md Signed-off-by: Bui Nguyen Quoc Thanh <thanh.buinguyenquoc@vn.bosch.com>
* Fix a double-free bug.Safe-BCY2022-05-111-0/+1
| | | | | | | | In the dlt_config_file_set_section function of dlt_config_file_parser.c: s-name is not set to null after free. It will be freed again in the dlt_config_file_release function. Signed-off-by: Zhongyang.Bao <Zhongyang.Bao@zeekrlife.com>