summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* Logstorage: Correct behavior in sync message cacheBui Nguyen Quoc Thanh2019-06-181-11/+28
| | | | | | | | If the message size is equal to remaining size of cache, it is still written into cache. And then whole cache data must be synchronized to file according to strategy. Signed-off-by: Bui Nguyen Quoc Thanh <Thanh.BuiNguyenQuoc@vn.bosch.com>
* Logstorage: Sync behavior bug fixSaya Sugiura2019-06-187-516/+327
| | | | | | | | | | | | | | | This commit fixes couple of unexpected behavior on Logstorage sync behavior. - A log file is created only if necessary to avoid creating an empty log file. - The cache is synced with the condition: 1) When the ring buffer is not wrapped around, the cache is synced from last sync offset to current offset 2) When the ring buffer is wrapped around for first time and current offset is smaller than last sync offset, the cache is synced from last sync offset to end sync offset, and then from beginning to current offset 3) Otherwise, the cache is synced from offset where the log message starts to end sync offset, and then from beginning to current offset Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* Logstorage: Fix write msg cacheSaya Sugiura2019-06-181-6/+2
| | | | | | | When the message is just fitting to the remaining cache, it is ignored and goes to the head. This commit fixes to add the message to the end. Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* Update ReleaseNotes and version to v2.18.3v2.18.3Saya Sugiura2019-06-112-2/+25
| | | | Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* Travis CI: Run unit test (#132)Bui Nguyen Quoc Thanh2019-06-112-1/+70
| | | | | | | | To do more testing on Travis CI, a script is added to run all unit tests which exists under tests directory. In case there is any failure in gtest suite, Travis testing script will exit immediately. Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com> Signed-off-by: Bui Nguyen Quoc Thanh <thanh.buinguyenquoc@vn.bosch.com>
* libdlt: Fix compiler warningsSaya Sugiura2019-06-111-0/+2
| | | | | | Fix the warning from -Wmaybe-uninitialized. Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* Unit test: Fix compiler warningsSaya Sugiura2019-06-111-40/+97
| | | | | | Fix the warnings from -Wmissing-field-initializers. Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* Unit test fixBui Nguyen Quoc Thanh2019-06-102-1/+28
| | | | | | | | | | - Initialize variables in gtest_dlt_daemon_gateway.cpp to avoid unexpected error - Support FIFO mode in connectServer() in gtest_dlt_daemon_offline_log - Do not fork a child process in gtest_dlt_daemon_offline_log if DLT_IPC is not UNIX_SOCKET Signed-off-by: Bui Nguyen Quoc Thanh <thanh.buinguyenquoc@vn.bosch.com>
* Do not install systemd service files for binaries that are not built (#129)Martin Ejdestig2019-05-291-25/+25
| | | | | | | | | | | | | | * Do not install systemd service files for binaries that are not built Noticed that dlt-system.service unconditionally failed since the binary was missing when building with a default configuration after an upgrade from 2.17.0 to 2.18.1. WITH_DLT_SYSTEM default changed to OFF in 1b3c8b3d10fbc9a8dd9c717a939babd901b0b243 . Fix by only installing dlt-system.service if dlt-system is built and do the same for other binaries that have a service file. Also install() is moved to if() blocks used for configure_file(). Signed-off-by: Martin Ejdestig <mejdestig@luxoft.com>
* lib: unlock buffer on terminationS. Hameed2019-05-241-24/+27
| | | | | | | | | | | | | | | | | | | | | | | | | Sometimes it happens that internal threads present in DLT library are cancelled with one of the task still holding the mutex, then the main task gets locked forever. The following changes have been made: - Cleanup on thread cancellation with pthread_cleanup_push() is introduced - Locking on the message queue lock and subsequent signaling in dlt_stop_threads is only done if the segmented thread was created. - It is unnecessary to have a robust mutex for the message queue. Replace it with a normal mutex and remove EOWNERDEAD logic. Add a pthread_cancel handler to the segmented thread that might hold the message queue mutex. - Message queue mutex is statically initialized Signed-off-by: S. Hameed <shameed@jp.adit-jv.com> Signed-off-by: Jeevan Ramakant Nagvekar <jeevan.nagvekar1@wipro.com> Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* dlt-receive: Fix crash without argumentsVo Trung Chi2019-05-061-4/+6
| | | | | | Rootcause: Free uninitialize memory. Signed-off-by: Vo Trung Chi <Chi.VoTrung@vn.bosch.com>
* dlt-control: Bug fix for broken get log infoRavi Sankar P2019-05-061-1/+1
| | | | | | | | strtol converts extra data in the array, so it leads to data crash. It is now fixed to fill the last byte of the array with null character once data copy complete and before convert. Signed-off-by: Ravi Sankar P <ponnurangamravi.sankar@in.bosch.com>
* Logging: Error message modificationManikandanC2019-05-061-8/+16
| | | | | | | Error message is printed only in error case and not in case of expected failure. Signed-off-by: ManikandanC <Manikandan.Chockalingam@in.bosch.com>
* dlt-daemon: fix internal logging to file after daemonizeChristoph Lipka2019-05-062-1/+6
| | | | Signed-off-by: Christoph Lipka <clipka@de.adit-jv.com>
* Offline logstorage: Fix storage handle NULL check during cleanupS. Hameed2019-05-061-1/+1
| | | | Signed-off-by: S. Hameed <shameed@jp.adit-jv.com>
* Fix compiler warningsSimon Herkenhoff2019-05-0611-36/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix compiler warnings about socket usage Correct the data types used for the socket declaration. We use AF_UNIX sockets so we use struct sockaddr_un, but we need to cast to struct sockaddr for the socket API. Fix compiler warnings about sign-compare Fix two occurences of signed - unsigned comparison by casting the values accordingly. Note that the cast is legal as the first parts of both conditional statements make sure the value is not negative before casting to unsigned. While at it, add strtol error checking. Fix compiler warnings about string functions Add string.h to src/daemon/dlt_daemon_unix_socket.c, because it was unaware of memcpy and strerror. While at it, change unsafe use of sprintf to proper dlt_vlog and remove the char buffer. Fix compiler warnings about unused-* Fix two unused-variable and one unused-parameter warning. While at it, change the #ifdef to not run into an empty block. Simply reverse the condition and enclose the complete else with the #ifdef. POSIX: Use memset instead of bzero "The bzero() function is deprecated (marked as LEGACY in POSIX.1-2001); use memset(3) in new programs." Use memset instead of bzero and remove any occurrence from DLT. Include of header "strings.h" that has bzero is also removed. Signed-off-by: Simon Herkenhoff <sherkenhoff@jp.adit-jv.com> Signed-off-by: ManikandanC <Manikandan.Chockalingam@in.bosch.com> Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
* POSIX: Replace usleep with nanosleepSaya Sugiura2019-05-0619-42/+130
| | | | Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* unix socket: IPC code isolationChristoph Lipka2019-05-065-16/+16
| | | | | Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com> Signed-off-by: Vo Trung Chi <Chi.VoTrung@vn.bosch.com>
* lib: daemon: Fix sem lock potential issueSaya Sugiura2019-04-242-4/+11
| | | | | | | | sem_wait may return an error if a signal is received while waiting for the lock,and therefore not take the lock before returning. Changed to have a while loop. Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* socket: Remove unnecessary headerSaya Sugiura2019-04-241-1/+0
| | | | | | | | Including net/if.h leads to duplicate definition of DLT_RAW. However the header itself is not required in dlt_daemon_socket.c. So it is now removed from the file. Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* dlt-daemon: unlink application socketS. Hameed2019-04-241-0/+5
| | | | Signed-off-by: S. Hameed <shameed@jp.adit-jv.com>
* ipc: close socket if connect failedChristoph Lipka2019-04-241-0/+2
| | | | Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
* Update ReleaseNotes and version to v2.18.2v2.18.2Saya Sugiura2019-04-162-2/+25
| | | | Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* doc: Update doc/CMakeList.txt after cleanup documentation (#111) (#117)thanhbnq2019-04-169-207/+190
| | | | | | | | | | * doc: Update after cleanup documentation - Add ascii_doc check - Spaces instead of tabs in doc/CMakeList.txt - Change style in markdown files to avoid error while converting from md to html - Since manpages are generated by pandoc, "doc-man" part is removed from doc/CMakeList.txt Signed-off-by: thanhbnq <thanh.buinguyenquoc@vn.bosch.vn>
* Size of Resend buffer less than or equal to DLT_USER_BUF_MAX_SIZE res… (#116)kundatipradeep2019-04-151-1/+4
| | | | | | | * Size of Resend buffer less than or equal to DLT_USER_BUF_MAX_SIZE results in Memory corruption. As older version of DLT DLT_USER_RESENDBUF_MAX_SIZE is [DLT_USER_BUF_MAX_SIZE + 100] which contains space for extra headers, where as in DLT 2.18 the resend buffer is bound to DLT_USER_BUF_MAX_SIZE which results in memory corruption in dlt_buffer_read_block when the size of the data is more than DLT_USER_BUF_MAX_SIZE. Reason for not using "DLT_USER_RESENDBUF_MAX_SIZE" during dynamic memory allocation of resend buffer is as user has got the feasibility to alter the DLT_USER_BUF_MAX_SIZE using the environmental variables the resend buffer in any scenario to be greater then dlt_user.log_buf_len to accommodate the extra headers.
* Fixed memory leak when receiving network traces of 0xFFFF lengthjiripopek2019-04-112-3/+5
| | | | | | | | 0xFFFF was used as a magic number in the length field of a network message in order to trigger a resend. DLT library will now use the nw_trace_type field and a custom type to do this, thus assuring no external client of the library can reach this value(DLT_NW_TRACE_RESEND).
* Contact information update (#118)Saya Sugiura2019-04-101-2/+2
| | | | | | | The maintainer role is now handed over to Saya Sugiura and Quynh Le Hoang Ngoc. Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* lib: Add mq_close/mq_unlink conditionsSaya Sugiura2019-03-271-5/+12
| | | | | | | | | | Even if network trace is not used in the application, the library will call mq_close() and mq_unlink() to segmented queue handles and queue names, which triggers unnecessary close(). It is now modified to call mq_close() and mq_unlink() only when network trace is initialized. Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* doc: Do not allow DLT usage in forked child (#95)Saya Sugiura2019-03-262-4/+4
| | | | | | | | Update the documents to adapt to behavior change of forked child. Relates to following commit: 18321f3 libdlt: Do not allow DLT usage in forked child (#95) Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* doc: Raise an awareness of log level syncBui Nguyen Quoc Thanh2019-03-261-0/+2
| | | | | | | Raise an awareness of log level synchronization between DLT Daemon and application after registrations. Signed-off-by: Bui Nguyen Quoc Thanh <thanh.buinguyenquoc@vn.bosch.com>
* dlt_offline_logstorage: fix multiple file creation error (#85, #94)Vo Trung Chi2019-03-255-175/+261
| | | | | | | | | | | | | | | | | | Rootcause: The dlt-daemon rotates files for each key, but not for each [FILTER] because dlt-daemon creates the DltLogStorageFilterConfig for each key (CTXT: or APPID: or APPID:CTXTID) then added to the DltLogStorageFilterList. And each DltLogStorageFilterConfig has it's own records (The list of files that was recorded in the offline logstorage directory), that's why one [FILTER] might be has multiple records and then its lead to the problem. Solution: Instead of creating the DltLogStorageFilterConfig for each key, dlt-daemon will create the DltLogStorageFilterConfig for each [FILTER] and DltLogStorageFilterConfig has an information of all the keys in this [FILTER]. Signed-off-by: Vo Trung Chi <Chi.VoTrung@vn.bosch.com>
* doc: Fix PANDOC_TOOL conditionSaya Sugiura2019-03-141-2/+2
| | | | | | | doc/CMakeLists.txt had a wrong condition to check whether PANDOC_TOOL was found. Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* Travis CI: Fix link in README.md (#106, #108)Saya Sugiura2019-03-131-2/+2
| | | | | | Travis CI is now set up for GENIVI repository. Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>
* doc: Move all man pages to markdown files (#102)v2.18.1Christoph Lipka2019-02-1239-4067/+1752
| | | | All manpages have been removed, because they will be autogenerated from markdown files using pandoc.
* Fix linking problem with tests when systemd enabled (#103)Jiri Popek2019-02-071-5/+5
| | | Change-Id: Ide7c91a9f3a182c4bc2f91613874b0ef3feca648
* libdlt: Do not allow DLT usage in forked child (#95)Simon Herkenhoff2019-02-042-42/+74
| | | | | | | | | | | | | DLT shall not be used in a forked child until a variant of exec() is called, because DLT is using non async-signal-safe functions. The forking process can continue to use libdlt's logging facilities, but any attempt to use libdlt from the forked child will be denied. The fork-handler test is updated to reflect this by trying to log from the forked child which will fail. The fork then calls exec and runs another application that can continue to use DLT. Signed-off-by: Simon Herkenhoff <sherkenhoff@jp.adit-jv.com>
* Travis CI: build with systemd enabled (#97)Jiri Popek2019-02-022-1/+8
| | | | | | * Travis CI: build with systemd enabled * fix the 'sd_booted' linker issue
* Make dlt-convert more responsive when watching a fileAigars Mahinovs2019-02-021-1/+1
|
* Travis CI: fix - add new line to .travis.ymljiripopek2019-01-211-1/+1
|
* Build and test status addedJiri Popek2019-01-211-0/+2
|
* Add the Travis CI scriptJiri Popek2019-01-211-0/+13
|
* Update ReleaseNotes and version to v2.18.0v2.18.0Christoph Lipka2018-12-212-2/+65
| | | | Signed-off-by: Christoph Lipka <clipka@de.adit-jv.com>
* fix broken/missing links in documentationChristoph Lipka2018-12-212-1/+3
| | | | Signed-off-by: Christoph Lipka <clipka@de.adit-jv.com>
* CMake: Set default configurationChristoph Lipka2018-12-212-12/+12
| | | | Signed-off-by: Christoph Lipka <clipka@de.adit-jv.com>
* Code beautification using uncrustifyChristoph Lipka2018-12-21131-22766/+23502
| | | | Signed-off-by: Christoph Lipka <clipka@de.adit-jv.com>
* Documentation updateChristoph Lipka2018-12-2112-373/+1042
| | | | | Signed-off-by: Manikandan C <mchockalingam@de.adit-jv.com> Signed-off-by: Christoph Lipka <clipka@de.adit-jv.com>
* dlt-daemon: Output current number of connections as defaultYusuke Sato2018-12-211-15/+18
| | | | | | | | | | In previous, number of connections was output only if verbose mode in dlt.conf was enabled. This information is basically useful and is not output frequently. Therefore number of connections information is made to output as default when new connection is established or the connection is lost. Signed-off-by: Yusuke Sato <yusuke-sato@apn.alpine.co.jp>
* Remove unnecessary reference to zlib in .pc fileNguyen Dinh Thi2018-12-212-1/+4
| | | | Signed-off-by: Nguyen Dinh Thi <Thi.NguyenDinh@vn.bosch.com>
* Cleanup of unit test fixesManikandan C2018-12-2115-132/+130
| | | | Signed-off-by: Manikandan C <mchockalingam@de.adit-jv.com>
* gtest: Modification to offline logstorageSaya Sugiura2018-12-211-6/+12
| | | | | | | | - Change the name of test case from hash to list - Add file_name definition in the test case which calls dlt_logstorage_list_add() Signed-off-by: Saya Sugiura <ssugiura@jp.adit-jv.com>