| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* dlt_common: Fix resource leak
Close the file before returning from function.
Signed-off-by: Gordan Markuš <gordan.markus@pelagicore.com>
* dlt-kpi-process: Fix memory leak
Signed-off-by: Gordan Markuš <gordan.markus@pelagicore.com>
* dlt-kpi-options: Clean up resources on malloc fail
Signed-off-by: Gordan Markuš <gordan.markus@pelagicore.com>
|
|
|
|
| |
character from merge - +
|
|
|
|
|
|
|
|
|
|
|
|
| |
- When dlt_daemon_user_send_log_level() called in
dlt_daemon_process_user_message_register_context() fails -1 was returned
which caused dlt_daemon_process_user_messages() to stop processing
receiver buffer. Remaining data was stuck until new data arrived over
FIFO.
- Make debug output of dlt_daemon_user_send_log_level() more
verbose.
Signed-off-by: Lutz Helwing <lutz_helwing@mentor.com>
|
|
|
|
|
| |
(#19)
Signed-off-by: Pierre N <pierreN@users.noreply.github.com>
|
|
|
|
|
|
|
|
|
| |
By enabling the WITH_SYSTEMD and WITH_DLT_UNIT_TESTS cmake flags
the build will fail with an error due to a linking issue:
../src/daemon/libdlt_daemon.so: undefined reference to `sd_booted'
collect2: error: ld returned 1 exit status
Signed-off-by: Gordan Markuš <gordan.markus@pelagicore.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Update dlt-kpi-process.c
Added input param checking and added return value in non-void functions.
* Update dlt-kpi.c
Added Input param checking and added return values in non-void functions.
* Input parameter check and Error msg modification
Added null pointer checking
Added input parameter checking
Added return values in non-void functions
Added proper error message for debugging purpose
Signed-off-by: amberbhardwaj <amber.bhardwaj10@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
In function ‘daemonize’:
dlt-daemon/src/system/dlt-system-process-handling.c:84:5: warning: this ‘for’ clause does not guard... [-Wmisleading-indentation]
for(i = getdtablesize(); i >= 0; i--)
^~~
dlt-daemon/src/system/dlt-system-process-handling.c:87:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘for’
int fd = open("/dev/null",O_RDWR);
^~~
Singed-off-by: Gordan Markuš <gordan.markus@pelagicore.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
dlt-daemon/src/daemon/dlt_daemon_event_handler.c: In function ‘dlt_daemon_handle_event’:
dlt-daemon/src/daemon/dlt_daemon_event_handler.c:131:30: waring: cast from pointer to integer of different size [-Wpointer-to-int-cast]
DltConnectionId id = (DltConnectionId)ev->data.ptr;
^
dlt-daemon/src/daemon/dlt_daemon_event_handler.c: In function ‘dlt_connection_check_activate’:
dlt-daemon/src/daemon/dlt_daemon_event_handler.c:381:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
ev.data.ptr = (void *)con->id;
^
Signed-off-by: Gordan Markuš <gordan.markus@pelagicore.com>
|
|
|
|
|
|
|
|
|
|
|
| |
input (#9)
* dlt-adaptor-udp, dlt-adaptor-stdin: implement get of verbosity level from input, defaulting to INFO when
wrong type or none is provided
Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
* Fix minor typo (from gunnarx)
|
|\
| |
| | |
Added Description in dlt-system.conf
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Added additional information about how to enable syslog feature properly.
If still facing issue while capturing syslogs through client (e.g. dlt_viewer) after following given steps then install listed packages:
build-essential
build-essential checkinstall
pkg-config libsystemd-journal-dev
Note:
It's is a known issue when you try to capture syslog via dlt_viewer then syslogs wouldn't come in dlt_viewer because of improper configuration (won't route the log to port 47111) of dlt-system.
|
|\ \
| | |
| | | |
dlt-client: fix dlt_client_cleanup memory handling
|
| |/
| |
| |
| |
| |
| |
| | |
Setter function introduced for seting up string parameters which are
free'd in dlt_client_cleanup
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|\ \
| | |
| | | |
CMake Option: Trigger segmentation fault in case of FATAL log
|
| |/
| |
| |
| |
| |
| |
| |
| | |
When the user library receives a log with log level DLT_LOG_FATAL it
triggers a segmentation fault to provide information to the developer
via tools like coredump.
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In dlt_daemon_send_all_multiple, if the connection was broken, we closed
it before getting the next available connection. This must be avoided by
having a temporary next pointer.
The same kind of problem is valid for pointers coming from the epoll
interface. The kernel can provide back connection pointer that are not
valid any longer. Therefore, we need to use an ID instead of the pointer
value to retrieve the connections.
Signed-off-by: Frederic Berat <fberat@de.adit-jv.com>
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|/
|
|
|
|
|
|
|
| |
It might happen that an event is part of the epoll event queue that
belongs to a connection which was destroyed before the event is handled.
Due to this, the event handling main loop might stop and the daemon
exits. This misbehavior is fixed with this patch.
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|
|
|
| |
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|
|
|
|
|
| |
Unit tests for DLT Daemon connection and event handling
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|
|
|
|
|
| |
Unit test for DLT MultiNode extension
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|
|
|
|
|
|
| |
Remove malloc assert in inappropriate location and add error logs in case of
failures.
Signed-off-by: Manikandan C <Manikandan.Chockalingam@in.bosch.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds environment variables to configure user library
ringbuffer and step size.
The following variables can be set:
DLT_USER_BUFFER_MIN - for minimal size
DLT_USER_BUFFER_MAX - for maximal size
DLT_USER_BUFFER_STEP - for step size
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|
|
|
|
|
|
|
| |
The original implementation result in a compile error when DLT_PTR is used with
other macros like DLT_STRING.
This patch overcomes that problem.
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|
|
|
| |
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|
|
|
| |
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On context and application registration, the data needs to be read in 2
parts. If the first part was at the end of the receiver buffer, it was
wrongly removed whereas the complete data is not full received and
therefore interpretable. This has to be fixed by not removing the data
before everything is checked.
Thus, while readjusting the buffer to the first found header, the offset
was not properly updated.
Signed-off-by: Frederic Berat <fberat@de.adit-jv.com>
Process User Messages: Fix buffer handling
In case application and context registration the buffer need to be read
two times. But before removing the data, the data need to be readjusted
to its origin. This was missing in a previous fix.
Furthermore, in case of corrupted description field, applications and
contexts will be registered anyway with the dummy description "Unknown".
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|
|
|
| |
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|
|
|
|
|
| |
This change is done to remove compiler warnings.
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|
|
|
| |
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
|
|
|
|
|
|
|
|
| |
Currently, allocated memory for context description is not freed in dlt_free().
free() for each member variables of dlt_user.dlt_ll_ts[i] is added in the for block in dlt_free().
Signed-off-by: Yusuke Sato <yusuke-sato@apn.alpine.co.jp>
Change-Id: I52a81cf2918cb0014fdcfc666cb8bb93ca7cb525
|
|
|
|
|
|
|
|
|
|
|
| |
ECU ID that is not default value
dlt-daemon overwrites ECU ID even if user log message already has the ECU ID that is not default value.
This phenomenon happens when application uses dlt_forward_msg().
Therefore, dlt-daemon is modified not to overwrite ECU ID if log message has already has the ECU ID.
Signed-off-by: Yusuke Sato <yusuke-sato@apn.alpine.co.jp>
Change-Id: Icbc6304e5571242bf75ff0d32cbe4b004f1d7f9d
|
|
|
|
|
|
|
|
|
|
| |
registration
Option of get log info response during context registration was fixed to 7.
This modification enables to change that option.
Signed-off-by: Yusuke Sato <yusuke-sato@apn.alpine.co.jp>
Change-Id: Ia75f15cdb33e0bffd77c5ba71a1960e820714e61
|
|
|
|
|
|
|
| |
Configuration of daemon FIFO (default: /tmp/dlt) size is added to dlt.conf.
Signed-off-by: Yusuke Sato <yusuke-sato@apn.alpine.co.jp>
Change-Id: I05cc56b9a05e4c3a0a1af49c374f35ae10f4674d
|
|
|
|
|
|
|
|
|
|
| |
user buffer
Handle of /tmp/dlt cannot be reset if dlt-daemon is killed during output user buffer because dlt_user_log_resend_buffer() never returns DLT_RETURN_PIPE_ERROR.
Return value of dlt_user_log_resend_buffer() is modified to pass return value of dlt_user_log_out3() without change.
Signed-off-by: Yusuke Sato <yusuke-sato@apn.alpine.co.jp>
Change-Id: I506103ebebcdb3c145d1f0719a3c8caffc8d89c1
|
|
|
|
|
|
|
| |
Output debug log: File name contained in inotify event message.
Signed-off-by: Yusuke Sato <yusuke-sato@apn.alpine.co.jp>
Change-Id: I276b1373ae3b60347b4af44681f5c601f62dde4c
|
|
|
|
|
|
|
|
| |
Segfault is caused by dlt_user_check_buffer() if this function is called during increasing the user buffer.
To avoid this issue, semaphore has to be added.
Signed-off-by: Yusuke Sato <yusuke-sato@apn.alpine.co.jp>
Change-Id: Ie56f2fb73aeacb835180468e57c9338d2ffdb072
|
|
|
|
|
|
|
|
| |
Currently, dlt-system just wait for free space of user buffer > 50%.
To speed up the file transfer, dlt-system should try to resend user buffer contents actively.
Signed-off-by: Yusuke Sato <yusuke-sato@apn.alpine.co.jp>
Change-Id: I09d76acacf65b2c68559a05d45e00f35f402316a
|
|
|
|
|
|
|
|
| |
When file transfer feature of dlt-system is used on the 64 bit OS, file name is overwritten at the unique name creation phase.
File serial number should be maximum 10-digit decimal number.
Signed-off-by: Yusuke Sato <yusuke-sato@apn.alpine.co.jp>
Change-Id: I18fac363a103b6806ed9eb003ebbb305af7e7f58
|
|
|
|
|
|
|
|
| |
There is possibility that dlt-dbus continues to allocate memory for each filtered DBus message.
To solve this issue, free() is added after output the DBus log.
Signed-off-by: Yusuke Sato <yusuke-sato@apn.alpine.co.jp>
Change-Id: I393552c97035b6b06673cd5a9fd05c9158f47cdc
|
|
|
|
|
|
|
|
|
|
| |
This function allows an application developer to check if the DLT
LogLevel is enabled before starting any log string creation. It can be
used in application specific logging wrapper functions.
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
Change-Id: I4c269b12bfdeae29a4e795385cdbc54a579ba621
|
|
|
|
|
|
|
| |
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
Topic: GENDLT-425
Change-Id: I4ec56d714804d9ee4fa904b71c58dafd00990b4f
|
|
|
|
|
|
| |
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
Change-Id: Id01c9a11e4b5ccf4166f10c5e45363f3a7c00535
|
|
|
|
|
|
| |
Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
Change-Id: I211222d04350820098bf56dfc5b7aee50e2529f0
|
|
|
|
|
| |
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
Change-Id: I504664fa8d2a4c6d9449a1911bf139dfe6005d76
|
|
|
|
|
|
|
|
| |
This commit resloves a bug introduced from the commit:
CommonControl: Unix socket path and ecuid parsing for control applications
Signed-off-by: S. Hameed <shameed@jp.adit-jv.com>
Change-Id: Ifd4af24cab3ef41fda86fdf63a559438b51eca6e
|
|
|
|
|
|
| |
Signed-off-by: Manikandan C <Manikandan.Chockalingam@in.bosch.com>
Change-Id: I023c6bccbe3977d50b77bb601df80643d8e2d82c
|
|
|
|
|
|
|
|
| |
1. support for setting log level using wildcards for both app and context
2. support for setting entire system log level
Signed-off-by: Manikandan C <Manikandan.Chockalingam@in.bosch.com>
Change-Id: I92f8c5461903f092cd50f05f644013432940a87b
|
|
|
|
|
|
|
|
| |
This macro internally checks the size of a void pointer to decide if the
pointer address is sent with DLT_HEX32 or DLT_HEX64 macro.
Signed-off-by: Christoph Lipka <clipka@jp.adit-jv.com>
Change-Id: Ie316ac411f2174e0760e09244d04b83c8006f55d
|
|
|
|
|
|
|
|
| |
The user log message handler was returning 1 instead of -1 in case of
failure, which was not expected.
Signed-off-by: Frederic Berat <fberat@de.adit-jv.com>
Change-Id: Id03b2879f631e804f9939a9f52132be26491f888
|