From 4aef38e8da1c0f82ca7fbff0dbd6245afaf4c705 Mon Sep 17 00:00:00 2001 From: pierreN Date: Fri, 16 Jun 2017 14:40:11 +0900 Subject: Prevent buffer overflow for mount point path in dlt_logstorage_open_log_file (#19) Signed-off-by: Pierre N --- src/offlinelogstorage/dlt_offline_logstorage_behavior.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/offlinelogstorage/dlt_offline_logstorage_behavior.c b/src/offlinelogstorage/dlt_offline_logstorage_behavior.c index 125e083..f68d10d 100644 --- a/src/offlinelogstorage/dlt_offline_logstorage_behavior.c +++ b/src/offlinelogstorage/dlt_offline_logstorage_behavior.c @@ -387,7 +387,12 @@ int dlt_logstorage_open_log_file(DltLogStorageConfigData *config, return -1; } - sprintf(storage_path, "%s/", dev_path); + if(snprintf(storage_path, DLT_OFFLINE_LOGSTORAGE_CONFIG_DIR_PATH_LEN, + "%s/", dev_path) >= DLT_OFFLINE_LOGSTORAGE_CONFIG_DIR_PATH_LEN) + { + dlt_log(LOG_ERR, "Mount point path name too long\n"); + return -1; + } /* check if there are already files stored */ if (config->records == NULL) -- cgit v1.2.1