From 4d7d815781b18997f2d62c89fa00e729d1c31ddd Mon Sep 17 00:00:00 2001 From: Michael Methner Date: Thu, 6 Oct 2022 11:28:31 +0200 Subject: Correct review findings - removed duplicated gtest statement - corrected doxygen api description Signed-off-by: Michael Methner --- include/dlt/dlt_common.h | 4 ++-- tests/gtest_dlt_common.cpp | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/include/dlt/dlt_common.h b/include/dlt/dlt_common.h index d3404e2..615cbe2 100644 --- a/include/dlt/dlt_common.h +++ b/include/dlt/dlt_common.h @@ -1637,7 +1637,7 @@ int16_t dlt_getloginfo_conv_ascii_to_int16_t(char *rp, int *rp_count); * * @param rp char * @param rp_count int - * @param wp char + * @param wp char Array needs to be 1 byte larger than len to store '\0' * @param len int */ void dlt_getloginfo_conv_ascii_to_string(char *rp, int *rp_count, char *wp, int len); @@ -1648,7 +1648,7 @@ void dlt_getloginfo_conv_ascii_to_string(char *rp, int *rp_count, char *wp, int * * @param rp char * @param rp_count int - * @param wp char Array needs to be 1 byte larger than len to store '\0' + * @param wp char * @param len int * @return position of last read character in wp */ diff --git a/tests/gtest_dlt_common.cpp b/tests/gtest_dlt_common.cpp index e2356ed..18830be 100644 --- a/tests/gtest_dlt_common.cpp +++ b/tests/gtest_dlt_common.cpp @@ -4284,7 +4284,6 @@ TEST(dlt_client_parse_get_log_info_resp_text, normal) ret = dlt_client_parse_get_log_info_resp_text(resp, input); EXPECT_EQ(DLT_RETURN_OK, ret); - EXPECT_EQ(DLT_RETURN_OK, ret); EXPECT_EQ(2,resp->log_info_type.count_app_ids); -- cgit v1.2.1