From a6c42a0c5c67e764d964f91234b9c8c0f9d09b54 Mon Sep 17 00:00:00 2001 From: Alexander Mohr Date: Wed, 28 Sep 2022 10:22:19 +0200 Subject: dlt-gateway: Fix crash on invalid ip (#381) * dlt-gateway crashed when an invalid ip address was configured as a null pointer was used for strdup Signed-off-by: Alexander Mohr --- src/daemon/dlt-daemon.c | 2 +- src/gateway/dlt_gateway.c | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/daemon/dlt-daemon.c b/src/daemon/dlt-daemon.c index 8e3e646..35fb024 100644 --- a/src/daemon/dlt-daemon.c +++ b/src/daemon/dlt-daemon.c @@ -1045,7 +1045,7 @@ int main(int argc, char *argv[]) /* initiate gateway */ if (daemon_local.flags.gatewayMode == 1) { if (dlt_gateway_init(&daemon_local, daemon_local.flags.vflag) == -1) { - dlt_log(LOG_CRIT, "Fail to create gateway\n"); + dlt_log(LOG_CRIT, "Failed to create gateway\n"); return -1; } diff --git a/src/gateway/dlt_gateway.c b/src/gateway/dlt_gateway.c index 9d0041d..ae93c1b 100644 --- a/src/gateway/dlt_gateway.c +++ b/src/gateway/dlt_gateway.c @@ -791,6 +791,10 @@ int dlt_gateway_configure(DltGateway *gateway, char *config_file, int verbose) configuration_entries[j].key, value); } + if (!tmp.ip_address) { + invalid = 1; + } + if (invalid) { dlt_vlog(LOG_ERR, "%s configuration is invalid.\n" -- cgit v1.2.1