From 478a71467d5516c7e51f6be94868658187f9fee7 Mon Sep 17 00:00:00 2001 From: Phong Tran Date: Sat, 30 Nov 2019 19:02:31 +0700 Subject: dlt_user: init DltContextData before use for fixing the coverity warnings type Uninitialized scalar variable (UNINIT). Using uninitialized value log.use_timestamp when calling dlt_user_log_send_log. Signed-off-by: Phong Tran --- src/lib/dlt_user.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src/lib') diff --git a/src/lib/dlt_user.c b/src/lib/dlt_user.c index c3da424..ffa9b09 100644 --- a/src/lib/dlt_user.c +++ b/src/lib/dlt_user.c @@ -2633,7 +2633,7 @@ DltReturnValue dlt_user_trace_network_segmented_start(uint32_t *id, void *header, uint16_t payload_len) { - DltContextData log; + DltContextData log = { 0 }; struct timeval tv; int ret = DLT_RETURN_ERROR; @@ -2750,7 +2750,7 @@ DltReturnValue dlt_user_trace_network_segmented_segment(uint32_t id, return DLT_RETURN_ERROR; if (handle->trace_status_ptr && (*(handle->trace_status_ptr) == DLT_TRACE_STATUS_ON)) { - DltContextData log; + DltContextData log = { 0 }; if (dlt_user_log_init(handle, &log) < DLT_RETURN_OK) return DLT_RETURN_ERROR; @@ -2808,7 +2808,7 @@ DltReturnValue dlt_user_trace_network_segmented_segment(uint32_t id, DltReturnValue dlt_user_trace_network_segmented_end(uint32_t id, DltContext *handle, DltNetworkTraceType nw_trace_type) { - DltContextData log; + DltContextData log = { 0 }; int ret = DLT_RETURN_ERROR; if ((nw_trace_type < DLT_NW_TRACE_IPC) || (nw_trace_type >= DLT_NW_TRACE_MAX)) { @@ -3066,12 +3066,11 @@ DltReturnValue dlt_user_trace_network_truncated(DltContext *handle, int allow_truncate) { int ret = DLT_RETURN_ERROR; + DltContextData log = { 0 }; if ((payload == NULL) && (payload_len > 0)) return DLT_RETURN_WRONG_PARAMETER; - DltContextData log; - if ((nw_trace_type < DLT_NW_TRACE_IPC) || (nw_trace_type >= DLT_NW_TRACE_MAX)) { dlt_vlog(LOG_ERR, "Network trace type %d is outside valid range", nw_trace_type); return DLT_RETURN_WRONG_PARAMETER; -- cgit v1.2.1