From c32b3a39e484c1fc5ff625c752c6beeb9426ff85 Mon Sep 17 00:00:00 2001 From: Saya Sugiura Date: Fri, 7 Jun 2019 17:02:18 +0900 Subject: Correct sa findings dlt_offline_logstorage.c - Parameter to isdigit is not correct - Handle the size of memset() and strncpy() properly dlt-test-stress-user.c - Parameter d is duplicated dlt_env_ll.c - Parameter env is used before NULL check - Remove redundant line dlt-control-common.c dlt_daemon_event_handler.c - Do not use NULL variable to print log dlt_config_file_parser.c - Remove unnecessary loop dlt_daemon_client.c - Return error in NULL check dlt_user.c - Free allocated memory in error case Related commit: 5c8f88d logstorage: fix compile error Signed-off-by: Saya Sugiura --- src/offlinelogstorage/dlt_offline_logstorage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/offlinelogstorage/dlt_offline_logstorage.c') diff --git a/src/offlinelogstorage/dlt_offline_logstorage.c b/src/offlinelogstorage/dlt_offline_logstorage.c index 2a52951..872c47e 100644 --- a/src/offlinelogstorage/dlt_offline_logstorage.c +++ b/src/offlinelogstorage/dlt_offline_logstorage.c @@ -395,7 +395,7 @@ DLT_STATIC int dlt_logstorage_read_number(unsigned int *number, char *value) /* check if string consists of digits only */ for (i = 0; i < len; i++) - if (isdigit(value[i] == 0)) { + if (!isdigit(value[i])) { dlt_log(LOG_ERR, "Invalid, is not a number \n"); return -1; } -- cgit v1.2.1