diff options
| author | Aleksander Morgado <aleksander@aleksander.es> | 2019-01-16 15:56:59 +0100 |
|---|---|---|
| committer | Aleksander Morgado <aleksander@aleksander.es> | 2019-01-16 15:56:59 +0100 |
| commit | f49f325715b8bc8078bafa3339f1d77dbe35392e (patch) | |
| tree | 7442ee7aa141d50fd606c70fff9ae98e0a9d87c5 | |
| parent | 6dd8876124aab1873a40abadcf40e8271dfc9f6b (diff) | |
| download | ModemManager-f49f325715b8bc8078bafa3339f1d77dbe35392e.tar.gz | |
libmm-glib,firmware-update-settings: skip dictionary if method is NONE
No need to process the detailed dictionary if no explicit method is
reported as supported. Avoids unnecessary warnings:
$ mmcli -m 1 --firmware-status
** (mmcli:6887): WARNING **: 15:52:54.664: Invalid initial update settings: Missing required 'device-ids' setting
error: firmware status unsupported
| -rw-r--r-- | libmm-glib/mm-firmware-update-settings.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libmm-glib/mm-firmware-update-settings.c b/libmm-glib/mm-firmware-update-settings.c index 01c8bc8d4..37c8381ea 100644 --- a/libmm-glib/mm-firmware-update-settings.c +++ b/libmm-glib/mm-firmware-update-settings.c @@ -255,7 +255,7 @@ mm_firmware_update_settings_new_from_variant (GVariant *variant, g_variant_get (variant, "(u@a{sv})", &method, &dictionary); self = mm_firmware_update_settings_new (method); - if (dictionary) { + if ((method != MM_MODEM_FIRMWARE_UPDATE_METHOD_NONE) && dictionary) { GVariantIter iter; gchar *key; GVariant *value; |