summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* modem-helpers: reuse nicknames for the flow control tagsaleksander/serial-port-flow-controlAleksander Morgado2018-09-104-43/+70
| | | | And check that the string given in the tag is actually a valid one.
* port-serial: improve logging in mm_port_serial_set_flow_control()Aleksander Morgado2018-09-101-6/+26
|
* broadband-bearer: no need for explicit flow control cleanup on disconnectAleksander Morgado2018-09-101-20/+0
| | | | | | | We're already configuring the flow control we expect when running mm_port_serial_reopen(), which will keep the udev-selected flow control or will otherwise reset to no flow control when the TTY is in command mode.
* cinterion: report selected RTS/CTS flow control to modemAleksander Morgado2018-09-101-0/+1
|
* iridium: report selected RTS/CTS flow control to modemAleksander Morgado2018-09-101-0/+1
|
* broadband-modem: allow subclasses to modify the flow control settingsAleksander Morgado2018-09-101-1/+4
| | | | | | | | If a subclass implements a custom setup_flow_control() logic, e.g. to select a very specific setting explicitly, let it also configure the flow control settings modem-wide via the modem object property, so that bearer objects can later on use the same settings when preparing for a new connection.
* broadband-modem: rework flow control selection logicAleksander Morgado2018-09-101-55/+56
| | | | | | | | | | | | | | | Try to simplify a bit the logic that selects the flow control to be used during connectivity: * We detect early if the requested flow control (via udev tags) is actually supported by the modem (as eported by AT+IFC=?), and if it isn't, we error out directly. * We try to set in a single place the AT commands to be used to setup the flow control, once we have decided which one we're going to use. * Use the string builder helpers to log the flow control values.
* port-serial,broadband-modem: minor coding style fixesAleksander Morgado2018-09-102-4/+6
|
* port-serial: improve logging of device-level flow control settingsAleksander Morgado2018-09-101-3/+11
|
* port-serial: Flow Control property is flags, not enumAleksander Morgado2018-09-101-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MMFlowControl is a flags enumeration, so change the property type to match that, or we'll end up with nasty criticals during runtime. (ModemManager:30758): GLib-GObject-CRITICAL **: 10:54:26.435: g_param_spec_enum: assertion 'G_TYPE_IS_ENUM (enum_type)' failed Thread 1 "ModemManager" received signal SIGTRAP, Trace/breakpoint trap. 0x00007ffff71f2a96 in ?? () from /usr/lib/libglib-2.0.so.0 (gdb) bt #0 0x00007ffff71f2a96 in () at /usr/lib/libglib-2.0.so.0 #1 0x00007ffff71f3def in g_logv () at /usr/lib/libglib-2.0.so.0 #2 0x00007ffff71f3fe0 in g_log () at /usr/lib/libglib-2.0.so.0 #3 0x00007ffff72d90ac in g_param_spec_enum () at /usr/lib/libgobject-2.0.so.0 #4 0x000055555564caf2 in mm_port_serial_class_init (klass=0x5555557607c0) at mm-port-serial.c:2101 #5 0x000055555564759a in mm_port_serial_class_intern_init (klass=0x5555557607c0) at mm-port-serial.c:49 #6 0x00007ffff72ea9b4 in g_type_class_ref () at /usr/lib/libgobject-2.0.so.0 #7 0x00007ffff72eab5a in g_type_class_ref () at /usr/lib/libgobject-2.0.so.0 #8 0x00007ffff72d0f53 in g_object_new_valist () at /usr/lib/libgobject-2.0.so.0 #9 0x00007ffff72d103a in g_object_new () at /usr/lib/libgobject-2.0.so.0 #10 0x000055555564e187 in mm_port_serial_at_new (name=0x55555576e280 "ttyUSB4", subsys=MM_PORT_SUBSYS_TTY) at mm-port-serial-at.c:533 #11 0x0000555555602512 in serial_open_at (self=0x555555715390) at mm-port-probe.c:1285 #12 0x00007ffff71ecb49 in g_main_context_dispatch () at /usr/lib/libglib-2.0.so.0 #13 0x00007ffff71ecf59 in () at /usr/lib/libglib-2.0.so.0 #14 0x00007ffff71ed272 in g_main_loop_run () at /usr/lib/libglib-2.0.so.0 #15 0x00005555555957e0 in main (argc=3, argv=0x7fffffffe458) at main.c:181 Also, rename the property to match the naming convention of other properties in the same object.
* broadband-modem: set flow control from portAlfonso Sánchez-Beato2018-09-101-16/+65
| | | | | Set the flow control used in the data connection from the one set in the port.
* base-modem,port-probe: set serial port flow control from udev tagAlfonso Sánchez-Beato2018-09-102-1/+25
| | | | | Set the serial port flow control from the udev tag ID_MM_TTY_FLOW_CONTROL before accessing the port.
* port-serial: add flow control propertyAlfonso Sánchez-Beato2018-09-102-29/+77
| | | | | Add flow control property to the MMPortSerial class, and use it when setting the port flow control.
* modem-helpers: add flow control udev tag parserAlfonso Sánchez-Beato2018-09-102-0/+21
| | | | | Add function for parsing the content of the udev tag ID_MM_TTY_FLOW_CONTROL.
* broadband-bearer: don't do connection checks on CDMAAleksander Morgado2018-09-081-0/+8
| | | | | | | | | On CDMA-only connections we won't have a CID defined, so instead of getting in a loop of warnings reporting "cid not defined", early error out with an UNSUPPORTED error so that the connection check isn't tried any more. https://gitlab.freedesktop.org/mobile-broadband/ModemManager/issues/83
* broadband-modem: port modem_cdma_register_in_network to use GTaskBen Chan2018-09-071-24/+24
|
* broadband-modem: port modem_cdma_setup_registration_checks to use GTaskBen Chan2018-09-071-33/+46
|
* broadband-modem: port modem_cdma_setup_cleanup_unsolicited_events to use GTaskBen Chan2018-09-071-33/+34
|
* broadband-modem: port modem_load_access_technologies to use GTaskBen Chan2018-09-071-67/+73
|
* broadband-modem-qmi: avoid completing the GTask twice when loading capabilitiesAleksander Morgado2018-09-061-3/+3
|
* broadband-modem-qmi: add missing task unref when loading signal valuesAleksander Morgado2018-09-061-0/+1
|
* broadband-modem-qmi: make sure result values are not in context when completingAleksander Morgado2018-09-061-3/+7
| | | | | | In order to avoid having the result values in 2 places (context and result) when the GTask is completed, we will steal the pointer from the context before it's set as result of the GTask.
* broadband-modem-qmi: Pass signal values_result directly rather than ↵Paul Bartell2018-09-041-1/+2
| | | | | | | | duplicating with g_memdup corrects segfault introduced in 7d8f0600e6de32721112949b65d48108ea640b51 Signed-off-by: Paul Bartell <p.bartell@temperednetworks.com>
* test,modem-helpers: remove unnecessary NULL check for g_free()Ben Chan2018-08-291-2/+1
| | | | | g_free() handles a NULL pointer properly, so there is no need to have a NULL check before calling g_free().
* libmm-glib,pco: add some more missing documentation for MMPcoAleksander Morgado2018-08-281-4/+14
|
* libmm-glib,pco: add missing documentation for MMPcoBen Chan2018-08-282-1/+26
|
* port-probe: fix build when QMI over MBIM is unsupportedAleksander Morgado2018-08-281-1/+1
|
* docs: mm_modem_get_sim is asyncGuido Günther2018-08-271-1/+1
| | | | Signed-off-by: Guido Günther <guido.gunther@puri.sm>
* mbim: fix inconsistency in WITH_QMI guardsBen Chan2018-08-234-6/+6
|
* broadband-modem-mbim: add missing guard for shared_qmi_init()Ben Chan2018-08-221-0/+4
| | | | Fixes: 9e42a19742de55cf5c0ba4d68069c1845e9392e6
* port-mbim: add missing guard for try_qmi_over_mbim in mm_port_mbim_open()Ben Chan2018-08-221-0/+2
| | | | Fixes: c0cc694c67d9e71f200fb23e20473cc9b31d9ec0
* xmm: include string.h for strlen()Ben Chan2018-08-211-0/+2
| | | | | | | | This patch fixes the following compiler warning: xmm/mm-modem-helpers-xmm.c:388:38: error: implicitly declaring library function 'strlen' with type 'unsigned long (const char *)' [-Werror,-Wimplicit-function-declaration] g_regex_match_full (r, response, strlen (response), 0, 0, &match_info, &inner_error); ^
* shared-qmi: include string.h for memset()Ben Chan2018-08-211-0/+1
| | | | | | | | This patch fixes the following compiler warning: mm-shared-qmi.c:447:9: error: implicitly declaring library function 'memset' with type 'void *(void *, int, unsigned long)' [-Werror,-Wimplicit-function-declaration] memset (buf, 0, sizeof (buf)); ^
* cinterion: new 'MMSharedCinterion' interfaceAleksander Morgado2018-08-215-282/+343
| | | | | | | | | | | | | | | | | Implement a new interface to keep the code shared between the QMI and non-QMI modem implementations. While doing that, also fix the parent interface pointer handling, so that it isn't a static pointer applicable to all modems, and make it a per-modem specific pointer. Without this fix, ModemManager would crash if e.g. running with both a QMI and non-QMI Cinterion modem at the same time. The new shared Cinterion logic will be in charge of managing all GPS sources not already managed by the parent interface. E.g. if the parent implementation already supports QMI-based GPS location (using the LOC service for example) prefer that to the custom AT-based logic.
* xmm: implement power management operationsAleksander Morgado2018-08-214-0/+200
|
* fibocom: include udev rules testsAleksander Morgado2018-08-212-2/+11
|
* fibocom: support XMM-based devicesAleksander Morgado2018-08-212-1/+23
|
* plugin: new properties to support Intel XMM capability probingAleksander Morgado2018-08-212-0/+80
|
* port-probe: support probing for Intel XMM capabilitiesAleksander Morgado2018-08-212-8/+96
| | | | Same thing as we do for Icera.
* xmm: new 'MMBroadbandModemMbimXmm' modem objectAleksander Morgado2018-08-213-0/+141
|
* xmm: new 'MMBroadbandModemXmm' modem objectAleksander Morgado2018-08-213-0/+135
|
* xmm: new 'MMSharedXmm' modem interfaceAleksander Morgado2018-08-213-1/+657
| | | | With support for managing bands and modes.
* libmm-glib: new common helpers to check band typesAleksander Morgado2018-08-212-0/+31
|
* xmm: new helper to get 'any' allowed mode combinationAleksander Morgado2018-08-212-0/+34
|
* xmm: new common XACT=X builder for Intel XMM based devicesAleksander Morgado2018-08-213-0/+346
|
* xmm: new common XACT? parser for Intel XMM based devicesAleksander Morgado2018-08-213-0/+225
|
* xmm: new common XACT=? parser for Intel XMM based devicesAleksander Morgado2018-08-214-0/+604
|
* api: define E-UTRAN bands 49 to 64Aleksander Morgado2018-08-211-0/+32
|
* fibocom: ignore intel trace port in the L850-GLAleksander Morgado2018-08-212-0/+18
|
* fibocom: new plugin with support for MBIM devicesAleksander Morgado2018-08-213-0/+147
|