delta/NetworkManager.git, branch lr/namespace

platform/tests: don't attempt to mount anything to /sys/devices

2016-10-17T13:19:08+00:00

More recent kernels won't allow that in userns when /sys itself
is read-only.

Revert "platform/tests: skip root tests when we can't mount /sys/devices"

2016-10-17T13:18:37+00:00

This was plain stupid. We don't care about sysfs being writable or
anything *before* entering the namespace.

This reverts commit 15a26d6192ed24cb97f443a06a1514e82e58b43f.

core: introduce default logging macros

2016-10-14T13:57:43+00:00

Revert "contrib/rpm: run `make check` in parallel"

2016-10-14T13:48:27+00:00

`make check -C libnm/tests` is not yet ready to run in
parallel. Revert.

This reverts commit 0a1508358d7754e23cb0c516da02d1e3bb515b72.

contrib/rpm: rename obsoletes_nmver to obsoletes_version_device_plugins

2016-10-14T09:26:13+00:00

We will have multiple obsoletes

merge: branch 'bg/platform-unaligned-stats64-bgo772605'

2016-10-14T09:16:42+00:00

https://bugzilla.gnome.org/show_bug.cgi?id=772605

platform: avoid unaligned access to link stats on 64bit architectures

2016-10-14T09:16:13+00:00

The undefined behavior sanitizer complains with:

platform/nm-linux-platform.c:1482:31: runtime error: member access within misaligned address 0x61a000016fac for type 'struct rtnl_link_stats64', which requires 8 byte alignment
0x61a000016fac: note: pointer points here
  bc 00 17 00 bf 05 00 00  00 00 00 00 bf 05 00 00  00 00 00 00 b5 68 02 00  00 00 00 00 b5 68 02 00
              ^
platform/nm-linux-platform.c:1483:29: runtime error: member access within misaligned address 0x61a000016fac for type 'struct rtnl_link_stats64', which requires 8 byte alignment
0x61a000016fac: note: pointer points here
  bc 00 17 00 bf 05 00 00  00 00 00 00 bf 05 00 00  00 00 00 00 b5 68 02 00  00 00 00 00 b5 68 02 00
              ^
platform/nm-linux-platform.c:1484:31: runtime error: member access within misaligned address 0x61a000016fac for type 'struct rtnl_link_stats64', which requires 8 byte alignment
0x61a000016fac: note: pointer points here
  bc 00 17 00 bf 05 00 00  00 00 00 00 bf 05 00 00  00 00 00 00 b5 68 02 00  00 00 00 00 b5 68 02 00
              ^
platform/nm-linux-platform.c:1485:29: runtime error: member access within misaligned address 0x61a000016fac for type 'struct rtnl_link_stats64', which requires 8 byte alignment
0x61a000016fac: note: pointer points here
  bc 00 17 00 bf 05 00 00  00 00 00 00 bf 05 00 00  00 00 00 00 b5 68 02 00  00 00 00 00 b5 68 02 00
              ^

That's because the pointer returned by nla_data() is only
32bit-aligned and using it to access structure members can cause
issues on some 64bit architectures.

Use the unaligned_read_ne64() macro to access the structure members.

https://bugzilla.gnome.org/show_bug.cgi?id=772605

shared: add unaligned.h

2016-10-14T09:16:13+00:00

The file, imported from systemd sources, contains macros for accessing
potentially unaligned data in a safe way (i.e. byte-wise).

build: don't remove shared/nm-version-macros.h upon clean

2016-10-14T08:59:54+00:00

Files generated by ./configure shouldn't be deleted by a 'make clean'.

Fixes: 24f566afa0715162b4e333cf41f7c49a0d62cdfe

libnm: disconnect devices' signals when disposing manager

2016-10-14T08:44:18+00:00

We connect signal handlers to devices when they appear, but don't
disconnect the handlers when the manager instance is destroyed. This
can cause crashes as device_ac_changed() is called on an invalid
manager instance.

Disconnect the handlers from dispose().

https://bugzilla.redhat.com/show_bug.cgi?id=1383758