delta/NetworkManager.git, branch th/device-carrier-wait-rh1450444

device: fix delaying startup complete waiting for carrier

2017-05-15T13:49:54+00:00

    platform: signal: link changed: 2: eth0  mtu ...
    ...
    device[0x7f90c29c64d0] (eth0): bringing up device
    ...
    platform: signal: link changed: 2: eth0  mtu ...
    ...
    device (eth0): link connected
    ...
    device[0x7f90c29c64d0] (eth0): add_pending_action (2): 'carrier wait'

Note how we schedule the pending action 'carrier-wait', altough the device
already has carrier. That means, the pending action will not be removed
until timeout, 5 seconds later.

Avoid scheduling 'carrier-wait' if we already have carrier.

However, we don't just add the pending action 'carrier-wait' only in
nm_device_bring_up(). Instead, always schedule the carrier_wait timeout.
This is a grace period during which we keep setting 'carrier-wait' whenever
we have no carrier. This should prevent two cases:
  - during nm_device_bring_up() the platform state might not yet have
    caught up. If we don't add the pending action there, we will add
    it a moment later when carrier goes away.
  - bringing the interface up might cause carrier to get lost for a
    moment (flapping). If that happens within the timeout, consider
    add the pending action.

device: cleanup nm_device_set_carrier_from_platform()

2017-05-15T13:47:22+00:00

nm_device_set_carrier_from_platform() is only called from two places.

- both check for NM_DEVICE_CAP_CARRIER_DETECT, so move that check
  inside the function.
- drop the logging in realize_start_setup(). nm_device_set_carrier() already
  does logging.
- always set the fake carrier in nm_device_set_carrier_from_platform().
  For the fake carrer, we anyway expect it to be already TRUE in most
  case, so usually this should have no effect.
  Also emit a property changed signal. That is necessary to refresh the
  D-Bus property.

device: rename and minor refactoring of check_carrier()

2017-05-15T13:47:22+00:00

The name should mirror what we already have: nm_device_set_carrier().
Also, move the code closer to nm_device_set_carrier() and refactor
it a bit.

device: downgrade logging messages about (non) pending action

2017-05-15T13:47:21+00:00

Adding/Removing a pending action with assert_not_yet_pending/
assert_is_pending means that we expect that no action is taken.

Downgrade the logging level in those cases to .

device: minor cleanup of carrier_disconnected_action_cancel()

2017-05-15T13:47:21+00:00

device/trivial: rename functions related to "carrier"

2017-05-15T13:47:21+00:00

device: don't call virtual function carrier_changed() directly

2017-05-15T13:47:21+00:00

Don't give the subclass the ability to override the parents
behavior. The parent implementation is not intended to allow
for that. Instead, restrict the flexibility of how the virtual
function integrates with the larger picture. That means, the
virtual function is only called at one place, and there is only
one implementation in NMDeviceEthernet (and it doesn't really
matter whether the implementation chains up the parent implementation
or not).

cli: fix use-after-free in _get_fcn_gobject_enum()

2017-05-15T13:16:22+00:00

Fixes: ddfff04a457444ee9a7c7e85d08e1d7213b3ab6e

merge: branch 'lr/wps2'

2017-05-15T11:00:13+00:00

https://bugzilla.gnome.org/show_bug.cgi?id=781336

dbus/secret-agent: add a flag indicating WPS PBC is active

2017-05-15T10:59:55+00:00

The agents may used this to learn that WPS PBC enrollment is active and
suggest that user pushes a button on the router instead of supplying a
network key.