delta/NetworkManager.git, branch th/device-pending-action-bgo777831

core: define a full sort order for nm_settings_connection_cmp_timestamp()

2017-02-09T09:59:13+00:00

We want to have some guaranteed order when comparing different connections.
So, in case of equal timestamps, proceed with comparing more properties.

It makes sense to consider the autoconnect-priority next.
This is what get_existing_connection() needs, thus we no longer
need to pre-sort the list.

core: consolidate sorting of connections by autoconnect/timestamp

2017-02-09T09:59:13+00:00

NMPolicy's auto_activate_device() wants to sort by autoconnect-priority,
nm_utils_cmp_connection_by_autoconnect_priority() but fallback to the default
nm_settings_connection_cmp_default(), which includes the timestamp.

Extend nm_settings_connection_cmp_default() to consider the
autoconnect-priority as well. Thus change behavior so that
nm_settings_connection_cmp_default() is the sort order that
auto_activate_device() wants. That makes sense, as
nm_settings_connection_cmp_default() already considered the
ability to autoconnect as first. Hence, it should also honor
the autoconnect priority.

When doing that, rename nm_settings_connection_cmp_default()
to nm_settings_connection_cmp_autoconnect_priority().

core: make nm_utils_cmp_connection_by_autoconnect_priority() more robust

2017-02-09T09:59:13+00:00

Check for NULL and unexpected missing NMSettingConnection.
Be more forgiving and accept whatever is there when comparing
@a with @b.

core: refactor nm_manager_get_activatable_connections() to return an array

2017-02-09T09:59:13+00:00

... instead of a GSList.

core: refactor nm_settings_get_connections_sorted() to return array instead of GSList

2017-02-09T09:59:13+00:00

We call these functions a lot. A GSList is just the wrong tool for the
job. Refactor the code to use instead a sorted array everywhere.

This means, we malloc() one array for all connections instead
slice-allocate a GSList item for each. Also, sorting an array
is faster then sorting a GSList.
Technically, the GSList implementation had the same big-O runtime
complexity, but using an array is still faster. That is, sorting
an array and a GSList is both O(n*log(n)).

Actually, nm_settings_get_connections_sorted() used
g_slist_insert_sorted() instead of g_slist_sort(). That results
in O(n^2). That could have been fixed to have O(n*log(n)), but
instead refactor the code to use an array.

core: drop nm_settings_get_best_connections() for new nm_settings_get_connections_clone()

2017-02-09T09:59:13+00:00

nm_settings_get_best_connections() has only one caller: to create
the hidden-SSID list.

Instead of having a highly specialised function (that accepts 3 ways for
filtering -- one of them broken, has one hard-coded way of sorting, and
a @max_requested argument), add a more generic nm_settings_get_connections_clone()
function.

Also invert nm_settings_sort_connections(). The two callers want
to sort descending, not ascending.

core: add and use nm_settings_connection_cmp_default*()

2017-02-09T09:59:13+00:00

Only move the function, no change in behavior.

core: add and use nm_settings_connection_cmp_timestamp*()

2017-02-09T09:59:12+00:00

Only move the function, no change in behavior.

core: add nm_utils_cmp_connection_by_autoconnect_priority_p_with_data() function

2017-02-09T09:59:12+00:00

Have a proper cmp() function and a wrapper *_p_with_data() that can be
used for g_qsort_with_data().

Thus, establish a naming scheme (*_p_with_data()) for these compare
wrappers that we need all over the place. Note, we also have
nm_strcmp_p_with_data() for the same reason and later more such
functions will follow.

device/wifi: prevent clearing pending wifi scan action during inactive supplicant

2017-02-09T09:59:12+00:00

     [1486325858.0691] device[0x563b8fba42e0] (wlp3s0): wifi-scan: scan-done callback: successful
     [1486325858.0692] device[0x563b8fba42e0] (wlp3s0): wifi-scan: scheduled in 23 seconds (interval now 33 seconds)
     [1486325858.0692] device[0x563b8fba42e0] (wlp3s0): remove_pending_action (0): 'wifi-scan'
     [1486325858.0692] properties-changed[0x563b8fba42e0]: ignoring notification for prop has-pending-action on type NMDeviceWifi
     [1486325858.0692] manager: check_if_startup_complete returns FALSE because of enp0s25
      [1486325858.0697] device (wlp3s0): supplicant interface state: ready -> inactive
     [1486325858.0698] device[0x563b8fba42e0] (wlp3s0): wifi-scan: scanning requested
     [1486325858.0698] device[0x563b8fba42e0] (wlp3s0): wifi-scan: (0) probe scanning SSID 
     [1486325858.0698] device[0x563b8fba42e0] (wlp3s0): wifi-scan: (1) probe scanning SSID "aaa"
     [1486325858.0699] device[0x563b8fba42e0] (wlp3s0): set-hw-addr: no MAC address change needed (2A:71:5D:54:85:1F)
     [1486325858.0699] device[0x563b8fba42e0] (wlp3s0): add_pending_action (1): 'wifi-scan'