delta/NetworkManager.git/shared/nm-glib-aux/nm-shared-utils.c, branch bg/dhcp-shorten-hostname

shared,all: cleanup nm_utils_hashtable_equal*() functions

2020-11-09T16:25:25+00:00

We have:

- nm_utils_hashtable_cmp(): this does a full cmp of two hash
  tables, with the intent to provide a stable sort order.
  It thus takes a GCompareDataFunc() argument.

- nm_utils_hashtable_cmp_equal(): this is like nm_utils_hashtable_cmp(),
  except that the caller won't get a compare value, only a boolean
  value that indicates equality.
  This was previously called nm_utils_hashtable_equal().

- nm_utils_hashtable_equal(): this takes a GEqualFunc function
  for comparing the values for equality. It takes thus
  a different kind of predicate, but otherwise is similar to
  nm_utils_hashtable_cmp_equal().
  This was previously called nm_utils_hash_table_equal().

Unify the naming of these functions.

shared: use GEqualFunc instead of NMUtilsHashTableEqualFunc typedef

2020-11-09T16:25:25+00:00

shared: add nm_utils_strdict_clone() helper

2020-11-09T16:25:24+00:00

shared: add nm_utils_named_value_clear_with_g_free() helper

2020-11-09T16:25:24+00:00

shared: introduce opaque type NMUtilsUserData for nm_utils_user_data_pack()

2020-10-22T15:38:08+00:00

This makes the usage slightly more type safe.

shared: automatically cast strv argument for nm_utils_strv_equal()/nm_utils_strv_cmp_n()

2020-10-12T20:20:01+00:00

It's cumbersome if we always need to cast our arguments for
the strv helper functions. Depending on the situation, we often
have a "char **" or a "const char *const*" argument.

Use NM_CAST_STRV_CC() macros instead. This macro uses C11's _Generic()
and casts types that are presumed to be safe. This tends to be less
typing and more type-safe, because you don't need an explicit C cast
(which would overrule any warning that the compiler might have for you).

all/trivial: rename _nm_utils_strv_equal()/_nm_utils_strv_cmp_n() to have no leading underscore

2020-10-12T20:18:26+00:00

The underscore somehow indicated that these would be an internal
function. Which they are in the sense that they are in "shared/nm-glib-aux/".
But they part of our internal helper functions, and in our code base
their use is no discouraged or "private.

Also, next I'll replace the function call with a macro, so, I will
have a need for the underscore name.

Rename.

all: unify comment style for SPDX-License-Identifier tag

2020-09-29T14:50:53+00:00

Our coding style recommends C style comments (/* */) instead of C++
(//). Also, systemd (which we partly fork) uses C style comments for
the SPDX-License-Identifier.

Unify the style.

  $ sed -i '1 s#// SPDX-License-Identifier: \([^ ]\+\)$#/* SPDX-License-Identifier: \1 */#' -- $(git ls-files -- '*.[hc]' '*.[hc]pp')

format: manually replace remaining tabs with spaces and reformat

2020-09-29T07:12:27+00:00

format: replace tabs for indentation in code comments

2020-09-28T14:07:52+00:00

sed -i \
     -e 's/^'$'\t'' \*/     */g' \
     -e 's/^'$'\t\t'' \*/         */g' \
     -e 's/^'$'\t\t\t'' \*/             */g' \
     -e 's/^'$'\t\t\t\t'' \*/                 */g' \
     -e 's/^'$'\t\t\t\t\t'' \*/                     */g' \
     -e 's/^'$'\t\t\t\t\t\t'' \*/                         */g' \
     -e 's/^'$'\t\t\t\t\t\t\t'' \*/                             */g' \
     $(git ls-files -- '*.[hc]')