diff options
| author | Beniamino Galvani <bgalvani@redhat.com> | 2019-12-17 15:04:11 +0100 |
|---|---|---|
| committer | Beniamino Galvani <bgalvani@redhat.com> | 2019-12-18 09:54:08 +0100 |
| commit | 0de4fd6ebc4c3909838087e254a24359e816d0be (patch) | |
| tree | 87ab1b9c7cbaefa34ddc157dfd7417adbbf149bd | |
| parent | 9aa00a8a14cb64f851234d025498ff2f9ec18e94 (diff) | |
| download | NetworkManager-0de4fd6ebc4c3909838087e254a24359e816d0be.tar.gz | |
shared: add missing va_end() to _nm_dbus_error_is()
Found by covscan:
NetworkManager-1.22.0/shared/nm-glib-aux/nm-dbus-aux.c:361:
missing_va_end: va_end was not called for "ap".
Fixes: ce36494c0a48 ('shared: add nm_dbus_error_is() helper')
| -rw-r--r-- | shared/nm-glib-aux/nm-dbus-aux.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/shared/nm-glib-aux/nm-dbus-aux.c b/shared/nm-glib-aux/nm-dbus-aux.c index 75b282bc14..86061aefdf 100644 --- a/shared/nm-glib-aux/nm-dbus-aux.c +++ b/shared/nm-glib-aux/nm-dbus-aux.c @@ -357,8 +357,10 @@ _nm_dbus_error_is (GError *error, ...) va_start (ap, error); while ((name = va_arg (ap, const char *))) { - if (nm_streq (dbus_error, name)) + if (nm_streq (dbus_error, name)) { + va_end (ap); return TRUE; + } } va_end (ap); |