summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLubomir Rintel <lkundrak@v3.sk>2019-11-02 06:55:54 +0100
committerLubomir Rintel <lkundrak@v3.sk>2019-11-02 07:02:59 +0100
commit59923ad85d1a1cf2216a4f14649702d24d3f2360 (patch)
treea4323c16e9117c852c88a6b13df6a821fc49895b
parente1ead6fa984db411db8c8cfcc1e1cf16e110ce3e (diff)
downloadNetworkManager-59923ad85d1a1cf2216a4f14649702d24d3f2360.tar.gz
iwd: add some missing error handling
g_dbus_object_manager_get_interface() can happily return NULL and we need to check for that.
-rw-r--r--src/devices/wifi/nm-iwd-manager.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/src/devices/wifi/nm-iwd-manager.c b/src/devices/wifi/nm-iwd-manager.c
index dd1cad4806..e83f8063ce 100644
--- a/src/devices/wifi/nm-iwd-manager.c
+++ b/src/devices/wifi/nm-iwd-manager.c
@@ -136,6 +136,11 @@ agent_dbus_method_cb (GDBusConnection *connection,
network = g_dbus_object_manager_get_interface (priv->object_manager,
network_path,
NM_IWD_NETWORK_INTERFACE);
+ if (!network) {
+ _LOGE ("unable to find the network object");
+ return;
+ }
+
device_path = get_property_string_or_null (G_DBUS_PROXY (network), "Device");
if (!device_path) {
@@ -260,6 +265,11 @@ register_agent (NMIwdManager *self)
"/",
NM_IWD_AGENT_MANAGER_INTERFACE);
+ if (!agent_manager) {
+ _LOGE ("unable to register the IWD Agent: PSK/8021x Wi-Fi networks may not work");
+ return;
+ }
+
/* Register our agent */
g_dbus_proxy_call (G_DBUS_PROXY (agent_manager),
"RegisterAgent",