diff options
author | Thomas Haller <thaller@redhat.com> | 2019-08-22 09:57:55 +0200 |
---|---|---|
committer | Thomas Haller <thaller@redhat.com> | 2019-08-28 16:27:00 +0200 |
commit | 2d40b7ba61590c700eb146f2a07fb14751d82ab8 (patch) | |
tree | e7a309695cdc5ecac6dc52a68b1cd4da1e5ab97e | |
parent | de439148dd5ee890d1879f48875c4624b1ec87d0 (diff) | |
download | NetworkManager-2d40b7ba61590c700eb146f2a07fb14751d82ab8.tar.gz |
device: let NMDevice set hardware address instead of act_stage1_prepare()
-rw-r--r-- | src/devices/nm-device-bridge.c | 6 | ||||
-rw-r--r-- | src/devices/nm-device-vlan.c | 4 |
2 files changed, 2 insertions, 8 deletions
diff --git a/src/devices/nm-device-bridge.c b/src/devices/nm-device-bridge.c index 438f850315..4b53f4f325 100644 --- a/src/devices/nm-device-bridge.c +++ b/src/devices/nm-device-bridge.c @@ -507,11 +507,6 @@ act_stage1_prepare (NMDevice *device, NMDeviceStateReason *out_failure_reason) s_bridge = (NMSetting *) nm_connection_get_setting_bridge (connection); g_return_val_if_fail (s_bridge, NM_ACT_STAGE_RETURN_FAILURE); - if (!nm_device_hw_addr_set_cloned (device, connection, FALSE)) { - NM_SET_OUT (out_failure_reason, NM_DEVICE_STATE_REASON_CONFIG_FAILED); - return NM_ACT_STAGE_RETURN_FAILURE; - } - for (option = master_options; option->name; option++) commit_option (device, s_bridge, option, FALSE); @@ -758,6 +753,7 @@ nm_device_bridge_class_init (NMDeviceBridgeClass *klass) device_class->master_update_slave_connection = master_update_slave_connection; device_class->create_and_realize = create_and_realize; + device_class->act_stage1_prepare_set_hwaddr_ethernet = TRUE; device_class->act_stage1_prepare = act_stage1_prepare; device_class->act_stage2_config = act_stage2_config; device_class->deactivate = deactivate; diff --git a/src/devices/nm-device-vlan.c b/src/devices/nm-device-vlan.c index 616565de9c..14720b4b44 100644 --- a/src/devices/nm-device-vlan.c +++ b/src/devices/nm-device-vlan.c @@ -478,9 +478,6 @@ act_stage1_prepare (NMDevice *device, NMDeviceStateReason *out_failure_reason) NMDevice *parent_device; NMSettingVlan *s_vlan; - if (!nm_device_hw_addr_set_cloned (device, nm_device_get_applied_connection (device), FALSE)) - return NM_ACT_STAGE_RETURN_FAILURE; - /* Change MAC address to parent's one if needed */ parent_device = nm_device_parent_get_device (device); if (parent_device) { @@ -599,6 +596,7 @@ nm_device_vlan_class_init (NMDeviceVlanClass *klass) device_class->link_changed = link_changed; device_class->unrealize_notify = unrealize_notify; device_class->get_generic_capabilities = get_generic_capabilities; + device_class->act_stage1_prepare_set_hwaddr_ethernet = TRUE; device_class->act_stage1_prepare = act_stage1_prepare; device_class->get_configured_mtu = get_configured_mtu; device_class->is_available = is_available; |