summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2019-08-21 13:10:24 +0200
committerThomas Haller <thaller@redhat.com>2019-08-28 16:27:00 +0200
commit96cd0ca62f9100bab9952cf18aad0baae4477cee (patch)
tree51d450eaba69b60e61de70eaeaeb15774e945b31
parent8b121c70488bd45461847a2f1cc501ad7aa087a4 (diff)
downloadNetworkManager-96cd0ca62f9100bab9952cf18aad0baae4477cee.tar.gz
modem/trivial: rename virtual function NMModemClass.act_stage1_prepare()
NMDeviceClass already has a function with this name. It's confusing to have multiple virtual functions named the same. Rename.
-rw-r--r--src/devices/wwan/nm-modem-broadband.c8
-rw-r--r--src/devices/wwan/nm-modem-ofono.c8
-rw-r--r--src/devices/wwan/nm-modem.c10
-rw-r--r--src/devices/wwan/nm-modem.h6
4 files changed, 16 insertions, 16 deletions
diff --git a/src/devices/wwan/nm-modem-broadband.c b/src/devices/wwan/nm-modem-broadband.c
index 216fedfec6..80a3614e5f 100644
--- a/src/devices/wwan/nm-modem-broadband.c
+++ b/src/devices/wwan/nm-modem-broadband.c
@@ -586,9 +586,9 @@ connect_context_step (NMModemBroadband *self)
}
static NMActStageReturn
-act_stage1_prepare (NMModem *_self,
- NMConnection *connection,
- NMDeviceStateReason *out_failure_reason)
+modem_act_stage1_prepare (NMModem *_self,
+ NMConnection *connection,
+ NMDeviceStateReason *out_failure_reason)
{
NMModemBroadband *self = NM_MODEM_BROADBAND (_self);
@@ -1512,7 +1512,7 @@ nm_modem_broadband_class_init (NMModemBroadbandClass *klass)
modem_class->get_user_pass = get_user_pass;
modem_class->check_connection_compatible_with_modem = check_connection_compatible_with_modem;
modem_class->complete_connection = complete_connection;
- modem_class->act_stage1_prepare = act_stage1_prepare;
+ modem_class->modem_act_stage1_prepare = modem_act_stage1_prepare;
modem_class->owns_port = owns_port;
obj_properties[PROP_MODEM] =
diff --git a/src/devices/wwan/nm-modem-ofono.c b/src/devices/wwan/nm-modem-ofono.c
index 31111b62b7..262e57fd84 100644
--- a/src/devices/wwan/nm-modem-ofono.c
+++ b/src/devices/wwan/nm-modem-ofono.c
@@ -1114,9 +1114,9 @@ create_connect_properties (NMConnection *connection)
}
static NMActStageReturn
-act_stage1_prepare (NMModem *modem,
- NMConnection *connection,
- NMDeviceStateReason *out_failure_reason)
+modem_act_stage1_prepare (NMModem *modem,
+ NMConnection *connection,
+ NMDeviceStateReason *out_failure_reason)
{
NMModemOfono *self = NM_MODEM_OFONO (modem);
NMModemOfonoPrivate *priv = NM_MODEM_OFONO_GET_PRIVATE (self);
@@ -1308,6 +1308,6 @@ nm_modem_ofono_class_init (NMModemOfonoClass *klass)
modem_class->deactivate_cleanup = deactivate_cleanup;
modem_class->check_connection_compatible_with_modem = check_connection_compatible_with_modem;
- modem_class->act_stage1_prepare = act_stage1_prepare;
+ modem_class->modem_act_stage1_prepare = modem_act_stage1_prepare;
modem_class->static_stage3_ip4_config_start = static_stage3_ip4_config_start;
}
diff --git a/src/devices/wwan/nm-modem.c b/src/devices/wwan/nm-modem.c
index 617096a76a..3057ee8b82 100644
--- a/src/devices/wwan/nm-modem.c
+++ b/src/devices/wwan/nm-modem.c
@@ -974,9 +974,9 @@ nm_modem_get_secrets (NMModem *self,
/*****************************************************************************/
static NMActStageReturn
-act_stage1_prepare (NMModem *modem,
- NMConnection *connection,
- NMDeviceStateReason *out_failure_reason)
+modem_act_stage1_prepare (NMModem *modem,
+ NMConnection *connection,
+ NMDeviceStateReason *out_failure_reason)
{
NM_SET_OUT (out_failure_reason, NM_DEVICE_STATE_REASON_UNKNOWN);
return NM_ACT_STAGE_RETURN_FAILURE;
@@ -1003,7 +1003,7 @@ nm_modem_act_stage1_prepare (NMModem *self,
setting_name = nm_connection_need_secrets (connection, &hints);
if (!setting_name) {
nm_assert (!hints);
- return NM_MODEM_GET_CLASS (self)->act_stage1_prepare (self, connection, out_failure_reason);
+ return NM_MODEM_GET_CLASS (self)->modem_act_stage1_prepare (self, connection, out_failure_reason);
}
/* Secrets required... */
@@ -1798,7 +1798,7 @@ nm_modem_class_init (NMModemClass *klass)
object_class->dispose = dispose;
object_class->finalize = finalize;
- klass->act_stage1_prepare = act_stage1_prepare;
+ klass->modem_act_stage1_prepare = modem_act_stage1_prepare;
klass->stage3_ip6_config_request = stage3_ip6_config_request;
klass->deactivate_cleanup = deactivate_cleanup;
diff --git a/src/devices/wwan/nm-modem.h b/src/devices/wwan/nm-modem.h
index f5b386e8b2..3741c64667 100644
--- a/src/devices/wwan/nm-modem.h
+++ b/src/devices/wwan/nm-modem.h
@@ -136,9 +136,9 @@ typedef struct {
NMConnection *const*existing_connections,
GError **error);
- NMActStageReturn (*act_stage1_prepare) (NMModem *modem,
- NMConnection *connection,
- NMDeviceStateReason *out_failure_reason);
+ NMActStageReturn (*modem_act_stage1_prepare) (NMModem *modem,
+ NMConnection *connection,
+ NMDeviceStateReason *out_failure_reason);
NMActStageReturn (*static_stage3_ip4_config_start) (NMModem *self,
NMActRequest *req,