summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLubomir Rintel <lkundrak@v3.sk>2019-06-12 17:10:09 +0200
committerLubomir Rintel <lkundrak@v3.sk>2019-06-14 10:32:53 +0200
commitb1feebc43aafd5e40c371c2a971cdefd5f8acae6 (patch)
tree80a946e10855a5f85a670877cb2b01f28db74334
parent99c7adc1e12862f22026bb8f806c9223db9a78ec (diff)
downloadNetworkManager-b1feebc43aafd5e40c371c2a971cdefd5f8acae6.tar.gz
ovs/ovsdb: remove the device-changes signal
It doesn't communicate anything about the nature of the change and indeed nothing uses it.
-rw-r--r--src/devices/ovs/nm-ovsdb.c14
-rw-r--r--src/devices/ovs/nm-ovsdb.h1
2 files changed, 0 insertions, 15 deletions
diff --git a/src/devices/ovs/nm-ovsdb.c b/src/devices/ovs/nm-ovsdb.c
index a08a3647f5..a93aa70a1f 100644
--- a/src/devices/ovs/nm-ovsdb.c
+++ b/src/devices/ovs/nm-ovsdb.c
@@ -58,7 +58,6 @@ typedef struct {
enum {
DEVICE_ADDED,
DEVICE_REMOVED,
- DEVICE_CHANGED,
LAST_SIGNAL
};
@@ -925,8 +924,6 @@ ovsdb_got_update (NMOvsdb *self, json_t *msg)
_LOGT ("changed an '%s' interface: %s%s%s", type, ovs_interface->name,
ovs_interface->connection_uuid ? ", " : "",
ovs_interface->connection_uuid ?: "");
- g_signal_emit (self, signals[DEVICE_CHANGED], 0,
- "ovs-interface", ovs_interface->name);
} else {
_LOGT ("added an '%s' interface: %s%s%s",
ovs_interface->type, ovs_interface->name,
@@ -980,8 +977,6 @@ ovsdb_got_update (NMOvsdb *self, json_t *msg)
_LOGT ("changed a port: %s%s%s", ovs_port->name,
ovs_port->connection_uuid ? ", " : "",
ovs_port->connection_uuid ?: "");
- g_signal_emit (self, signals[DEVICE_CHANGED], 0,
- NM_SETTING_OVS_PORT_SETTING_NAME, ovs_port->name);
} else {
_LOGT ("added a port: %s%s%s", ovs_port->name,
ovs_port->connection_uuid ? ", " : "",
@@ -1030,8 +1025,6 @@ ovsdb_got_update (NMOvsdb *self, json_t *msg)
_LOGT ("changed a bridge: %s%s%s", ovs_bridge->name,
ovs_bridge->connection_uuid ? ", " : "",
ovs_bridge->connection_uuid ?: "");
- g_signal_emit (self, signals[DEVICE_CHANGED], 0,
- NM_SETTING_OVS_BRIDGE_SETTING_NAME, ovs_bridge->name);
} else {
_LOGT ("added a bridge: %s%s%s", ovs_bridge->name,
ovs_bridge->connection_uuid ? ", " : "",
@@ -1592,11 +1585,4 @@ nm_ovsdb_class_init (NMOvsdbClass *klass)
G_SIGNAL_RUN_LAST,
0, NULL, NULL, NULL,
G_TYPE_NONE, 2, G_TYPE_POINTER, G_TYPE_UINT);
-
- signals[DEVICE_CHANGED] =
- g_signal_new (NM_OVSDB_DEVICE_CHANGED,
- G_OBJECT_CLASS_TYPE (object_class),
- G_SIGNAL_RUN_LAST,
- 0, NULL, NULL, NULL,
- G_TYPE_NONE, 2, G_TYPE_POINTER, G_TYPE_UINT);
}
diff --git a/src/devices/ovs/nm-ovsdb.h b/src/devices/ovs/nm-ovsdb.h
index cf9fe2a21b..c7f391fe31 100644
--- a/src/devices/ovs/nm-ovsdb.h
+++ b/src/devices/ovs/nm-ovsdb.h
@@ -29,7 +29,6 @@
#define NM_OVSDB_DEVICE_ADDED "device-added"
#define NM_OVSDB_DEVICE_REMOVED "device-removed"
-#define NM_OVSDB_DEVICE_CHANGED "device-changed"
typedef struct _NMOvsdb NMOvsdb;
typedef struct _NMOvsdbClass NMOvsdbClass;