summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2022-11-30 17:14:43 +0100
committerThomas Haller <thaller@redhat.com>2022-12-20 10:34:55 +0100
commit77f3227cb86493a24d07915ca75efa2410d69349 (patch)
tree3d61373a52dde5d71d7918926cd7c128bf2b5051
parentb9bbbfc41f8c636b0088323ee0f0c6df5be5496b (diff)
downloadNetworkManager-77f3227cb86493a24d07915ca75efa2410d69349.tar.gz
libnm: use struct initialization in nm_bridge_vlan_new()
I think it's just a nicer pattern. It also ensures that all fields are initialized to their type's default and don't rely on memset().
-rw-r--r--src/libnm-core-impl/nm-setting-bridge.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/src/libnm-core-impl/nm-setting-bridge.c b/src/libnm-core-impl/nm-setting-bridge.c
index 2aee47048e..1da740a1ce 100644
--- a/src/libnm-core-impl/nm-setting-bridge.c
+++ b/src/libnm-core-impl/nm-setting-bridge.c
@@ -148,11 +148,12 @@ nm_bridge_vlan_new(guint16 vid_start, guint16 vid_end)
g_return_val_if_fail(vid_end <= NM_BRIDGE_VLAN_VID_MAX, NULL);
g_return_val_if_fail(vid_start <= vid_end, NULL);
- vlan = g_slice_new0(NMBridgeVlan);
- vlan->refcount = 1;
- vlan->vid_start = vid_start;
- vlan->vid_end = vid_end;
-
+ vlan = g_slice_new(NMBridgeVlan);
+ *vlan = (NMBridgeVlan){
+ .refcount = 1,
+ .vid_start = vid_start,
+ .vid_end = vid_end,
+ };
return vlan;
}