summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2016-03-06 17:06:50 +0100
committerThomas Haller <thaller@redhat.com>2016-03-06 17:06:50 +0100
commita5e09d28870f0a4f16bb0a81035079ba3b533f7d (patch)
treef403968d8aaf2f48facccc4afd4c77ae1bfcb55e
parentdf9ac197c01672305430de2d37fe4ecf42470d55 (diff)
downloadNetworkManager-a5e09d28870f0a4f16bb0a81035079ba3b533f7d.tar.gz
libnm-util: remove unneeded check for non-null after dereferencing pointer
Since commit 01b9b4104c365002fae5e45b564956062fe146d4, we assume that @error is properly set. No need to check for non-null. Found by coverity.
-rw-r--r--libnm-util/nm-utils.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/libnm-util/nm-utils.c b/libnm-util/nm-utils.c
index 24f233f913..084f0f548a 100644
--- a/libnm-util/nm-utils.c
+++ b/libnm-util/nm-utils.c
@@ -1515,15 +1515,13 @@ nm_utils_uuid_generate_from_string (const char *s)
if (!nm_utils_init (&error)) {
g_warning ("error initializing crypto: %s", error->message);
- if (error)
- g_error_free (error);
+ g_error_free (error);
return NULL;
}
if (!crypto_md5_hash (NULL, 0, s, strlen (s), (char *) uuid, sizeof (uuid), &error)) {
g_warning ("error generating UUID: %s", error->message);
- if (error)
- g_error_free (error);
+ g_error_free (error);
return NULL;
}