diff options
| author | Thomas Haller <thaller@redhat.com> | 2020-01-30 11:39:35 +0100 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2020-01-30 11:39:42 +0100 |
| commit | c1060080913e16a101c955ee69298ecf1c6452d3 (patch) | |
| tree | 502bc27facb3aeedf9ceaf0202334851eded5998 | |
| parent | 1ccdce0c1db175f0b5d135ff705398dec29f0560 (diff) | |
| download | NetworkManager-c1060080913e16a101c955ee69298ecf1c6452d3.tar.gz | |
supplicant: fix memory corruption with wrong argument to NM_SUPPLICANT_INTERFACE_GROUP_FORMATION_FAILURE signal
The signal is unused (and should be removed).
Still, the parameter passed to g_signal_emit() is a C string, not a
GVariant. I think as there are no subscribers, glib wouldn't actually
do anything with the arguments. Though, I am not sure whether glib still
tries to initialize a GValue with a GVariant type, leading to a crash.
Fixes: f05b7a78c9aa ('supplicant: Track P2P Group information, creation and destruction')
| -rw-r--r-- | src/supplicant/nm-supplicant-interface.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/supplicant/nm-supplicant-interface.c b/src/supplicant/nm-supplicant-interface.c index 794955b3d9..dca434c7c9 100644 --- a/src/supplicant/nm-supplicant-interface.c +++ b/src/supplicant/nm-supplicant-interface.c @@ -3184,5 +3184,5 @@ nm_supplicant_interface_class_init (NMSupplicantInterfaceClass *klass) G_SIGNAL_RUN_LAST, 0, NULL, NULL, NULL, - G_TYPE_NONE, 1, G_TYPE_VARIANT); + G_TYPE_NONE, 1, G_TYPE_STRING); } |