summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJiří Klimeš <jklimes@redhat.com>2013-12-05 12:11:36 +0100
committerDan Winship <danw@gnome.org>2014-03-18 11:48:55 -0400
commitbf019e1a70f4810738713e2a3501bb2da839ae59 (patch)
treec364e8f095bbb42357a2910e9f769aa60e3129eb
parent689a881943002923e3ad2261e3a35b2bb43a8def (diff)
downloadNetworkManager-bf019e1a70f4810738713e2a3501bb2da839ae59.tar.gz
libnm-util: don't touch dhcp-send-hostname when setting dhcp-hostname (rh #1001529)
It is better to leave it to user whether he wants to enable sending hostname, because he probably disabled it manually (dhcp-send-hostname is TRUE by default). Also, this would not work for plugins that read and set dhcp-hostname after dhcp-send-hostname. https://bugzilla.redhat.com/show_bug.cgi?id=1001529
-rw-r--r--libnm-util/nm-setting-ip4-config.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/libnm-util/nm-setting-ip4-config.c b/libnm-util/nm-setting-ip4-config.c
index 90534c12d0..34f5c8fbd7 100644
--- a/libnm-util/nm-setting-ip4-config.c
+++ b/libnm-util/nm-setting-ip4-config.c
@@ -901,9 +901,6 @@ set_property (GObject *object, guint prop_id,
case PROP_DHCP_HOSTNAME:
g_free (priv->dhcp_hostname);
priv->dhcp_hostname = g_value_dup_string (value);
- /* FIXME: Is this a good idea? */
- if (priv->dhcp_hostname)
- priv->dhcp_send_hostname = TRUE;
break;
case PROP_NEVER_DEFAULT:
priv->never_default = g_value_get_boolean (value);