summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBeniamino Galvani <bgalvani@redhat.com>2018-06-05 14:38:58 +0200
committerBeniamino Galvani <bgalvani@redhat.com>2018-06-05 14:49:24 +0200
commit92ebd16cee2a7a306abae7fd3cba3f1366471f14 (patch)
tree575580580c669be32208fcb8864415797a70e8ab
parent7696e6c1fa871236832a1e4eb6671c406efba867 (diff)
downloadNetworkManager-92ebd16cee2a7a306abae7fd3cba3f1366471f14.tar.gz
cli: fix array out-of-bounds access on command timeout
Fixes: 4b3297271e6f7502631719148d5880489ec56eff https://bugzilla.redhat.com/show_bug.cgi?id=1573839
-rw-r--r--clients/cli/connections.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/clients/cli/connections.c b/clients/cli/connections.c
index f8caa10dfe..9b66916fb0 100644
--- a/clients/cli/connections.c
+++ b/clients/cli/connections.c
@@ -2839,7 +2839,7 @@ connection_cb_info_finish (ConnectionCbInfo *info, gpointer obj)
} else {
while (info->obj_list->len > 0) {
obj = info->obj_list->pdata[info->obj_list->len - 1];
- g_ptr_array_remove_index (info->obj_list, info->obj_list->len);
+ g_ptr_array_remove_index (info->obj_list, info->obj_list->len - 1);
connection_cb_info_obj_list_destroy (info, obj);
}
}