diff options
| author | Thomas Haller <thaller@redhat.com> | 2014-12-22 12:30:06 +0100 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2014-12-22 15:28:00 +0100 |
| commit | 5ef233936ad270b45c65daccbfd939c5c3c4c0c0 (patch) | |
| tree | 374aaa3ae3686d2c161e91d65d05acc3e6882b88 | |
| parent | 17017f08314e823880d7a9d69c32d3fa37758d09 (diff) | |
| download | NetworkManager-5ef233936ad270b45c65daccbfd939c5c3c4c0c0.tar.gz | |
nmcli/bash-completion: fix detecting connection for connection modify
Previously we would only complete connections given by ID.
The following would work:
$ nmcli connection modify id <ID> <TAB>
$ nmcli connection modify <ID> <TAB>
$ nmcli connection modify uuid <UUID> <TAB>
but the following would not work:
$ nmcli connection modify <UUID> <TAB>
| -rw-r--r-- | clients/cli/nmcli-completion | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/clients/cli/nmcli-completion b/clients/cli/nmcli-completion index 73028bdff2..35062a5fa9 100644 --- a/clients/cli/nmcli-completion +++ b/clients/cli/nmcli-completion @@ -1159,14 +1159,14 @@ _nmcli() if [[ "${words[0]:0:1}" == [+-] ]]; then PREFIX="${words[0]:0:1}" fi - _nmcli_list_nl "$(nmcli --fields profile connection show "${COMMAND_CONNECTION_TYPE:-id}" "$COMMAND_CONNECTION_ID" 2>/dev/null | sed -n 's/^\([^:]\+\):.*/'$PREFIX'\1/p')" + _nmcli_list_nl "$(nmcli --fields profile connection show ${COMMAND_CONNECTION_TYPE} "$COMMAND_CONNECTION_ID" 2>/dev/null | sed -n 's/^\([^:]\+\):.*/'$PREFIX'\1/p')" return 0 elif [[ ${#words[@]} -le 2 ]]; then return 0 fi _nmcli_array_delete_at words 0 1 done - _nmcli_list_nl "$(nmcli --fields profile connection show "${COMMAND_CONNECTION_TYPE:-id}" "$COMMAND_CONNECTION_ID" 2>/dev/null | sed -n 's/^\([^:]\+\):.*/\1/p')" + _nmcli_list_nl "$(nmcli --fields profile connection show ${COMMAND_CONNECTION_TYPE} "$COMMAND_CONNECTION_ID" 2>/dev/null | sed -n 's/^\([^:]\+\):.*/\1/p')" return 0 fi ;; |