diff options
| author | Thomas Haller <thaller@redhat.com> | 2015-02-26 02:38:14 +0100 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2015-03-12 18:12:26 +0100 |
| commit | 0f1fe6942253bfdfa35c1108049baeb2be048bb7 (patch) | |
| tree | 63060b95ac59da56950a6bfcce06a9fa19507dc9 | |
| parent | 11371b5470a890512b697d0926a242d9aefe9d1d (diff) | |
| download | NetworkManager-0f1fe6942253bfdfa35c1108049baeb2be048bb7.tar.gz | |
trivial: add FIXME code comment about potential race
| -rw-r--r-- | libnm-core/nm-setting-8021x.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/libnm-core/nm-setting-8021x.c b/libnm-core/nm-setting-8021x.c index a02e7114d5..dbead46253 100644 --- a/libnm-core/nm-setting-8021x.c +++ b/libnm-core/nm-setting-8021x.c @@ -1870,7 +1870,8 @@ nm_setting_802_1x_set_private_key (NMSetting8021x *setting, priv->private_key_password = g_strdup (password); if (scheme == NM_SETTING_802_1X_CK_SCHEME_BLOB) { - /* Shouldn't fail this since we just verified the private key above */ + /* FIXME: potential race after verifying the private key above */ + /* FIXME: ensure blob doesn't start with file:// */ priv->private_key = file_to_secure_bytes (key_path); g_assert (priv->private_key); } else if (scheme == NM_SETTING_802_1X_CK_SCHEME_PATH) @@ -2181,7 +2182,8 @@ nm_setting_802_1x_set_phase2_private_key (NMSetting8021x *setting, priv->phase2_private_key_password = g_strdup (password); if (scheme == NM_SETTING_802_1X_CK_SCHEME_BLOB) { - /* Shouldn't fail this since we just verified the private key above */ + /* FIXME: potential race after verifying the private key above */ + /* FIXME: ensure blob doesn't start with file:// */ priv->phase2_private_key = file_to_secure_bytes (key_path); g_assert (priv->phase2_private_key); } else if (scheme == NM_SETTING_802_1X_CK_SCHEME_PATH) |