diff options
| author | Thomas Haller <thaller@redhat.com> | 2019-06-11 12:01:56 +0200 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2019-06-11 13:25:21 +0200 |
| commit | 91d8038a81946fd3cccf2b7c024b94e69dc6e40b (patch) | |
| tree | 82ee6517fabb08d921ac960217fbb03493148afc | |
| parent | 356a159731cc3619aea54b1c421dc2ba522b4e2e (diff) | |
| download | NetworkManager-91d8038a81946fd3cccf2b7c024b94e69dc6e40b.tar.gz | |
cli: fix default value for team.runner-min-ports
The default value is "1", not "0". Also, because "0" is not actually a
valid value as far as teamd is concerned. This fixes:
$ nmcli connection add type team autoconnect no con-name t team.runner lacp team.runner-min-ports default
Error: Failed to add 't' connection: team.runner-min-ports: value out or range
See "teamd.conf" manual:
runner.min_ports (int)
Specifies the minimum number of ports that must be active before asserting
carrier in the master interface, value can be 1 – 255.
Default: 1
This mistake probably happend because the teamd manual is wrong in older versions [1].
[1] https://github.com/jpirko/libteam/commit/f36c191da3d65a4744582b2eb09fa297dd85f9ae
https://bugzilla.redhat.com/show_bug.cgi?id=1716987
| -rw-r--r-- | clients/common/nm-meta-setting-desc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clients/common/nm-meta-setting-desc.c b/clients/common/nm-meta-setting-desc.c index 25969cd1f1..4492d1944f 100644 --- a/clients/common/nm-meta-setting-desc.c +++ b/clients/common/nm-meta-setting-desc.c @@ -6574,7 +6574,7 @@ static const NMMetaPropertyInfo *const property_infos_TEAM[] = { .nick = "unset", }, { - .value.i64 = 0, + .value.i64 = 1, .nick = "default", }, ), |