summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2019-06-11 14:47:26 +0200
committerThomas Haller <thaller@redhat.com>2019-06-11 14:58:14 +0200
commita4c14895072da61ad790551111e770e705897ba5 (patch)
treea9396af8978ce30bc12eb89f36d62e8c26a6b2a5
parenta530921f401f78106ffdbe3ff59021ff696cb95a (diff)
downloadNetworkManager-a4c14895072da61ad790551111e770e705897ba5.tar.gz
libnm: belatedly expose nm_ethtool_optname_is_feature() in libnm
Also, plan right away to backport this symbol all the way back to 1.14.8. As such, we only need to add it once, with the right linker version "libnm_1_14_8". But still, the symbols first appears on a major release 1.20.0.
-rw-r--r--libnm-core/nm-setting-ethtool.c8
-rw-r--r--libnm-core/nm-setting-ethtool.h2
-rw-r--r--libnm/libnm.ver4
3 files changed, 11 insertions, 3 deletions
diff --git a/libnm-core/nm-setting-ethtool.c b/libnm-core/nm-setting-ethtool.c
index 29cb401290..555ac34df0 100644
--- a/libnm-core/nm-setting-ethtool.c
+++ b/libnm-core/nm-setting-ethtool.c
@@ -38,13 +38,17 @@
/**
* nm_ethtool_optname_is_feature:
- * @optname: the option name to check
+ * @optname: (allow-none): the option name to check
*
* Checks whether @optname is a valid option name for an offload feature.
*
* %Returns: %TRUE, if @optname is valid
*
- * Since: 1.14
+ * Since: 1.20
+ *
+ * Note that nm_ethtool_optname_is_feature() was first added to the libnm header files
+ * in 1.14.0 but forgot to actually add to the library. This happened belatedly in 1.20.0 and
+ * the stable versions 1.18.2, 1.16.4 and 1.14.8 (with linker version "libnm_1_14_8").
*/
gboolean
nm_ethtool_optname_is_feature (const char *optname)
diff --git a/libnm-core/nm-setting-ethtool.h b/libnm-core/nm-setting-ethtool.h
index 09f3753243..7b747be983 100644
--- a/libnm-core/nm-setting-ethtool.h
+++ b/libnm-core/nm-setting-ethtool.h
@@ -83,7 +83,7 @@ G_BEGIN_DECLS
#define NM_ETHTOOL_OPTNAME_FEATURE_TX_UDP_TNL_SEGMENTATION "feature-tx-udp_tnl-segmentation"
#define NM_ETHTOOL_OPTNAME_FEATURE_TX_VLAN_STAG_HW_INSERT "feature-tx-vlan-stag-hw-insert"
-NM_AVAILABLE_IN_1_14
+NM_AVAILABLE_IN_1_20
gboolean nm_ethtool_optname_is_feature (const char *optname);
/*****************************************************************************/
diff --git a/libnm/libnm.ver b/libnm/libnm.ver
index 57fc7331f3..7b87112553 100644
--- a/libnm/libnm.ver
+++ b/libnm/libnm.ver
@@ -1445,6 +1445,10 @@ global:
nm_utils_sriov_vf_to_str;
} libnm_1_12_0;
+libnm_1_14_8 {
+ nm_ethtool_optname_is_feature;
+} libnm_1_14_0;
+
libnm_1_16_0 {
global:
nm_client_add_and_activate_connection2;