diff options
| author | Lubomir Rintel <lkundrak@v3.sk> | 2015-05-17 20:49:06 +0200 |
|---|---|---|
| committer | Lubomir Rintel <lkundrak@v3.sk> | 2015-06-02 12:30:03 +0200 |
| commit | 84021454eb0b126fda9cf29c46b7860f75c7ff8c (patch) | |
| tree | b0436c981065d176096a2980a113b3e2930819b5 | |
| parent | e486a3803d74d406d014847cc88f50cd1cef87c7 (diff) | |
| download | NetworkManager-lr/ancient-ubuntu.tar.gz | |
build: don't default to -Werrorlr/ancient-ubuntu
It seems like a poor default for various downstream toolchains. We can't
anticipate the compiler warnings for future compiler versions and older
ones are prone to false positives. Also, older gdbus-codegen is known
to generate code that triggers compiler warnings.
Let's keep it enabled for maintainer builds and distcheck so that we're
sure a tool chain that builds releases without warnings exists.
| -rw-r--r-- | Makefile.am | 2 | ||||
| -rwxr-xr-x | autogen.sh | 2 | ||||
| -rw-r--r-- | m4/compiler_warnings.m4 | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/Makefile.am b/Makefile.am index 18bb6c68c0..2420f3bbfd 100644 --- a/Makefile.am +++ b/Makefile.am @@ -59,7 +59,7 @@ DISTCLEANFILES = intltool-extract intltool-merge intltool-update pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = NetworkManager.pc -ACLOCAL_AMFLAGS = -I m4 ${ACLOCAL_FLAGS} +DISTCHECK_CONFIGURE_FLAGS = --enable-more-warnings=error CLEANFILES = cscope.in.out cscope.out cscope.po.out diff --git a/autogen.sh b/autogen.sh index 141bcf120e..5ec9a5aa88 100755 --- a/autogen.sh +++ b/autogen.sh @@ -28,5 +28,5 @@ AUTOPOINT='intltoolize --automake --copy' autoreconf --force --install --verbose cd $olddir if test -z "$NOCONFIGURE"; then - exec $srcdir/configure --enable-maintainer-mode "$@" + exec $srcdir/configure --enable-maintainer-mode --enable-more-warnings=error "$@" fi diff --git a/m4/compiler_warnings.m4 b/m4/compiler_warnings.m4 index 5c8d207770..a1c4e12884 100644 --- a/m4/compiler_warnings.m4 +++ b/m4/compiler_warnings.m4 @@ -22,7 +22,7 @@ AC_DEFUN([NM_COMPILER_WARNING], [ AC_DEFUN([NM_COMPILER_WARNINGS], [AC_ARG_ENABLE(more-warnings, AS_HELP_STRING([--enable-more-warnings], [Possible values: no/yes/error]), - set_more_warnings="$enableval",set_more_warnings=error) + set_more_warnings="$enableval",set_more_warnings=yes) AC_MSG_CHECKING(for more warnings) if test "$GCC" = "yes" -a "$set_more_warnings" != "no"; then AC_MSG_RESULT(yes) |