diff options
| author | Lubomir Rintel <lkundrak@v3.sk> | 2016-07-26 12:45:35 +0200 |
|---|---|---|
| committer | Lubomir Rintel <lkundrak@v3.sk> | 2016-07-26 12:45:35 +0200 |
| commit | 54c0571bf5f16a713f401205b38081128e0d209e (patch) | |
| tree | 14a17c644c8e0d0d89ba787002b8447375e6ad19 | |
| parent | c544bac3dd1ec007395da0acf1533eb5a9621bb0 (diff) | |
| download | NetworkManager-lr/atul/proxy.tar.gz | |
clang warningslr/atul/proxy
| -rw-r--r-- | src/nm-pacrunner-manager.c | 1 | ||||
| -rw-r--r-- | src/nm-proxy-config.c | 8 |
2 files changed, 4 insertions, 5 deletions
diff --git a/src/nm-pacrunner-manager.c b/src/nm-pacrunner-manager.c index 23d12491f6..d56fa20a89 100644 --- a/src/nm-pacrunner-manager.c +++ b/src/nm-pacrunner-manager.c @@ -288,7 +288,6 @@ pacrunner_proxy_cb (GObject *source, GAsyncResult *res, gpointer user_data) NMPacRunnerManager *self = NULL; NMPacRunnerManagerPrivate *priv; gs_free_error GError *error = NULL; - gs_free char *owner = NULL; GDBusProxy *proxy; self = NM_PACRUNNER_MANAGER (user_data); diff --git a/src/nm-proxy-config.c b/src/nm-proxy-config.c index c180c84bf2..1e4d741fea 100644 --- a/src/nm-proxy-config.c +++ b/src/nm-proxy-config.c @@ -195,7 +195,7 @@ nm_proxy_config_create_setting (const NMProxyConfig *config) tmp = strchr (tmp, ':') + 1; str = g_strndup (tmp, strchr (tmp, '/') - tmp); port = (guint32) atoi (str); - if (port >= 0) + if (port > 0) g_object_set (s_proxy, NM_SETTING_PROXY_HTTP_PORT, port, NULL); g_free (str); @@ -209,7 +209,7 @@ nm_proxy_config_create_setting (const NMProxyConfig *config) tmp = strchr (tmp, ':') + 1; str = g_strndup (tmp, strchr (tmp, '/') - tmp); port = (guint32) atoi (str); - if (port >= 0) + if (port > 0) g_object_set (s_proxy, NM_SETTING_PROXY_SSL_PORT, port, NULL); g_free (str); @@ -222,7 +222,7 @@ nm_proxy_config_create_setting (const NMProxyConfig *config) tmp = strchr (tmp, ':') + 1; str = g_strndup (tmp, strchr (tmp, '/') - tmp); port = (guint32) atoi (str); - if (port >= 0) + if (port > 0) g_object_set (s_proxy, NM_SETTING_PROXY_FTP_PORT, port, NULL); g_free (str); @@ -240,7 +240,7 @@ nm_proxy_config_create_setting (const NMProxyConfig *config) tmp = strchr (tmp, ':') + 1; str = g_strndup (tmp, strchr (tmp, '/') - tmp); port = (guint32) atoi (str); - if (port >= 0) + if (port > 0) g_object_set (s_proxy, NM_SETTING_PROXY_SOCKS_PORT, port, NULL); g_free (str); } |