core: fix memleak in nm_utils_get_start_time_for_pid() and parsing start-time

It was leaking @tokens in case of error. Also the error checking of
start-time with strtoull() was erroneous.

1 files changed, 7 insertions, 11 deletions

diff --git a/src/NetworkManagerUtils.c b/src/NetworkManagerUtils.c
index 579079bcc1..79c173825b 100644
--- a/src/NetworkManagerUtils.c
+++ b/src/NetworkManagerUtils.c
@@ -371,10 +371,10 @@ guint64
 nm_utils_get_start_time_for_pid (pid_t pid, char *out_state)
 {
 	guint64 start_time;
-	gchar *filename;
-	gchar *contents;
+	gs_free gchar *filename = NULL;
+	gs_free gchar *contents = NULL;
 	size_t length;
-	gchar **tokens;
+	gs_strfreev gchar **tokens = NULL;
 	guint num_tokens;
 	gchar *p;
 	gchar *endp;
@@ -410,19 +410,15 @@ nm_utils_get_start_time_for_pid (pid_t pid, char *out_state)
 	if (num_tokens < 20)
 		goto out;
 
+	errno = 0;
 	start_time = strtoull (tokens[19], &endp, 10);
-	if (endp == tokens[19])
-		goto out;
-
-	g_strfreev (tokens);
+	if (*endp != '\0' || errno != 0)
+		start_time = 0;
 
- out:
+out:
 	if (out_state)
 		*out_state = state;
 
-	g_free (filename);
-	g_free (contents);
-
 	return start_time;
 }