summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLubomir Rintel <lkundrak@v3.sk>2018-02-07 21:11:04 +0100
committerLubomir Rintel <lkundrak@v3.sk>2018-02-07 21:39:35 +0100
commit9e28688cef042cbe24e0718be4bd5ece8aeef474 (patch)
treee4ef91d4964f5d4b617b524ea2027c529d8afbf2
parent6857139ef0dd1cd7133c6832bac090ba3f0a55dc (diff)
downloadNetworkManager-9e28688cef042cbe24e0718be4bd5ece8aeef474.tar.gz
contrib/rpm: don't be too optimistic about enabling fatal warnings
Compilers change and err on the side of caution. That is perfectly well for those of us who care about programming things defensively, but is somewhat annoying to those who just wish to build the thing. We do have a separate debug conditional for enabling extra checks, use it instead of the test one.
-rw-r--r--contrib/fedora/rpm/NetworkManager.spec7
1 files changed, 2 insertions, 5 deletions
diff --git a/contrib/fedora/rpm/NetworkManager.spec b/contrib/fedora/rpm/NetworkManager.spec
index b38163a4ab..e2e2f43ea6 100644
--- a/contrib/fedora/rpm/NetworkManager.spec
+++ b/contrib/fedora/rpm/NetworkManager.spec
@@ -401,11 +401,6 @@ intltoolize --automake --copy --force
--with-dhcpcanon=no \
--with-config-dhcp-default=dhclient \
--with-crypto=nss \
-%if %{with test}
- --enable-more-warnings=error \
-%else
- --enable-more-warnings=yes \
-%endif
%if %{with sanitizer}
--enable-address-sanitizer \
--enable-undefined-sanitizer \
@@ -414,9 +409,11 @@ intltoolize --automake --copy --force
--disable-undefined-sanitizer \
%endif
%if %{with debug}
+ --enable-more-warnings=error \
--enable-more-logging \
--with-more-asserts=10000 \
%else
+ --enable-more-warnings=yes \
--disable-more-logging \
--without-more-asserts \
%endif