summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBeniamino Galvani <bgalvani@redhat.com>2019-05-16 11:29:00 +0200
committerBeniamino Galvani <bgalvani@redhat.com>2019-05-20 14:49:59 +0200
commit58db61545d101723e7cb45dc7eadc7e4ad7a4b0c (patch)
treee4d4a11a2502843dcdcc0251367a4cc5f0522da2
parentd33c995d45caadebe2c7cc0e3e625f0d828a7a4f (diff)
downloadNetworkManager-58db61545d101723e7cb45dc7eadc7e4ad7a4b0c.tar.gz
device: don't wait udev for devices created by us
If we created a software interface it is because we already decided that it should be managed, and so there is no point in waiting udev to check that the interface is not udev-unmanaged. We still wait udev for software interfaces created externally.
-rw-r--r--src/devices/nm-device.c20
1 files changed, 15 insertions, 5 deletions
diff --git a/src/devices/nm-device.c b/src/devices/nm-device.c
index 7757d18cab..d752f3b138 100644
--- a/src/devices/nm-device.c
+++ b/src/devices/nm-device.c
@@ -635,7 +635,8 @@ static void realize_start_setup (NMDevice *self,
gboolean assume_state_guess_assume,
const char *assume_state_connection_uuid,
gboolean set_nm_owned,
- NMUnmanFlagOp unmanaged_user_explicit);
+ NMUnmanFlagOp unmanaged_user_explicit,
+ gboolean force_platform_init);
static void _set_mtu (NMDevice *self, guint32 mtu);
static void _commit_mtu (NMDevice *self, const NMIP4Config *config);
static void _cancel_activation (NMDevice *self);
@@ -4081,7 +4082,8 @@ nm_device_realize_start (NMDevice *self,
assume_state_guess_assume,
assume_state_connection_uuid,
set_nm_owned,
- unmanaged_user_explicit);
+ unmanaged_user_explicit,
+ FALSE);
return TRUE;
}
@@ -4126,7 +4128,8 @@ nm_device_create_and_realize (NMDevice *self,
plink,
FALSE, /* assume_state_guess_assume */
NULL, /* assume_state_connection_uuid */
- FALSE, NM_UNMAN_FLAG_OP_FORGET);
+ FALSE, NM_UNMAN_FLAG_OP_FORGET,
+ TRUE);
nm_device_realize_finish (self, plink);
if (nm_device_get_managed (self, FALSE)) {
@@ -4243,6 +4246,8 @@ realize_start_notify (NMDevice *self,
* @set_nm_owned: if TRUE and device is a software-device, set nm-owned.
* TRUE.
* @unmanaged_user_explicit: the user-explict unmanaged flag to set.
+ * @force_platform_init: if TRUE the platform-init unmanaged flag is
+ * forcefully cleared.
*
* Update the device from backing resource properties (like hardware
* addresses, carrier states, driver/firmware info, etc). This function
@@ -4256,7 +4261,8 @@ realize_start_setup (NMDevice *self,
gboolean assume_state_guess_assume,
const char *assume_state_connection_uuid,
gboolean set_nm_owned,
- NMUnmanFlagOp unmanaged_user_explicit)
+ NMUnmanFlagOp unmanaged_user_explicit,
+ gboolean force_platform_init)
{
NMDevicePrivate *priv;
NMDeviceClass *klass;
@@ -4265,6 +4271,7 @@ realize_start_setup (NMDevice *self,
NMDeviceCapabilities capabilities = 0;
NMConfig *config;
guint real_rate;
+ gboolean unmanaged;
/* plink is a NMPlatformLink type, however, we require it to come from the platform
* cache (where else would it come from?). */
@@ -4395,9 +4402,12 @@ realize_start_setup (NMDevice *self,
nm_device_set_unmanaged_by_user_udev (self);
nm_device_set_unmanaged_by_user_conf (self);
+ unmanaged = plink
+ && !plink->initialized
+ && !force_platform_init;
nm_device_set_unmanaged_flags (self, NM_UNMANAGED_PLATFORM_INIT,
- plink && !plink->initialized);
+ unmanaged);
}
/**